starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Support multi-code-point characters in TerminalInput::HandleKey #3986

New Issue
Open
opened 2026-01-30 23:34:56 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 23:34:56 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (Sep 23, 2019).

Description of the new feature/enhancement

Starting with #2836 key events containing combinations like Shift. (here: US keyboard layout) will be mapped to their matching, potentially non-ASCII, counterparts (here: >).
This is achieved using the ToUnicodeEx method.

But this leads to a problem: ToUnicodeEx can potentially return multiple code points.
TerminalInput::HandleKey and its KeyEvent parameter only accept a single code point though.

👉 TerminalInput and KeyEvent should be modified to accommodate multi-code-point characters (i.e. e.g. by replacing wchar_t with std::wstring).

Originally created by @lhecker on GitHub (Sep 23, 2019). # Description of the new feature/enhancement Starting with #2836 key events containing combinations like <kbd>Shift</kbd><kbd>.</kbd> (here: US keyboard layout) will be mapped to their matching, potentially non-ASCII, counterparts (here: <kbd>></kbd>). This is achieved using the [`ToUnicodeEx` method](https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-tounicodeex). But this leads to a problem: `ToUnicodeEx` can potentially return multiple code points. [`TerminalInput::HandleKey`](https://github.com/microsoft/terminal/blob/8afc5b2f596335b47ecc89172ccd9820ec510579/src/terminal/input/terminalInput.cpp#L364) and its [`KeyEvent`](https://github.com/microsoft/terminal/blob/8afc5b2f596335b47ecc89172ccd9820ec510579/src/types/inc/IInputEvent.hpp#L120) parameter only accept a single code point though. 👉 `TerminalInput` and `KeyEvent` should be modified to accommodate multi-code-point characters (i.e. e.g. by replacing `wchar_t` with `std::wstring`).
claunia added the Issue-FeatureProduct-ConhostArea-InputProduct-Terminal labels 2026-01-30 23:34:56 +00:00
claunia commented 2026-01-30 23:34:57 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 23, 2019):

This is good and righteous work that needs a design -- a lot of the key input stuff that comes through TerminalInput is that way for compatibility with the ReadConsoleInput API. That API can only transit WCHARs 😄

@DHowett-MSFT commented on GitHub (Sep 23, 2019): This is good and righteous work that needs a design -- a lot of the key input stuff that comes through `TerminalInput` is that way for _compatibility with the ReadConsoleInput API_. That API can only transit WCHARs :smile:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Issue-Feature Product-Conhost Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3986
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?