starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Comments in profile.json cause crashes when a tab is closed #3993

New Issue
Closed
opened 2026-01-30 23:35:06 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 23:35:06 +00:00
Owner
Copy Link

Originally created by @iankronquist on GitHub (Sep 23, 2019).

When I add comments to my profile.json I am able to open new tabs, but when I close a tab the whole program hangs. If I remove the comments, closing tabs works fine.

My guess is that you're reparsing the profile.json every time a tab is closed with a different parser, or with the same parser in a mode with comments disabled, and then not handling an exception. Unfortunately, I don't have time to attach a debugger and find out for sure. Thanks for the new terminal, it's an overdue improvement.

Originally created by @iankronquist on GitHub (Sep 23, 2019). When I add comments to my profile.json I am able to open new tabs, but when I close a tab the whole program hangs. If I remove the comments, closing tabs works fine. My guess is that you're reparsing the profile.json every time a tab is closed with a different parser, or with the same parser in a mode with comments disabled, and then not handling an exception. Unfortunately, I don't have time to attach a debugger and find out for sure. Thanks for the new terminal, it's an overdue improvement.
claunia added the Needs-TriageNeeds-Author-FeedbackNo-Recent-Activity labels 2026-01-30 23:35:06 +00:00
claunia commented 2026-01-30 23:35:07 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 23, 2019):

This is probably correlation and not causation.

@DHowett-MSFT commented on GitHub (Sep 23, 2019): This is probably correlation and not causation.
claunia commented 2026-01-30 23:35:07 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 23, 2019):

/feedback

@DHowett-MSFT commented on GitHub (Sep 23, 2019): /feedback
claunia commented 2026-01-30 23:35:08 +00:00
Author
Owner
Copy Link

@iankronquist commented on GitHub (Sep 23, 2019):

It's definitely reproducible for me. I encourage you to give it a try.

@iankronquist commented on GitHub (Sep 23, 2019): It's definitely reproducible for me. I encourage you to give it a try.
claunia commented 2026-01-30 23:35:08 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Sep 23, 2019):

Oh, whoops: /feedback looks really bad and dismissive when the bot isn't working.

Would you mind filing feedback through the feedback hub, then using the [share feedback] button to get a link you can paste here?

We're only reloading settings when the file changes, so I'm concerned it might be some other bug wearing this one's clothing. 😄

@DHowett-MSFT commented on GitHub (Sep 23, 2019): Oh, whoops: `/feedback` looks really bad and dismissive when the bot isn't working. Would you mind filing feedback through the feedback hub, then using the [share feedback] button to get a link you can paste here? We're only reloading settings when the file changes, so I'm concerned it might be some other bug wearing this one's clothing. :smile:
claunia commented 2026-01-30 23:35:08 +00:00
Author
Owner
Copy Link

@PhMajerus commented on GitHub (Sep 24, 2019):

App shouldn't crash and instead try to recover gracefully or show an error description when configuration files are corrupted by the user, but let's be clear, JavaScript comments in a JSON file make it invalid.

Now we could argue all day about whether comments should be valid in JSON (I think it would greatly improve JSON configuration files), but the specs are unfortunately clear, and whenever Microsoft decides to apply common sense to extend a standard, they get in hot water.

Maybe the Windows Terminal should switch to using JSON5 instead of JSON for its configuration files?

@PhMajerus commented on GitHub (Sep 24, 2019): App shouldn't crash and instead try to recover gracefully or show an error description when configuration files are corrupted by the user, but let's be clear, JavaScript comments in a JSON file make it invalid. Now we could argue all day about whether comments should be valid in JSON (I think it would greatly improve JSON configuration files), but the specs are unfortunately clear, and whenever Microsoft decides to apply common sense to extend a standard, they get in hot water. Maybe the Windows Terminal should switch to using JSON5 instead of JSON for its configuration files?
claunia commented 2026-01-30 23:35:08 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 24, 2019):

Woah lets not get into a holy wardiscussion about whether or not json was the right choice for our settings file. The "comments in json" thing is almost certainly a red herring here. Jsoncpp, which we're using for our json parsing, has plenty of support for comments in json ("jsonc"). This is not the case of "Microsoft extending a standard", this is a case of Microsoft leveraging an existing open-source project and standard.

We have a bunch of other issues open that are all akin to "when I close a tab, the Terminal crashes". The root of them is generally #2375. It's much more likely that's at fault here, but without a feedback hub link, we won't be able to positively identify it as a dupe.

@zadjii-msft commented on GitHub (Sep 24, 2019): Woah lets not get into a ~~holy war~~discussion about whether or not json was the right choice for our settings file. The "comments in json" thing is _almost certainly_ a red herring here. [Jsoncpp](https://github.com/open-source-parsers/jsoncpp), which we're using for our json parsing, has _plenty_ of support for comments in json ("jsonc"). This is not the case of "Microsoft extending a standard", this is a case of Microsoft leveraging an existing open-source project and standard. We have a bunch of other issues open that are all akin to "when I close a tab, the Terminal crashes". The root of them is generally #2375. It's much more likely that's at fault here, but without a feedback hub link, we won't be able to positively identify it as a dupe.
claunia commented 2026-01-30 23:35:09 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 28, 2019):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Sep 28, 2019): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Author-Feedback Needs-Triage No-Recent-Activity
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#3993
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?