starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Investigate apparent WinPTY issue with RS5/19H1 builds #400

New Issue
Closed
opened 2026-01-30 21:50:55 +00:00 by claunia · 19 comments
claunia commented 2026-01-30 21:50:55 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (Oct 4, 2018).

Originally assigned to: @zadjii-msft on GitHub.

See https://github.com/Microsoft/vscode/issues/57803

Originally created by @miniksa on GitHub (Oct 4, 2018). Originally assigned to: @zadjii-msft on GitHub. See https://github.com/Microsoft/vscode/issues/57803
claunia added the Product-ConhostResolution-Fix-AvailableWork-Item labels 2026-01-30 21:50:56 +00:00
claunia commented 2026-01-30 21:50:57 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Oct 4, 2018):

Tracked internally assigned to me as MSFT:19205200

@miniksa commented on GitHub (Oct 4, 2018): Tracked internally assigned to me as MSFT:19205200
claunia commented 2026-01-30 21:50:57 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Oct 5, 2018):

Good news! I found the commit ID that changed the behavior. Yay bisect! Still digging.

@miniksa commented on GitHub (Oct 5, 2018): Good news! I found the commit ID that changed the behavior. Yay bisect! Still digging.
claunia commented 2026-01-30 21:50:57 +00:00
Author
Owner
Copy Link

@Tyriar commented on GitHub (Oct 11, 2018):

@miniksa did you end up finding a fix?

@Tyriar commented on GitHub (Oct 11, 2018): @miniksa did you end up finding a fix?
claunia commented 2026-01-30 21:50:58 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Oct 11, 2018):

I found it was @zadjii-msft's fault and I passed the buck to him. >__>

But he has a fix in PR right now. It's on my queue to read this morning.

@miniksa commented on GitHub (Oct 11, 2018): I found it was @zadjii-msft's fault and I passed the buck to him. >__> But he has a fix in PR right now. It's on my queue to read this morning.
claunia commented 2026-01-30 21:50:58 +00:00
Author
Owner
Copy Link

@warpdesign commented on GitHub (Oct 25, 2018):

Will the fix make it to October 2018 update or do we have to wait for the next big update in 6 months or so?

@warpdesign commented on GitHub (Oct 25, 2018): Will the fix make it to October 2018 update or do we have to wait for the next big update in 6 months or so?
claunia commented 2026-01-30 21:50:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 25, 2018):

@warpdesign The fix won't be in the October 2018 release. It'll be in Insiders builds pretty soon, but if you're afraid of Insiders, then you'll need to wait for the spring release.

@zadjii-msft commented on GitHub (Oct 25, 2018): @warpdesign The fix won't be in the October 2018 release. It'll be in Insiders builds pretty soon, but if you're afraid of Insiders, then you'll need to wait for the spring release.
claunia commented 2026-01-30 21:50:58 +00:00
Author
Owner
Copy Link

@warpdesign commented on GitHub (Oct 26, 2018):

@zadjii-msft ok, thanks for the info. I'm not afraid if insiders but my Surface Book already had lots of problems with the stable releases, don't want to put it to stress :)

I hope the @code team will find a workaround before the fix is released as stable then (see https://github.com/Microsoft/vscode/issues/57803).

@warpdesign commented on GitHub (Oct 26, 2018): @zadjii-msft ok, thanks for the info. I'm not afraid if insiders but my Surface Book already had lots of problems with the stable releases, don't want to put it to stress :) I hope the @code team will find a workaround before the fix is released as stable then (see https://github.com/Microsoft/vscode/issues/57803).
claunia commented 2026-01-30 21:50:59 +00:00
Author
Owner
Copy Link

@Tyriar commented on GitHub (Oct 26, 2018):

@warpdesign well the workaround is to upgrade to conpty which is blocked on Electron 3 which we're aiming for January currently https://github.com/Microsoft/vscode/issues/52629

@Tyriar commented on GitHub (Oct 26, 2018): @warpdesign well the workaround is to upgrade to conpty which is blocked on Electron 3 which we're aiming for January currently https://github.com/Microsoft/vscode/issues/52629
claunia commented 2026-01-30 21:50:59 +00:00
Author
Owner
Copy Link

@Stanzilla commented on GitHub (Oct 27, 2018):

@zadjii-msft what are the chances of shipping important fixes like this in a cumulative update?

@Stanzilla commented on GitHub (Oct 27, 2018): @zadjii-msft what are the chances of shipping important fixes like this in a cumulative update?
claunia commented 2026-01-30 21:50:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 30, 2018):

@Stanzilla Effectively none. There's very little chance that we ship any console bugfixes downlevel.

@zadjii-msft commented on GitHub (Oct 30, 2018): @Stanzilla Effectively none. There's very little chance that we ship any console bugfixes downlevel.
claunia commented 2026-01-30 21:50:59 +00:00
Author
Owner
Copy Link

@doxxx commented on GitHub (Dec 17, 2018):

Effectively none. There's very little chance that we ship any console bugfixes downlevel.

This really needs to change.

@doxxx commented on GitHub (Dec 17, 2018): > Effectively none. There's very little chance that we ship any console bugfixes downlevel. This really needs to change.
claunia commented 2026-01-30 21:51:00 +00:00
Author
Owner
Copy Link

@syntag commented on GitHub (Dec 21, 2018):

It's still an issue for me. @zadjii-msft mentioned that it will be available to us 3-4 weeks from Oct 15, but it's been long past due https://github.com/Microsoft/vscode/issues/57803#issuecomment-429948320

@syntag commented on GitHub (Dec 21, 2018): It's still an issue for me. @zadjii-msft mentioned that it will be available to us 3-4 weeks from Oct 15, but it's been long past due https://github.com/Microsoft/vscode/issues/57803#issuecomment-429948320
claunia commented 2026-01-30 21:51:00 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Dec 21, 2018):

The fix for MSFT: 19205200 reached Windows mainline on October 26, 2018. It should be in Insiders builds that were created on or after that date.

@miniksa commented on GitHub (Dec 21, 2018): The fix for MSFT: 19205200 reached Windows mainline on October 26, 2018. It should be in Insiders builds that were created on or after that date.
claunia commented 2026-01-30 21:51:00 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 21, 2018):

... on or after that date

One such build is 18282. Can you clarify whether you're still seeing this on RS5 builds or on 19H1 builds?

@DHowett-MSFT commented on GitHub (Dec 21, 2018): > ... on or after that date One such build is 18282. Can you clarify whether you're still seeing this on _RS5 builds_ or on _19H1 builds_?
claunia commented 2026-01-30 21:51:01 +00:00
Author
Owner
Copy Link

@Stanzilla commented on GitHub (Dec 21, 2018):

Please reconsider your downlevel merge policy, you can't expect people to use Insider builds on production machines and this is a super annoying issue.

@Stanzilla commented on GitHub (Dec 21, 2018): Please reconsider your downlevel merge policy, you can't expect people to use Insider builds on production machines and this is a super annoying issue.
claunia commented 2026-01-30 21:51:01 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 21, 2018):

We’d love to! It’s more of a Windows policy than a Console team policy, however, so we’ll keep making noise to the appropriate people.
Thanks!

@DHowett commented on GitHub (Dec 21, 2018): We’d love to! It’s more of a Windows policy than a Console team policy, however, so we’ll keep making noise to the appropriate people. Thanks!
claunia commented 2026-01-30 21:51:02 +00:00
Author
Owner
Copy Link

@ericblade commented on GitHub (Dec 22, 2018):

Can anyone confirm that this is fixed in WinPTY, in Insiders? Code team has closed their entry on it because they are moving to the new API, but that isn't going to change the other 40 years worth of software that is no longer doing the right thing visually. :-)

I realize that no one is going to want to throw out a visual fix to the release tree on a bug fix, but i'd at least like to know if it'll be fixed for the next windows update (March?)

@ericblade commented on GitHub (Dec 22, 2018): Can anyone confirm that this is fixed in WinPTY, in Insiders? Code team has closed their entry on it because they are moving to the new API, but that isn't going to change the other 40 years worth of software that is no longer doing the right thing visually. :-) I realize that no one is going to want to throw out a visual fix to the release tree on a bug fix, but i'd at least like to know if it'll be fixed for the next windows update (March?)
claunia commented 2026-01-30 21:51:02 +00:00
Author
Owner
Copy Link

@Tyriar commented on GitHub (Dec 22, 2018):

It's still an issue for me. @Tyriar mentioned that it will be available to us 3-4 weeks from Oct 15

@SYNTAG pretty sure I didn't do that.

@Tyriar commented on GitHub (Dec 22, 2018): > It's still an issue for me. @Tyriar mentioned that it will be available to us 3-4 weeks from Oct 15 @SYNTAG pretty sure I didn't do that.
claunia commented 2026-01-30 21:51:02 +00:00
Author
Owner
Copy Link

@syntag commented on GitHub (Dec 22, 2018):

It's still an issue for me. @Tyriar mentioned that it will be available to us 3-4 weeks from Oct 15

@SYNTAG pretty sure I didn't do that.

Whoops, my honest mistake. Meant to quote the user above. Edited my comment.

@syntag commented on GitHub (Dec 22, 2018): > > It's still an issue for me. @Tyriar mentioned that it will be available to us 3-4 weeks from Oct 15 > > @SYNTAG pretty sure I didn't do that. Whoops, my honest mistake. Meant to quote the user above. Edited my comment.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Product-Conhost Resolution-Fix-Available Work-Item
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#400
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?