The globals object should be layered on the root settings object #4065

Closed
opened 2026-01-30 23:37:12 +00:00 by claunia · 1 comment
Owner

Originally created by @zadjii-msft on GitHub (Sep 25, 2019).

Originally assigned to: @zadjii-msft on GitHub.

We added the ability for the root to be used as the globals object in #2515. However, if you have a globals object, then the settings in the root will get ignored. That's bad. We should layer them.

Originally created by @zadjii-msft on GitHub (Sep 25, 2019). Originally assigned to: @zadjii-msft on GitHub. We added the ability for the root to be used as the globals object in #2515. However, if you have a globals object, then the settings in the root will get ignored. That's bad. We should layer them.
Author
Owner

@zadjii-msft commented on GitHub (Sep 25, 2019):

(yanking triage since @DHowett-MSFT and I just discussed this)

@zadjii-msft commented on GitHub (Sep 25, 2019): (yanking triage since @DHowett-MSFT and I just discussed this)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4065