starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

RS5 horrible performance regression in ScrollConsoleScreenBuffer API. #409

New Issue
Open
opened 2026-01-30 21:51:12 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 21:51:12 +00:00
Owner
Copy Link

Originally created by @awson on GitHub (Oct 11, 2018).

Originally assigned to: @miniksa on GitHub.

  • Windows build number: 10.0.17763.1

The description below refers to x64 versions of OS and application.

Repro:
Install Far Manager and set "Height" in "Screen Buffer Size" to 9999 for it. Then try to run anything, e.g. dir in it's command line. There will be almost a second pause before and after dir runs.

The cuplrit is this call of ScrollConsoleScreenBuffer function.

In my particular case the ScrollRectangle is set to {0,0,170,9938}, ClipRectangle is null ptr and DestinationOrigin is set to {0,-1}. This single call lasts almost a second.

Legacy mode does not have this problem.

Also my impression is that this API was already rather slow even before RS5, but not so much horribly slow.

Originally created by @awson on GitHub (Oct 11, 2018). Originally assigned to: @miniksa on GitHub. * Windows build number: 10.0.17763.1 The description below refers to x64 versions of OS and application. Repro: Install [Far Manager ](https://farmanager.com/download.php?l=en) and set "Height" in "Screen Buffer Size" to 9999 for it. Then try to run anything, e.g. `dir` in it's command line. There will be almost a second pause before and after `dir` runs. The cuplrit is [this call](https://github.com/FarGroup/FarManager/blob/8fb8e1f0caa83433c6f731ae9a3082a38d8e9b12/far/console.cpp#L850) of `ScrollConsoleScreenBuffer` function. In my particular case the `ScrollRectangle` is set to `{0,0,170,9938}`, `ClipRectangle` is null ptr and `DestinationOrigin` is set to `{0,-1}`. This single call lasts almost a second. **Legacy mode does not have this problem.** Also my impression is that this API was already rather slow even before RS5, but not so much **horribly** slow.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Performance Product-Conhost Resolution-Fix-Available Work-Item
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#409
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?