starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

dark theme scrollbars #411

New Issue
Closed
opened 2026-01-30 21:51:14 +00:00 by claunia · 13 comments
claunia commented 2026-01-30 21:51:14 +00:00
Owner
Copy Link

Originally created by @musm on GitHub (Oct 10, 2018).

Originally assigned to: @miniksa on GitHub.

can we add the option that if you are using the dark theme in windows that the scrollbars in the prompt
image

match the dark scrollbars in e.g. explorer

image

Originally created by @musm on GitHub (Oct 10, 2018). Originally assigned to: @miniksa on GitHub. can we add the option that if you are using the dark theme in windows that the scrollbars in the prompt ![image](https://user-images.githubusercontent.com/4319522/46749913-c523b080-cc84-11e8-923e-e891358096ed.png) match the dark scrollbars in e.g. explorer ![image](https://user-images.githubusercontent.com/4319522/46749950-e389ac00-cc84-11e8-9886-172fd3198a45.png)
claunia added the Issue-FeatureProduct-ConhostResolution-Fix-AvailableWork-Item labels 2026-01-30 21:51:14 +00:00
claunia commented 2026-01-30 21:51:16 +00:00
Author
Owner
Copy Link

@ysc3839 commented on GitHub (Oct 11, 2018):

Try:

SetWindowTheme(GetConsoleWindow(), L"DarkMode_Explorer", nullptr);

In your console application.

Correct way is using internal API AllowDarkModeForWindow.
I think console team have known such feature, they just too busy to support it. So just wait.

@ysc3839 commented on GitHub (Oct 11, 2018): Try: ``` SetWindowTheme(GetConsoleWindow(), L"DarkMode_Explorer", nullptr); ``` In your console application. Correct way is using internal API `AllowDarkModeForWindow`. I think console team have known such feature, they just too busy to support it. So just wait.
claunia commented 2026-01-30 21:51:16 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Oct 11, 2018):

Made a change today to try this out for Insiders builds.

@miniksa commented on GitHub (Oct 11, 2018): Made a change today to try this out for Insiders builds.
claunia commented 2026-01-30 21:51:16 +00:00
Author
Owner
Copy Link

@musm commented on GitHub (Oct 11, 2018):

@miniksa awesome, which build number? I'm on the slow ring fyi.

@musm commented on GitHub (Oct 11, 2018): @miniksa awesome, which build number? I'm on the slow ring fyi.
claunia commented 2026-01-30 21:51:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 11, 2018):

@musm It'll be out in a few weeks. It usually takes just about 3 weeks for checkins we make to get up to master, and usually a week after that for the Insider's build to get spun with the change.

So, soontm

@zadjii-msft commented on GitHub (Oct 11, 2018): @musm It'll be out in a few weeks. It usually takes just about 3 weeks for checkins we make to get up to master, and usually a week after that for the Insider's build to get spun with the change. So, soon<sup>tm</sup>
claunia commented 2026-01-30 21:51:16 +00:00
Author
Owner
Copy Link

@oising commented on GitHub (Oct 11, 2018):

Hmm, I tried what @ysc3839 said in powershell (on 1809, of course) and it had no effect on the scrollbars:

PS> add-type -Name NativeMethods -Namespace Temp -MemberDefinition @"
[DllImport("uxtheme.dll", SetLastError=true, ExactSpelling=true, CharSet=CharSet.Unicode)]
public static extern int SetWindowTheme(IntPtr hWnd, string pszSubAppName, string pszSubIdList);
[DllImport("kernel32.dll", SetLastError=true)]
public static extern IntPtr GetConsoleWindow();
"@
PS> [Temp.NativeMethods]::SetWindowTheme([Temp.NativeMethods]::GetConsoleWindow(),
               "DarkMode_Explorer", $null)
0
PS> # scrollbars still light theme

Suggestions on how to correct this, @zadjii-msft or @miniksa ?

@oising commented on GitHub (Oct 11, 2018): Hmm, I tried what @ysc3839 said in powershell (on 1809, of course) and it had no effect on the scrollbars: ```powershell PS> add-type -Name NativeMethods -Namespace Temp -MemberDefinition @" [DllImport("uxtheme.dll", SetLastError=true, ExactSpelling=true, CharSet=CharSet.Unicode)] public static extern int SetWindowTheme(IntPtr hWnd, string pszSubAppName, string pszSubIdList); [DllImport("kernel32.dll", SetLastError=true)] public static extern IntPtr GetConsoleWindow(); "@ PS> [Temp.NativeMethods]::SetWindowTheme([Temp.NativeMethods]::GetConsoleWindow(), "DarkMode_Explorer", $null) 0 PS> # scrollbars still light theme ``` Suggestions on how to correct this, @zadjii-msft or @miniksa ?
claunia commented 2026-01-30 21:51:17 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Oct 11, 2018):

I'm really not sure why it doesn't work from the outside. Could be that it doesn't like being done after ShowWindow has been called and the WM_SETTINGCHANGED handler isn't ready for it. Could be that SetWindowTheme generates a window message that UIPI is blocking from your Powershell binary. Could be something completely different. I'm sorry. I tried it inside the console code and it works, so I'm not intending to spend anytime debugging why it doesn't work from the outside.

@miniksa commented on GitHub (Oct 11, 2018): I'm really not sure why it doesn't work from the outside. Could be that it doesn't like being done after `ShowWindow` has been called and the `WM_SETTINGCHANGED` handler isn't ready for it. Could be that `SetWindowTheme` generates a window message that UIPI is blocking from your Powershell binary. Could be something completely different. I'm sorry. I tried it inside the console code and it works, so I'm not intending to spend anytime debugging why it doesn't work from the outside.
claunia commented 2026-01-30 21:51:17 +00:00
Author
Owner
Copy Link

@musm commented on GitHub (Oct 11, 2018):

(unrelated) @ysc3839 can you provide me with some simple minimal example with that in use? Trying to dive in so I can create PRs for some apps I use, but the win32 API world is a little dizzying for first timers.

@musm commented on GitHub (Oct 11, 2018): (unrelated) @ysc3839 can you provide me with some simple minimal example with that in use? Trying to dive in so I can create PRs for some apps I use, but the win32 API world is a little dizzying for first timers.
claunia commented 2026-01-30 21:51:17 +00:00
Author
Owner
Copy Link

@ysc3839 commented on GitHub (Oct 12, 2018):

@musm
It works on my GUI application. Currently I have not tested on console Windows.
Maybe SetWindowTheme for external process is not allowed.

https://github.com/ysc3839/VCMPBrowser/blob/darkmode/DarkMode.h
This code uses internal APIs and may not work on a newer Windows version.

PS: Hope Microsoft makes these APIs public for all Win32 apps.

@ysc3839 commented on GitHub (Oct 12, 2018): @musm It works on my GUI application. Currently I have not tested on console Windows. Maybe SetWindowTheme for external process is not allowed. https://github.com/ysc3839/VCMPBrowser/blob/darkmode/DarkMode.h This code uses internal APIs and may not work on a newer Windows version. PS: Hope Microsoft makes these APIs public for all Win32 apps.
claunia commented 2026-01-30 21:51:18 +00:00
Author
Owner
Copy Link

@be5invis commented on GitHub (Nov 3, 2018):

Does the dark mode cover settings dialog?

@be5invis commented on GitHub (Nov 3, 2018): Does the dark mode cover settings dialog?
claunia commented 2026-01-30 21:51:18 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jan 18, 2019):

MSFT: 19271078 reached Insiders for 18272+.

The follow on fix for a mistake (MSFT: 19548142) reached Insiders for 18309+.

@miniksa commented on GitHub (Jan 18, 2019): MSFT: 19271078 reached Insiders for 18272+. The follow on fix for a mistake (MSFT: 19548142) reached Insiders for 18309+.
claunia commented 2026-01-30 21:51:18 +00:00
Author
Owner
Copy Link

@ysc3839 commented on GitHub (Feb 16, 2019):

@miniksa I reverse engineered and found you use GetProcAddress with a magic number. Why not static link to that function?
I'm afraid that the console will broken when the ordinal of that function changed.

image

@ysc3839 commented on GitHub (Feb 16, 2019): @miniksa I reverse engineered and found you use GetProcAddress with a magic number. Why not static link to that function? I'm afraid that the console will broken when the ordinal of that function changed. ![image](https://user-images.githubusercontent.com/12028138/52904788-c5077300-326b-11e9-9fd9-aa9211683a83.png)
claunia commented 2026-01-30 21:51:19 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 16, 2019):

@ysc3839 There's a couple reasons for that:

  1. The function may not be exported by name.
  2. We can't statically link it, as the library that provides it is a dynamic library.
  3. We all use the console internally every day, and are very likely to be the first to know if this ordinal changes, probably through a change in its observable behavior. Since we're developing on builds of windows that are very close to mainline, we'll almost certainly figure out changes like this before any breakage makes it out to Insiders.
    1. (additionally, any given ordinal is not at risk of changing during the lifetime of a single version of Windows)
@DHowett-MSFT commented on GitHub (Feb 16, 2019): @ysc3839 There's a couple reasons for that: 1. The function may not be exported by name. 2. We can't statically link it, as the library that provides it is a dynamic library. 3. We all use the console internally every day, and are very likely to be the first to know if this ordinal changes, probably through a change in its observable behavior. Since we're developing on builds of windows that are _very close_ to mainline, we'll almost certainly figure out changes like this before any breakage makes it out to Insiders. 1. (additionally, any given ordinal is not at risk of changing during the lifetime of a single version of Windows)
claunia commented 2026-01-30 21:51:19 +00:00
Author
Owner
Copy Link

@ysc3839 commented on GitHub (Feb 16, 2019):

@DHowett-MSFT
Sorry, the "static link" means link to that DLL using import address table.
Some other DLL (explorerframe.dll) link to that function using IAT. It's better than using GetProcAddress.

@ysc3839 commented on GitHub (Feb 16, 2019): @DHowett-MSFT Sorry, the "static link" means link to that DLL using import address table. Some other DLL (explorerframe.dll) link to that function using IAT. It's better than using GetProcAddress.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Product-Conhost Resolution-Fix-Available Work-Item
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?