starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Bug when closing "micro" editor #4190

New Issue
Closed
opened 2026-01-30 23:40:31 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 23:40:31 +00:00
Owner
Copy Link

Originally created by @jeffrson on GitHub (Oct 1, 2019).

Environment

Windows build number: 10.0.18362.295
Windows Terminal version (if applicable): 0.5.2681.0

Any other software? Micro (https://micro-editor.github.io/)

Steps to reproduce

Run "micro test", press Ctrl-Q to close

Expected behavior

Terminal should show prompt and be ready for next command.

Actual behavior

Window is empty, first input key is ignored - say, I type "ver" - prompt appears after 'v', which is swallowed, leaving "er" in command.

Originally created by @jeffrson on GitHub (Oct 1, 2019). # Environment ```none Windows build number: 10.0.18362.295 Windows Terminal version (if applicable): 0.5.2681.0 Any other software? Micro (https://micro-editor.github.io/) ``` # Steps to reproduce Run "micro test", press Ctrl-Q to close # Expected behavior Terminal should show prompt and be ready for next command. # Actual behavior Window is empty, first input key is ignored - say, I type "ver" - prompt appears after 'v', which is swallowed, leaving "er" in command.
claunia commented 2026-01-30 23:40:32 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 1, 2019):

@jeffrson Does this repro in conhost.exe (launch cmd.exe, powershell.exe, wsl.exe directly), or only in Windows Terminal?

@zadjii-msft commented on GitHub (Oct 1, 2019): @jeffrson Does this repro in `conhost.exe` (launch `cmd.exe`, `powershell.exe`, `wsl.exe` directly), or only in Windows Terminal?
claunia commented 2026-01-30 23:40:32 +00:00
Author
Owner
Copy Link

@jeffrson commented on GitHub (Oct 1, 2019):

It only happens in Windows Terminal.

@jeffrson commented on GitHub (Oct 1, 2019): It only happens in Windows Terminal.
claunia commented 2026-01-30 23:40:33 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 29, 2019):

Yeah: it looks like micro waits for a keypress before exiting, but only in Terminal?

@DHowett-MSFT commented on GitHub (Oct 29, 2019): Yeah: it looks like micro waits for a keypress before exiting, but only in Terminal?
claunia commented 2026-01-30 23:40:33 +00:00
Author
Owner
Copy Link

@jeffrson commented on GitHub (Oct 29, 2019):

Yes - "pure" PowerShell and cmd show prompt after exiting with Ctrl-Q

@jeffrson commented on GitHub (Oct 29, 2019): Yes - "pure" PowerShell and cmd show prompt after exiting with Ctrl-Q
claunia commented 2026-01-30 23:40:33 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 30, 2019):

So, this is a fun one!

At the end of the day, micro is doing something strange. They are trying to read from the console one last time before quitting. When they read from the console, they get a bunch of individual keypress events in four different Read operations.

Here's what they do when they read from the console outside of Windows Terminal:

READ 1
 KEY_EVENT [Ctrl, Down]

READ 2
 KEY_EVENT [Q, Down]

Micro begins exiting because Ctrl+Q was pressed.
tcell (the terminal library they use) begins shutting down.
It waits for one more console event.

READ 3
 KEY_EVENT [Q, Up]

tcell finishes its final read.
Micro exits.
PowerShell or CMD takes over, and reads the console.

READ 4
 KEY_EVENT [Ctrl, Up]

PowerShell/CMD ignore the stray Ctrl key release, because they don't care.

Now, when they read and are attached to a terminal using ConPTY they get everything in a single read. Here's what that looks like.

READ 1
 KEY_EVENT [Ctrl, Down]
 KEY_EVENT [Q, Down]
 KEY_EVENT [Q, Up]
 KEY_EVENT [Ctrl, Up]

Micro begins exiting because Ctrl+Q were pressed.
tcell (the terminal library they use) begins shutting down.
It waits for one more console event.

Since the console was too "fast" for tcell/micro, it never got the last console event it was waiting for. It exits when the next one comes in.

This seems to be a design flaw in tcell... so I'm going to have to close it here.

@DHowett-MSFT commented on GitHub (Oct 30, 2019): So, this is a fun one! At the end of the day, micro is doing something strange. They are trying to read from the console one last time before quitting. When they read from the console, they get a bunch of individual keypress events in four different Read operations. Here's what they do when they read from the console outside of Windows Terminal: ``` READ 1 KEY_EVENT [Ctrl, Down] READ 2 KEY_EVENT [Q, Down] Micro begins exiting because Ctrl+Q was pressed. tcell (the terminal library they use) begins shutting down. It waits for one more console event. READ 3 KEY_EVENT [Q, Up] tcell finishes its final read. Micro exits. PowerShell or CMD takes over, and reads the console. READ 4 KEY_EVENT [Ctrl, Up] PowerShell/CMD ignore the stray Ctrl key release, because they don't care. ``` Now, when they read and are attached to a terminal using ConPTY they get everything in a single read. Here's what that looks like. ``` READ 1 KEY_EVENT [Ctrl, Down] KEY_EVENT [Q, Down] KEY_EVENT [Q, Up] KEY_EVENT [Ctrl, Up] Micro begins exiting because Ctrl+Q were pressed. tcell (the terminal library they use) begins shutting down. It waits for one more console event. ``` Since the console was too "fast" for tcell/micro, it never got the last console event it was waiting for. It exits when the _next_ one comes in. This seems to be a design flaw in tcell... so I'm going to have to close it here.
claunia commented 2026-01-30 23:40:34 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 30, 2019):

This will reproduce in VSCode, Alacritty (with experimental backend), and putty-wincon as well.

@DHowett-MSFT commented on GitHub (Oct 30, 2019): This will reproduce in VSCode, Alacritty (with experimental backend), and putty-wincon as well.
claunia commented 2026-01-30 23:40:34 +00:00
Author
Owner
Copy Link

@jeffrson commented on GitHub (Oct 30, 2019):

Really great analysis!

Bringing the attention to tcell reveals this issue: https://github.com/gdamore/tcell/issues/194 (linking it here).

@jeffrson commented on GitHub (Oct 30, 2019): Really great analysis! Bringing the attention to tcell reveals this issue: https://github.com/gdamore/tcell/issues/194 (linking it here).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Help Wanted Issue-Bug Product-Terminal Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?