starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Vertical joining of box drawing characters has gaps #4215

New Issue
Closed
opened 2026-01-30 23:41:11 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 23:41:11 +00:00
Owner
Copy Link

Originally created by @tryptamic on GitHub (Oct 2, 2019).

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.356]
Windows Terminal version (if applicable): 0.5.2681.0

Steps to reproduce

Run this litle command in the terminal using a cmd.exe tab to produce a little box:

echo ┌┐ & echo └┘

Expected behavior

The box should have perfectly joined lines on all sides. Living in a monospaced environment where the box drawing characters are used to draw trees, boxes and other stuf perfect line joining is expected

Actual behavior

The lines of the box are not vertically joined

image

Originally created by @tryptamic on GitHub (Oct 2, 2019). # Environment Windows build number: Microsoft Windows [Version 10.0.18362.356] Windows Terminal version (if applicable): 0.5.2681.0 # Steps to reproduce Run this litle command in the terminal using a cmd.exe tab to produce a little box: ```cmd echo ┌┐ & echo └┘ ``` # Expected behavior The box should have perfectly joined lines on all sides. Living in a monospaced environment where the box drawing characters are used to draw trees, boxes and other stuf perfect line joining is expected # Actual behavior The lines of the box are not vertically joined ![image](https://user-images.githubusercontent.com/8502209/66046865-eaa96a00-e526-11e9-9bd9-90396b006770.png)
claunia added the Area-RenderingResolution-DuplicateArea-Fonts labels 2026-01-30 23:41:11 +00:00
claunia commented 2026-01-30 23:41:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 2, 2019):

@tryptamic What font are you using?

What does this look like in conhost (launch cmd.exe directly) with the same font selected?

@zadjii-msft commented on GitHub (Oct 2, 2019): @tryptamic What font are you using? What does this look like in conhost (launch cmd.exe directly) with the same font selected?
claunia commented 2026-01-30 23:41:12 +00:00
Author
Owner
Copy Link

@egmontkob commented on GitHub (Oct 2, 2019):

Some terminals, including VTE and Konsole draw the U+2500..257F (or even up to 259F) glyphs manually, rather than taking them from the font. This prevents such problems (and also avoids ugly looking antialiasing). I haven't seen any monospace font that would just look perfect on its own.

Interestingly, independently from each other, both VTE and Konsole came up with the idea of defining the look of most of these codepoints as a 5x5 matrix (where how the given 5x5 grid is stretched to the character cell is not necessarily the same for thick lines vs. double lines).

VTE link1, link2

Update: Konsole recently changed not to use a 5x5 matrix but other means of drawing.

@egmontkob commented on GitHub (Oct 2, 2019): Some terminals, including VTE and Konsole draw the U+2500..257F (or even up to 259F) glyphs manually, rather than taking them from the font. This prevents such problems (and also avoids ugly looking antialiasing). I haven't seen any monospace font that would just look perfect on its own. Interestingly, independently from each other, both VTE and Konsole came up with the idea of defining the look of most of these codepoints as a 5x5 matrix (where how the given 5x5 grid is stretched to the character cell is not necessarily the same for thick lines vs. double lines). VTE [link1](https://gitlab.gnome.org/GNOME/vte/blob/0.58.0/src/box_drawing.txt), [link2](https://gitlab.gnome.org/GNOME/vte/blob/443cfe95a308247c8661b1bea22c1139520faddf/src/vtedraw.cc#L1180) Update: Konsole recently [changed](https://invent.kde.org/kde/konsole/commit/13132fc77bf90d0a39c62676f3ac75caa581962f) not to use a 5x5 matrix but other means of drawing.
claunia commented 2026-01-30 23:41:13 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 2, 2019):

I like the idea of having Terminal draw these itself; we've chatted about that internally and thought it was pretty clever.

This is also related to #455.

@DHowett-MSFT commented on GitHub (Oct 2, 2019): I like the idea of having Terminal draw these itself; we've chatted about that internally and thought it was pretty clever. This is also related to #455.
claunia commented 2026-01-30 23:41:13 +00:00
Author
Owner
Copy Link

@tryptamic commented on GitHub (Oct 2, 2019):

@tryptamic What font are you using?

What does this look like in conhost (launch cmd.exe directly) with the same font selected?

Consolas and here how it looks in in conhost:

image

In terminal with Cascadia Code it gets even worse because horizontal joining is then broken as well and vertical gaps got even larger as you can see in the screenshot

image

Why does it work in the old console without drawing it in a special way. Isn't it a simple issue of the wrong line height and in case of cascadia wrong glyphs?

@tryptamic commented on GitHub (Oct 2, 2019): > @tryptamic What font are you using? > > What does this look like in conhost (launch cmd.exe directly) with the same font selected? Consolas and here how it looks in in conhost: ![image](https://user-images.githubusercontent.com/8502209/66064324-74683000-e545-11e9-8e76-1c3ec0490133.png) In terminal with Cascadia Code it gets even worse because horizontal joining is then broken as well and vertical gaps got even larger as you can see in the screenshot ![image](https://user-images.githubusercontent.com/8502209/66063946-b8a70080-e544-11e9-924a-9deb4fc361f6.png) Why does it work in the old console without drawing it in a special way. Isn't it a simple issue of the wrong line height and in case of cascadia wrong glyphs?
claunia commented 2026-01-30 23:41:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 2, 2019):

@tryptamic The legacy console and the Terminal use different renderers to display text. The Terminal's renderer is far more performant, but there are still many edge cases we need to work out, and this is one of them.

I think in general this falls under the umbrella of /dup #455 so I'm gonna close as a dupe.

@zadjii-msft commented on GitHub (Oct 2, 2019): @tryptamic The legacy console and the Terminal use different renderers to display text. The Terminal's renderer is far more performant, but there are still many edge cases we need to work out, and this is one of them. I think in general this falls under the umbrella of /dup #455 so I'm gonna close as a dupe.
claunia commented 2026-01-30 23:41:13 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 2, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Oct 2, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Fonts Area-Rendering Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4215
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?