starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add a setting to manually set the Pane highlight color #4259

New Issue
Open
opened 2026-01-30 23:42:21 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 23:42:21 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Oct 4, 2019).

Follow up from #994 and PR:#3060

In the aforementioned PR, we're just using the accent color for highlighting the pane. We should let that be a customizable global setting.

Questions:

  • There's been discussion before about allowing custom theming, hypothetically powered by XAML. Would we want to wait for that discussion to be had before we do this?
    • We'd probably want to change it from using SystemAccentColor to some FocusedPaneBorder color resource, that we define by default to be SystemAccentColor, should we decide to pursue this option
    • If we do want to do this in XAML later, would enabling it in the json now negatively impact that future scenario?
Originally created by @zadjii-msft on GitHub (Oct 4, 2019). Follow up from #994 and PR:#3060 In the aforementioned PR, we're just using the accent color for highlighting the pane. We should let that be a customizable global setting. Questions: * There's been discussion before about allowing custom theming, hypothetically powered by XAML. Would we want to wait for that discussion to be had before we do this? - We'd probably want to change it from using `SystemAccentColor` to some `FocusedPaneBorder` color resource, that we define by default to be `SystemAccentColor`, should we decide to pursue this option - If we do want to do this in XAML later, would enabling it in the json _now_ negatively impact that future scenario?
claunia added the Area-SettingsIssue-TaskIn-PRProduct-TerminalArea-Theming labels 2026-01-30 23:42:21 +00:00
claunia commented 2026-01-30 23:42:22 +00:00
Author
Owner
Copy Link

@javierdlg commented on GitHub (Oct 29, 2019):

We're actually very interested in this since we have found a few contrast ratio issues with our colors and the terminal. We've also received some feedback since the terminal is the only tool that has different highlighting colors in VS:
image

Any ideas on the cost for this feature request?

@javierdlg commented on GitHub (Oct 29, 2019): We're actually very interested in this since we have found a few contrast ratio issues with our colors and the terminal. We've also received some feedback since the terminal is the only tool that has different highlighting colors in VS: ![image](https://user-images.githubusercontent.com/2334756/67793279-c1053500-fa37-11e9-84ab-0fb0a10ccf11.png) Any ideas on the cost for this feature request?
claunia commented 2026-01-30 23:42:22 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 29, 2019):

@javierdlg I think you're probably looking for #3326 - this issue is about the color used to indicate that a pane is focused (which is currently in PR in #3060). I'll respond to the ask in that thread :)

@zadjii-msft commented on GitHub (Oct 29, 2019): @javierdlg I think you're probably looking for #3326 - this issue is about the color used to indicate that a pane is focused (which is currently in PR in #3060). I'll respond to the ask in that thread :)
claunia commented 2026-01-30 23:42:22 +00:00
Author
Owner
Copy Link

@SkyTrix commented on GitHub (Jul 20, 2020):

Not sure if this should be a separate issue, but in addition to this, it would be nice to be able to completely hide the focused pane border when the Terminal isn't the active application. I often have a few panes open on a separate screen where the focused pane border becomes more of a distraction than a help when the Terminal isn't the active window and I'm just glancing over at the outputs of the different panes.

@SkyTrix commented on GitHub (Jul 20, 2020): Not sure if this should be a separate issue, but in addition to this, it would be nice to be able to completely hide the focused pane border when the Terminal isn't the active application. I often have a few panes open on a separate screen where the focused pane border becomes more of a distraction than a help when the Terminal isn't the active window and I'm just glancing over at the outputs of the different panes.
claunia commented 2026-01-30 23:42:22 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 6, 2023):

Note

Walkthrough

  • Start by adding a new Theme object for Panes:
    • PaneTheme in Theme.idl, quite similar to TabRowTheme in the same file
    • Add a single ThemeColor ActiveBorderColor to that runtimeclass.
    • In MTSMSettings.h, define a new MTSM_THEME_PANE_SETTINGS, again taking cues from the tab row version. The key for this one should just be "pane"
    • Add a THEME_OBJECT(PaneTheme, MTSM_THEME_PANE_SETTINGS); to Theme.h
    • Add the pane theme to the other places theme objects appear in Theme.cpp as well.
  • The "hard" part: actually plumb that color through to the panes
    • Pane currently uses a static `Brush for the border colors. It probably shouldn't.
    • TerminalPage::_updateThemeColors is what updates theme colors to the tabs, the window, etc. Similarly, it should plumb that through to all the panes.
      • WalkTree is a really handy helper for doing something to every pane.
    • Make sure that a null or otherwise omitted pane.activeBorderColor still uses accent by default
  • While you're here, probably add a similar pane.inactiveBorderColor, for controlling the appearance of the inactive pane border color.

Once this is done, if you wanted to get really ambitious, you could follow up with a similar property to configure the pane hover color, ala #8564.

@zadjii-msft commented on GitHub (Feb 6, 2023): > **Note** > ## Walkthrough * [ ] Start by adding a new Theme object for Panes: * [ ] `PaneTheme` in `Theme.idl`, quite similar to `TabRowTheme` in the same file * [ ] Add a single `ThemeColor ActiveBorderColor` to that `runtimeclass`. * [ ] In `MTSMSettings.h`, define a new `MTSM_THEME_PANE_SETTINGS`, again taking cues from the tab row version. The key for this one should just be `"pane"` * [ ] Add a `THEME_OBJECT(PaneTheme, MTSM_THEME_PANE_SETTINGS);` to `Theme.h` * [ ] Add the pane theme to the other places theme objects appear in Theme.cpp as well. * [ ] The "hard" part: actually plumb that color through to the panes * [ ] `Pane` currently uses a `static` `Brush for the border colors. It probably shouldn't. * [ ] `TerminalPage::_updateThemeColors` is what updates theme colors to the tabs, the window, etc. Similarly, it should plumb that through to all the panes. * [ ] `WalkTree` is a really handy helper for doing something to every pane. * [ ] Make sure that a `null` or otherwise omitted `pane.activeBorderColor` still uses `accent` by default * [ ] While you're here, probably add a similar `pane.inactiveBorderColor`, for controlling the appearance of the inactive pane border color. Once this is done, if you wanted to get really ambitious, you could follow up with a similar property to configure the pane hover color, ala #8564.
claunia commented 2026-01-30 23:42:23 +00:00
Author
Owner
Copy Link

@peter-lee20 commented on GitHub (Aug 26, 2024):

Hello, can I take a stab at this?

@peter-lee20 commented on GitHub (Aug 26, 2024): Hello, can I take a stab at this?
claunia commented 2026-01-30 23:42:23 +00:00
Author
Owner
Copy Link

@Haaziq386 commented on GitHub (Oct 27, 2024):

@zadjii-msft where is the Theme.idl file i.e in which folder ?

@Haaziq386 commented on GitHub (Oct 27, 2024): @zadjii-msft where is the `Theme.idl` file i.e in which folder ?
claunia commented 2026-01-30 23:42:23 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 28, 2024):

@Haaziq386 src/cascadia/TerminalSettingsModel/Theme.idl

@zadjii-msft commented on GitHub (Oct 28, 2024): @Haaziq386 [src/cascadia/TerminalSettingsModel/Theme.idl](https://github.com/microsoft/terminal/blob/8d3f12b1c065a965974cd6b5bc7a81176ffb0f1b/src/cascadia/TerminalSettingsModel/Theme.idl)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Area-Theming In-PR Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4259
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?