starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add a configuration object for focused vs unfocused state #4261

New Issue
Closed
opened 2026-01-30 23:42:23 +00:00 by claunia · 8 comments
claunia commented 2026-01-30 23:42:23 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Oct 4, 2019).

Follow up from #994.

Originally suggested by @cdmihai in #994

Hyper changes the text color. The focused pane uses a saturated, bright version of the font color, the out of focus panes use a desaturated, dark version of the font. I found that this makes it quite visually intuitive to instantly notice which pane is active. Yet the other panes are still quite readable.

Sounds like the holy grail would be to have a configuration object for pane switching features (text fonts, background colors, borders, cursor, etc) with some sensible accessible defaults.

Taking that idea and running with it, what if each profile could specify an "unfocused" state that's used when it loses focus?

    "profiles":
    [
        {
            "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
            "name": "cmd",
            "commandline": "cmd.exe",

            "colorScheme": "Solarized Dark",
            "cursorColor": "#FF00FF",
            "cursorShape": "bar",
            "fontFace": "Consolas",
            "fontSize": 12,
            "foreground": "#C0C0C0",
            "background": "#000000",

            "unfocusedState": 
            {
                "colorScheme": "Campbell",
                "cursorColor": "#888",
                "cursorShape": "emptyBox",
                "foreground": "#C0C0C0",
                "background": "#000000"
            }
        }
    ],

Presumably, backgroundImage settings would also be fine in that block.

Things I wouldn't want to enable in this block:

  • Anything that causes a resize. padding, fontFace, fontSize.
  • The acrylic settings. Acrylic doesn't work when the window isn't focused, and I wouldn't want people to think that it magically will if they add that setting. [1]
[1]: Technically, with split panes, they could have an unfocused control that could still have an acrylic BG, as long as the window remains focused.

I'm realizing now that this is strictly a superset of #2316, and will also resolve that one. I maybe could have just used that thread originally.

26 Mar 2020: #5130 brought up the good point that this should also include enabling the cursor to still be On, even when the control isn't focused

Originally created by @zadjii-msft on GitHub (Oct 4, 2019). Follow up from #994. Originally suggested by @cdmihai in #994 > > Hyper changes the text color. The focused pane uses a saturated, bright version of the font color, the out of focus panes use a desaturated, dark version of the font. I found that this makes it quite visually intuitive to instantly notice which pane is active. Yet the other panes are still quite readable. > > Sounds like the holy grail would be to have a configuration object for pane switching features (text fonts, background colors, borders, cursor, etc) with some sensible accessible defaults. Taking that idea and running with it, what if each profile could specify an "unfocused" state that's used when it loses focus? ```json "profiles": [ { "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "name": "cmd", "commandline": "cmd.exe", "colorScheme": "Solarized Dark", "cursorColor": "#FF00FF", "cursorShape": "bar", "fontFace": "Consolas", "fontSize": 12, "foreground": "#C0C0C0", "background": "#000000", "unfocusedState": { "colorScheme": "Campbell", "cursorColor": "#888", "cursorShape": "emptyBox", "foreground": "#C0C0C0", "background": "#000000" } } ], ``` Presumably, `backgroundImage` settings would also be fine in that block. Things I _wouldn't_ want to enable in this block: * Anything that causes a resize. `padding`, `fontFace`, `fontSize`. * The acrylic settings. Acrylic doesn't work when the window _isn't_ focused, and I wouldn't want people to think that it magically will if they add that setting. <sup>[1]</sup> ###### [1]: Technically, with split panes, they could have an unfocused control that could still have an acrylic BG, as long as the window remains focused. <hr> I'm realizing now that this is strictly a superset of #2316, and will also resolve that one. I maybe could have just used that thread originally. <hr> 26 Mar 2020: #5130 brought up the good point that this should also include enabling the cursor to still be On, even when the control isn't focused
claunia commented 2026-01-30 23:42:25 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 8, 2019):

Yanking Triage -- this is a neat feature, but it does require a little bit of thinkin' about.

@DHowett-MSFT commented on GitHub (Oct 8, 2019): Yanking Triage -- this is a neat feature, but it does require a little bit of thinkin' about.
claunia commented 2026-01-30 23:42:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 26, 2019):

@coupez There's actually a bunch of other threads that have covered that discussion, but this isn't one of them. This mostly tracks controlling the appearance of an active pane vs inactive panes, when there are many panes in the same tab. For discussion on how acrylic works, see: #2326, #1886, #1747, #1546, #1505, #1099, #593, #3336, #2763, #2698, #3497

@zadjii-msft commented on GitHub (Nov 26, 2019): @coupez There's actually a bunch of other threads that have covered that discussion, but this isn't one of them. This mostly tracks controlling the appearance of an active pane vs inactive panes, when there are many panes in the same tab. For discussion on how acrylic works, see: #2326, #1886, #1747, #1546, #1505, #1099, #593, #3336, #2763, #2698, #3497
claunia commented 2026-01-30 23:42:25 +00:00
Author
Owner
Copy Link

@solariz commented on GitHub (Feb 26, 2020):

Sure it's "just" a cosmetic thing, but isn't the new Term also about a cosmetic refresh? So for me it is totally annoying having it going totally black when not focused. Looks pretty bad und totally uneccessary.

@solariz commented on GitHub (Feb 26, 2020): Sure it's "just" a cosmetic thing, but isn't the new Term also about a cosmetic refresh? So for me it is totally annoying having it going totally black when not focused. Looks pretty bad und totally uneccessary.
claunia commented 2026-01-30 23:42:25 +00:00
Author
Owner
Copy Link

@anwar3606 commented on GitHub (Jun 6, 2020):

not even a hack for the Acrylic to be present when the focus is lost?

@anwar3606 commented on GitHub (Jun 6, 2020): not even a hack for the Acrylic to be present when the focus is lost?
claunia commented 2026-01-30 23:42:26 +00:00
Author
Owner
Copy Link

@reinux commented on GitHub (Dec 2, 2020):

The lack of Acrylic on background windows turns out to be a deliberate Windows 10 limitation.

Even back on Vista hardware, when there were a ton of false rumors about its resource consumption, Aero Glass being a culprit for battery consumption was ruled out by everyone who bothered to test the theory both in benchmarks and in practical use. It was reducing battery life by less than 1%.

So this decision on the Windows team's part strikes me as being really bizarre, even from a PR standpoint, as it validates those claims. It's been 13 years anyway; the only modern computer I can think of that wouldn't have a GPU that could handle glass in under 0.1% of its energy consumption is a Raspberry Pi.

Glass on bevels is useful, but glass as background for text-heavy applications in the foreground seems like the least appropriate use for it.

What a weird situation to be in.

@reinux commented on GitHub (Dec 2, 2020): The lack of Acrylic on background windows turns out to be [a deliberate Windows 10 limitation](https://docs.microsoft.com/en-us/windows/uwp/design/style/acrylic#usability-and-adaptability). Even back on Vista hardware, when there were a ton of false rumors about its resource consumption, Aero Glass being a culprit for battery consumption was ruled out by everyone who bothered to test the theory both in benchmarks and in practical use. It was reducing battery life by less than 1%. So this decision on the Windows team's part strikes me as being really bizarre, even from a PR standpoint, as it validates those claims. It's been 13 years anyway; the only modern computer I can think of that wouldn't have a GPU that could handle glass in under 0.1% of its energy consumption is a Raspberry Pi. Glass on bevels is useful, but glass as background for text-heavy applications in the foreground seems like the least appropriate use for it. What a weird situation to be in.
claunia commented 2026-01-30 23:42:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 2, 2020):

This isn't the thread to discuss whether acrylic should be enabled when the window is focused or not. There's like 11 threads I linked above that are better suited for that discussion. There's also #7158 which is tracking investigating if unfocused acrylic is possible in the Terminal. I'd ask that we re-direct this discussion to that thread, thanks.

@zadjii-msft commented on GitHub (Dec 2, 2020): This isn't the thread to discuss whether acrylic should be enabled when the window is focused or not. There's like 11 threads I linked above that are better suited for that discussion. There's also #7158 which is tracking investigating if unfocused acrylic is possible in the Terminal. I'd ask that we re-direct this discussion to that thread, thanks.
claunia commented 2026-01-30 23:42:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

:tada:This issue was addressed in #8392, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:This issue was addressed in #8392, which has now been successfully released as `Windows Terminal Preview v1.8.1032.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-30 23:42:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #8392, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #8392, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Area-TerminalControl Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4261
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?