starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Underline not rendered after some SGR 22/39/49 #4289

New Issue
Closed
opened 2026-01-30 23:43:04 +00:00 by claunia · 7 comments
claunia commented 2026-01-30 23:43:04 +00:00
Owner
Copy Link

Originally created by @egmontkob on GitHub (Oct 5, 2019).

Environment

Windows build number: Win32NT 10.0.18362.0
Windows Terminal version (if applicable): 0.5.2762.0

Steps to reproduce

echo -e '\e[4m underlined \e[33m yellow \e[39m should still be underlined \e[m'

Expected behavior

The entire line should be underlined.

Actual behavior

The "should still be underlined" bits aren't underlined.

Note that SGR codes 22, 27, 39 and 49 seem to cause this effect, but only if they're predeced by a 1, 7, 30-37 or 40-47, resp., that is, only if they do actually turn off some other attribute.

Also note that if the "should still be underlined" text is made longer so that it overflows to the next line (or even multiple new lines), it's underlined in the last one of these lines. This makes it perhaps a reincarnation of #47.

Furthermore, changing the window width and thus causing a reflow of the text removes the underlining from the last line.

Originally created by @egmontkob on GitHub (Oct 5, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Win32NT 10.0.18362.0 Windows Terminal version (if applicable): 0.5.2762.0 ``` # Steps to reproduce echo -e '\e[4m underlined \e[33m yellow \e[39m should still be underlined \e[m' # Expected behavior The entire line should be underlined. # Actual behavior The "should still be underlined" bits aren't underlined. Note that SGR codes `22`, `27`, `39` and `49` seem to cause this effect, but only if they're predeced by a `1`, `7`, `30-37` or `40-47`, resp., that is, only if they do actually turn off some other attribute. Also note that if the "should still be underlined" text is made longer so that it overflows to the next line (or even multiple new lines), it's underlined in the last one of these lines. This makes it perhaps a reincarnation of #47. Furthermore, changing the window width and thus causing a reflow of the text removes the underlining from the last line.
claunia commented 2026-01-30 23:43:06 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 6, 2019):

Investigation yields that the attributes are read & stored correctly; next step is looking at VtEngine (ConPTY out).

@DHowett-MSFT commented on GitHub (Oct 6, 2019): Investigation yields that the attributes are read & stored correctly; next step is looking at VtEngine (ConPTY out).
claunia commented 2026-01-30 23:43:06 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 6, 2019):

VtEngine::_RgbUpdateDrawingBrushes doesn't factor in any attributes other than bold & color (actual RGB value) when it decides to emit \e[m. This is something that'll probably be addressed by #2661, which suggests that we should defer converting attributes into RGB values (and other unpacked flags) as late as possible.

@DHowett-MSFT commented on GitHub (Oct 6, 2019): `VtEngine::_RgbUpdateDrawingBrushes` doesn't factor in any attributes other than bold & color (actual RGB value) when it decides to emit `\e[m`. This is something that'll probably be addressed by #2661, which suggests that we should defer converting attributes into RGB values (and other unpacked flags) as late as possible.
claunia commented 2026-01-30 23:43:06 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 6, 2019):

I'm keeping this one open as a linked workitem. Thanks for finding this, @egmontkob!

@DHowett-MSFT commented on GitHub (Oct 6, 2019): I'm keeping this one open as a linked workitem. Thanks for finding this, @egmontkob!
claunia commented 2026-01-30 23:43:06 +00:00
Author
Owner
Copy Link

@aeiplatform commented on GitHub (Oct 6, 2019):

Since echo -e is not POSIX compliant, you should rather combine printf and tput for text formatting.
In POSIX echo acts like echo -e by default but not in bash, because of arguments expansion.

I guess this command for my current bash works as expected.
(GNU bash, version 4.3.48(1)-release (x86_64-pc-linux-gnu)).
image

In POSIX this would be equivalent for yours example:
printf "%s underline %s yellow %s should still be underlined %s\n" "$(tput smul)" "$(tput setaf 3)" "$(tput setaf 7)" "$(tput sgr0)"

@aeiplatform commented on GitHub (Oct 6, 2019): Since `echo -e` is not POSIX compliant, you should rather combine `printf` and `tput` for text formatting. In POSIX `echo` acts like `echo -e` by default but not in bash, because of arguments expansion. I guess this command for my current bash works as expected. (GNU bash, version 4.3.48(1)-release (x86_64-pc-linux-gnu)). ![image](https://user-images.githubusercontent.com/56209373/66266814-52fb9280-e82a-11e9-9556-5a07107cbff8.png) In POSIX this would be equivalent for yours example: `printf "%s underline %s yellow %s should still be underlined %s\n" "$(tput smul)" "$(tput setaf 3)" "$(tput setaf 7)" "$(tput sgr0)"`
claunia commented 2026-01-30 23:43:06 +00:00
Author
Owner
Copy Link

@egmontkob commented on GitHub (Oct 6, 2019):

Re echo -e vs. printf: I know, using echo -e is a bad habit of mine, I know I should use printf. :)

I disagree with tput, though (and echo vs printf doesn't really matter either). I'm not writing portable software here, I'm writing a reproducer test case for a bug in the terminal emulator.

Using tput instead of raw escape sequence introduces a level of indirection, makes the behavior depend on $TERM as well as potentially the terminfo version where my intent is not to, and is IMO harder to read. The terminal emulator cares about numbers like 37 or 39, and not terminfo capabilities such as setaf.

Also, by far not all escape sequences can be generated by tput, let alone deliberately broken ones, which some of my other bugreports are about.

E.g. there's no terminfo capability I'm aware of that would generate \e[39m that my example uses. You mistakenly changed that to \e[37m, or, well, its tput equivalent, modifying the test case, which could be the reason for you not hitting the bug.

@egmontkob commented on GitHub (Oct 6, 2019): Re `echo -e` vs. `printf`: I know, using `echo -e` is a bad habit of mine, I know I should use `printf`. :) I disagree with `tput`, though (and `echo` vs `printf` doesn't really matter either). I'm not writing portable software here, I'm writing a reproducer test case for a bug in the terminal emulator. Using `tput` instead of raw escape sequence introduces a level of indirection, makes the behavior depend on `$TERM` as well as potentially the terminfo version where my intent is not to, and is IMO harder to read. The terminal emulator cares about numbers like 37 or 39, and not terminfo capabilities such as `setaf`. Also, by far not all escape sequences can be generated by `tput`, let alone deliberately broken ones, which some of my other bugreports are about. E.g. there's no terminfo capability I'm aware of that would generate `\e[39m` that my example uses. You mistakenly changed that to `\e[37m`, or, well, its `tput` equivalent, modifying the test case, which could be the reason for you not hitting the bug.
claunia commented 2026-01-30 23:43:06 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 21, 2020):

Lol- I just hit this myself, forgot we had a bug on it and re-investigated it.

Apparently what I said months ago is still true. Weird how that works.

@DHowett-MSFT commented on GitHub (Feb 21, 2020): Lol- I just hit this myself, forgot we had a bug on it and re-investigated it. Apparently what I said months ago is still true. Weird how that works.
claunia commented 2026-01-30 23:43:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6506, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6506, which has now been successfully released as `Windows Terminal Preview v1.2.2022.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2022.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Needs-Tag-Fix Priority-2 Product-Conpty Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4289
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?