starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Don't round the tabs #4298

New Issue
Closed
opened 2026-01-30 23:43:19 +00:00 by claunia · 10 comments
claunia commented 2026-01-30 23:43:19 +00:00
Owner
Copy Link

Originally created by @musm on GitHub (Oct 5, 2019).

I hate the rounded tab look. Doesn't mesh well with the Windows 10 UI.

Originally created by @musm on GitHub (Oct 5, 2019). I hate the rounded tab look. Doesn't mesh well with the Windows 10 UI.
claunia added the Issue-FeatureNeeds-TriageNeeds-Tag-Fix labels 2026-01-30 23:43:19 +00:00
claunia commented 2026-01-30 23:43:20 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Oct 5, 2019):

The Windows 10 UI will be getting rounded controls and dialogs

@mdtauk commented on GitHub (Oct 5, 2019): The Windows 10 UI will be getting rounded controls and dialogs
claunia commented 2026-01-30 23:43:20 +00:00
Author
Owner
Copy Link

@musm commented on GitHub (Oct 5, 2019):

Source?

@musm commented on GitHub (Oct 5, 2019): Source?
claunia commented 2026-01-30 23:43:20 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Oct 5, 2019):

Source?

The Win UI controls have been updated to have rounded corners, and this is under the guidance of the Fluent / Windows Design Team

@mdtauk commented on GitHub (Oct 5, 2019): > Source? The Win UI controls have been updated to have rounded corners, and this is under the guidance of the Fluent / Windows Design Team
claunia commented 2026-01-30 23:43:20 +00:00
Author
Owner
Copy Link

@musm commented on GitHub (Oct 5, 2019):

Interesting. Personally it clashes with thr square UI box the terminal is contained in. But the UI still has a lot of bugs.

@musm commented on GitHub (Oct 5, 2019): Interesting. Personally it clashes with thr square UI box the terminal is contained in. But the UI still has a lot of bugs.
claunia commented 2026-01-30 23:43:21 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Oct 5, 2019):

Windows 10 20H1 is where any Shell changes to window shapes etc will come, if they come.

Then there is Windows 10X which has an entirely new shell, as will the new XBoxes

@mdtauk commented on GitHub (Oct 5, 2019): Windows 10 20H1 is where any Shell changes to window shapes etc will come, if they come. Then there is Windows 10X which has an entirely new shell, as will the new XBoxes
claunia commented 2026-01-30 23:43:21 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 6, 2019):

Seems addressed. Sorry, we're not changing the design of Windows.

@DHowett-MSFT commented on GitHub (Oct 6, 2019): Seems addressed. Sorry, we're not changing the design of Windows.
claunia commented 2026-01-30 23:43:21 +00:00
Author
Owner
Copy Link

@musm commented on GitHub (Nov 6, 2019):

VS Code doesn't round the tab bars, and I am still not convinced this governed by updates to the Win UI control changes since I haven't seen any other software UI with tabs that have them as rounded as they are in the new terminal

image

@musm commented on GitHub (Nov 6, 2019): VS Code doesn't round the tab bars, and I am still not convinced this governed by updates to the Win UI control changes since I haven't seen any other software UI with tabs that have them as rounded as they are in the new terminal ![image](https://user-images.githubusercontent.com/4319522/68319061-b415c080-008b-11ea-998e-37d6c2488074.png)
claunia commented 2026-01-30 23:43:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 6, 2019):

microsoft/microsoft-ui-xaml/v2.2.190917002 and https://github.com/microsoft/microsoft-ui-xaml/v2.3.191007001-prerelease (the later of which we're using) both include multiple patches to round the corners for various UI elements. The long-term roadmap for Windows XAML UI elements is a shift towards more rounded corners. Just because other software hasn't yet ingested the absolutely latest bits doesn't mean that it's not a change that's coming.

@mdtauk might be able to pull up a WinUI roadmap, though I don't know where that lives.

@zadjii-msft commented on GitHub (Nov 6, 2019): [microsoft/microsoft-ui-xaml/v2.2.190917002](https://github.com/microsoft/microsoft-ui-xaml/releases/tag/v2.2.190917002) and [https://github.com/microsoft/microsoft-ui-xaml/v2.3.191007001-prerelease](https://github.com/microsoft/microsoft-ui-xaml/releases/tag/v2.3.191007001-prerelease) (the later of which we're using) both include multiple patches to round the corners for various UI elements. The long-term roadmap for Windows XAML UI elements is a shift towards more rounded corners. Just because other software hasn't yet ingested the absolutely latest bits doesn't mean that it's not a change that's coming. @mdtauk might be able to pull up a WinUI roadmap, though I don't know where that lives.
claunia commented 2026-01-30 23:43:22 +00:00
Author
Owner
Copy Link

@musm commented on GitHub (Nov 6, 2019):

Ok thank you very much. I suppose VS Code will incorporate some of these UI XAML elements in the future.

@musm commented on GitHub (Nov 6, 2019): Ok thank you very much. I suppose VS Code will incorporate some of these UI XAML elements in the future.
claunia commented 2026-01-30 23:43:22 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Nov 6, 2019):

The new chromium Edge tabs are rounded, and the WinUI team is trying to converge on that design

@mdtauk commented on GitHub (Nov 6, 2019): The new chromium Edge tabs are rounded, and the WinUI team is trying to converge on that design
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4298
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?