Profiles file contains invalid json when using comments #4363

Open
opened 2026-01-30 23:45:12 +00:00 by claunia · 0 comments
Owner

Originally created by @davidpendraykalibrate on GitHub (Oct 9, 2019).

Environment

Windows build number: 10.0.18362.0
Windows Terminal version (if applicable): 0.5.2762.0

Steps to reproduce

  1. Press Control + , to open settings in editor

Expected behavior

Comments are encoded in json in a valid way like:

{
  "//1": "To view the default settings, hold 'alt' while clicking on the 'Settings' button.",
  "//2": "For documentation on these settings, see: https://aka.ms/terminal-documentation"
}

Actual behavior

VS Code shows the comment lines with red squiggles under lines like this:
image

This is not just a vscode issue though: the file also doesn't validate in online json validators:
https://jsonformatter.org/16a575

Originally created by @davidpendraykalibrate on GitHub (Oct 9, 2019). # Environment ```none Windows build number: 10.0.18362.0 Windows Terminal version (if applicable): 0.5.2762.0 ``` # Steps to reproduce 1. Press Control + , to open settings in editor # Expected behavior Comments are encoded in json in a valid way like: ``` { "//1": "To view the default settings, hold 'alt' while clicking on the 'Settings' button.", "//2": "For documentation on these settings, see: https://aka.ms/terminal-documentation" } ``` # Actual behavior VS Code shows the comment lines with red squiggles under lines like this: ![image](https://user-images.githubusercontent.com/35926989/66463374-d90b1980-ea74-11e9-8718-b012658e2de2.png) This is not just a vscode issue though: the file also doesn't validate in online json validators: https://jsonformatter.org/16a575
claunia added the Resolution-By-DesignNeeds-Tag-Fix labels 2026-01-30 23:45:13 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4363