starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

TAB character shouldn't move past the end of the line #4423

New Issue
Open
opened 2026-01-30 23:47:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 23:47:27 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Oct 12, 2019).

Environment

Windows build number: Version 10.0.18362.295
Also tested in a recent conhost build: commit 82dd0b978a

Steps to reproduce

Open a bash shell and execute:

printf "A\e[999C\tB"

This outputs an A, then a CUF sequence to move the cursor position to the end of the line, then a TAB control character, and finally a B.

Expected behavior

When in VT mode, a TAB character should not move the cursor position past the end of the line, so the B should be output on the same line as the A, in the last column.

Here's what the above test case looks like in XTerm:

image

Actual behavior

The TAB moves the cursor position onto the start of the next line, so the B is output below the A.

This is what the test case looks like in the Windows console:

image

Proposed fix

In the SCREEN_INFORMATION::GetForwardTab method, simply get rid of the first condition that checks for the cursor being in the last column. See here:

82dd0b978a/src/host/screenInfo.cpp (L2222-L2230)

That case should be handled by the second condition (any X pos greater than or equal to the last tab stop will be set to the last column).

The change shouldn't have any effect on legacy code, because the GetForwardTab method is only used in VT mode, as far as I can tell - the legacy tab handling is a completely separate implementation.

I'd be happy to provide a PR for this if nobody disagrees with the suggested fix.

Originally created by @j4james on GitHub (Oct 12, 2019). # Environment Windows build number: Version 10.0.18362.295 Also tested in a recent conhost build: commit 82dd0b978ae74771b5e9049bbbc6d5ff6c1581aa # Steps to reproduce Open a bash shell and execute: printf "A\e[999C\tB" This outputs an `A`, then a [`CUF`](https://vt100.net/docs/vt510-rm/CUF.html) sequence to move the cursor position to the end of the line, then a `TAB` control character, and finally a `B`. # Expected behavior When in VT mode, a `TAB` character should not move the cursor position past the end of the line, so the `B` should be output on the same line as the `A`, in the last column. Here's what the above test case looks like in XTerm: ![image](https://user-images.githubusercontent.com/4181424/66706863-75147980-ed30-11e9-849c-57e43a225c01.png) # Actual behavior The `TAB` moves the cursor position onto the start of the next line, so the `B` is output below the `A`. This is what the test case looks like in the Windows console: ![image](https://user-images.githubusercontent.com/4181424/66706870-7a71c400-ed30-11e9-97f5-7774070c1d62.png) # Proposed fix In the `SCREEN_INFORMATION::GetForwardTab` method, simply get rid of the first condition that checks for the cursor being in the last column. See here: https://github.com/microsoft/terminal/blob/82dd0b978ae74771b5e9049bbbc6d5ff6c1581aa/src/host/screenInfo.cpp#L2222-L2230 That case should be handled by the second condition (any X pos greater than or equal to the last tab stop will be set to the last column). The change shouldn't have any effect on legacy code, because the `GetForwardTab` method is only used in VT mode, as far as I can tell - the legacy tab handling is a completely separate implementation. I'd be happy to provide a PR for this if nobody disagrees with the suggested fix.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Needs-Tag-Fix Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4423
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?