starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Opening a tab for a shell that is not installed anymore does not notify user that something went wrong #4459

New Issue
Closed
opened 2026-01-30 23:48:15 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 23:48:15 +00:00
Owner
Copy Link

Originally created by @PhMajerus on GitHub (Oct 14, 2019).

Environment

Windows build number: 18363.418
Windows Terminal version: 0.5.2762.0

If a profile is defined with an invalid commandline, or if the shell specified has been uninstalled by the user, trying to open a tab with that profile will not show any warning about the failure to launch the shell process.

If the profile is defined with "closeOnExit":false, the tab will wait forever for the shell to get connected instead of showing an error message. If the profile is defined with "closeOnExit":true, the tab will immediately close with no explanation.

Steps to reproduce

Create a profile with a non-existing shell such as the following:
{
// A non-existing shell
"guid": "{0225F6B6-EC1C-4746-8384-A83DB214D13A}",
"closeOnExit": false,
"name": "dummy",
"commandline": "dummyshell.exe",
"hidden": false
},

Expected behavior

If the commandline cannot be launched, an error should notify the user that the process couldn't be created, so they know they have to look at the command line more closely.

Actual behavior

Instead of some error message, Windows Terminal keeps the tab open and cursor waiting with no hint that something went wrong launching the shell, or simply silently closes the tab if "closeOnExit":true.

Originally created by @PhMajerus on GitHub (Oct 14, 2019). # Environment ```none Windows build number: 18363.418 Windows Terminal version: 0.5.2762.0 ``` If a profile is defined with an invalid commandline, or if the shell specified has been uninstalled by the user, trying to open a tab with that profile will not show any warning about the failure to launch the shell process. If the profile is defined with "closeOnExit":false, the tab will wait forever for the shell to get connected instead of showing an error message. If the profile is defined with "closeOnExit":true, the tab will immediately close with no explanation. # Steps to reproduce Create a profile with a non-existing shell such as the following: { // A non-existing shell "guid": "{0225F6B6-EC1C-4746-8384-A83DB214D13A}", "closeOnExit": false, "name": "dummy", "commandline": "dummyshell.exe", "hidden": false }, # Expected behavior If the commandline cannot be launched, an error should notify the user that the process couldn't be created, so they know they have to look at the command line more closely. # Actual behavior Instead of some error message, Windows Terminal keeps the tab open and cursor waiting with no hint that something went wrong launching the shell, or simply silently closes the tab if "closeOnExit":true.
claunia added the Resolution-Duplicate label 2026-01-30 23:48:15 +00:00
claunia commented 2026-01-30 23:48:16 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 14, 2019):

Hey @PhMajerus, thanks for the report!
This is actually a dupe of #2563, for which we've got a couple plans.
Cheers!

@DHowett-MSFT commented on GitHub (Oct 14, 2019): Hey @PhMajerus, thanks for the report! This is actually a dupe of #2563, for which we've got a couple plans. Cheers!
claunia commented 2026-01-30 23:48:16 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 14, 2019):

/dup #2563

@DHowett-MSFT commented on GitHub (Oct 14, 2019): /dup #2563
claunia commented 2026-01-30 23:48:16 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 14, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Oct 14, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4459
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?