starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ANSI sequence rendered differently: \u001b[0m\u001b[7m\u001b[1m\u001b[32m PASS \u001b[39m\u001b[22m\u001b[27m\u001b[0m #4469

New Issue
Closed
opened 2026-01-30 23:48:28 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 23:48:28 +00:00
Owner
Copy Link

Originally created by @be5invis on GitHub (Oct 15, 2019).

Environment

Windows build number: 18362.418
Windows Terminal version: 0.5.2762.0

Steps to reproduce

  • Install Node.js
  • Run this command in Node.js repl: console.log('\u001b[0m\u001b[7m\u001b[1m\u001b[32m PASS \u001b[39m\u001b[22m\u001b[27m\u001b[0m')

Expected behavior

A PASS is shown in black text and green background.

Actual behavior

In Windows terminal, PASS is shown in dark gray text rather than black. In the old console it is shown in black.

image

Originally created by @be5invis on GitHub (Oct 15, 2019). # Environment ```none Windows build number: 18362.418 Windows Terminal version: 0.5.2762.0 ``` # Steps to reproduce - Install Node.js - Run this command in Node.js repl: `console.log('\u001b[0m\u001b[7m\u001b[1m\u001b[32m PASS \u001b[39m\u001b[22m\u001b[27m\u001b[0m')` # Expected behavior A `PASS` is shown in black text and green background. # Actual behavior In Windows terminal, `PASS` is shown in dark gray text rather than black. In the old console it is shown in black. ![image](https://user-images.githubusercontent.com/240091/66800393-dde32980-eec9-11e9-8cf0-a309a7f8a68f.png)
claunia added the Issue-BugArea-VTResolution-DuplicateProduct-Conpty labels 2026-01-30 23:48:29 +00:00
claunia commented 2026-01-30 23:48:30 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 15, 2019):

I believe this is a version of #293 or #2661. More likely 2661, but I can't get my debug tap working at the moment.

@DHowett-MSFT commented on GitHub (Oct 15, 2019): I believe this is a version of #293 or #2661. More likely 2661, but I can't get my debug tap working at the moment.
claunia commented 2026-01-30 23:48:31 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Oct 15, 2019):

Looking at this in the debugger, I can see the attributes coming through as:

\x1b[1m\x1b[30m\x1b[102m

So in one sense it has got the colors correct, sending through a black foreground with a bright green background, but it also includes the bold attribute, which then ends up making the foreground bright as well.

@j4james commented on GitHub (Oct 15, 2019): Looking at this in the debugger, I can see the attributes coming through as: \x1b[1m\x1b[30m\x1b[102m So in one sense it has got the colors correct, sending through a black foreground with a bright green background, but it also includes the bold attribute, which then ends up making the foreground bright as well.
claunia commented 2026-01-30 23:48:31 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 17, 2019):

Really, this should come out of ConPTY as 1;7;40;92 instead of 30;102 (#2661)... but it looks like we should at the very least suppress the brightness of the foreground when we make the bright foreground the background.

Since we don't support separate bold and bright, that'll also knock the bold attribute off ☹️

@DHowett-MSFT commented on GitHub (Oct 17, 2019): Really, this should come out of ConPTY as `1;7;40;92` instead of `30;102` (#2661)... but it looks like we should at the very least suppress the brightness of the foreground when we make the bright foreground the background. Since we don't support separate bold and bright, that'll also knock the bold attribute off ☹️
claunia commented 2026-01-30 23:48:31 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 21, 2019):

More I think about this the closer I am to calling it a /dupe of #2661. Thanks again!

@DHowett-MSFT commented on GitHub (Oct 21, 2019): More I think about this the closer I am to calling it a /dupe of #2661. Thanks again!
claunia commented 2026-01-30 23:48:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 21, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Oct 21, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Product-Conpty Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?