starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-05-06 20:34:29 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

nodejs: resize doesn't fire on Windows Terminal #4526

New Issue
Closed
opened 2026-01-30 23:49:44 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 23:49:44 +00:00
Owner
Copy Link

Originally created by @8HoLoN on GitHub (Oct 17, 2019).

Environment

Windows build number: W10P : Microsoft Windows [version 10.0.18362.418]
Windows Terminal version (if applicable): Windows Terminal (Preview) Version: 0.5.2762.0


nodejs: v12.11.1

cmd-resize-bug.zip

Steps to reproduce

1. Open cmd or powershell on Windows Terminal
2. run node test.js (after npm i)
3. resize Windows Terminal => the number of column or row is not modified, resize event is not fired

Expected behavior

  1. run the same node test.js on native cmd or powershell and resize the window => everything is OK (the number of row and column is updated)

Actual behavior

  1. resize Windows Terminal => the number of column or row is not modified, resize event is not fired
Originally created by @8HoLoN on GitHub (Oct 17, 2019). # Environment ```none Windows build number: W10P : Microsoft Windows [version 10.0.18362.418] Windows Terminal version (if applicable): Windows Terminal (Preview) Version: 0.5.2762.0 nodejs: v12.11.1 ``` [cmd-resize-bug.zip](https://github.com/microsoft/terminal/files/3741116/cmd-resize-bug.zip) # Steps to reproduce 1. Open cmd or powershell on Windows Terminal 2. run node test.js (after npm i) 3. resize Windows Terminal => the number of column or row is not modified, resize event is not fired # Expected behavior 1. run the same node test.js on native cmd or powershell and resize the window => everything is OK (the number of row and column is updated) # Actual behavior 1. resize Windows Terminal => the number of column or row is not modified, resize event is not fired
claunia added the Needs-Tag-FixProduct-Terminal labels 2026-01-30 23:49:44 +00:00
claunia commented 2026-01-30 23:49:44 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 17, 2019):

So! This is a fun one. Node has decided to ignore the built-in console "resize" events that are automatically generated for anybody who asks, and instead listen to our accessibility subsystem to figure out when the console window has changed size. Since they took a hard dependency on a system that we never offered with an application compatibility guarantee, their resize detector doesn't work in WT.

This is related to #281.

I'm digging up our PM contact with nodejs to make sure we drive this somewhere.

@DHowett-MSFT commented on GitHub (Oct 17, 2019): So! This is a fun one. Node has decided to ignore the built-in console "resize" events that are automatically generated for anybody who asks, and instead listen to our accessibility subsystem to figure out when the console window has changed size. Since they took a hard dependency on a system that we never offered with an application compatibility guarantee, their resize detector doesn't work in WT. This is related to #281. I'm digging up our PM contact with nodejs to make sure we drive this somewhere.
claunia commented 2026-01-30 23:49:45 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 17, 2019):

/cc @yodurr

@DHowett-MSFT commented on GitHub (Oct 17, 2019): /cc @yodurr
claunia commented 2026-01-30 23:49:45 +00:00
Author
Owner
Copy Link

@8HoLoN commented on GitHub (Oct 17, 2019):

For the reference : https://nodejs.org/api/tty.html#tty_event_resize

@8HoLoN commented on GitHub (Oct 17, 2019): For the reference : https://nodejs.org/api/tty.html#tty_event_resize
claunia commented 2026-01-30 23:49:45 +00:00
Author
Owner
Copy Link

@oising commented on GitHub (Oct 18, 2019):

Even more pertinent information on https://github.com/microsoft/terminal/issues/410

@oising commented on GitHub (Oct 18, 2019): Even more pertinent information on https://github.com/microsoft/terminal/issues/410
claunia commented 2026-01-30 23:49:45 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 23, 2019):

It looks like the documentation was updated at some point, but there's a note in this version that explains what's going wrong.

If you switch your tty into raw mode and resume it, you'll get resize events.

@DHowett-MSFT commented on GitHub (Oct 23, 2019): It looks like the documentation was updated at some point, but there's a note in [this version](https://nodejs.org/docs/v8.6.0/api/tty.html#tty_event_resize) that explains what's going wrong. If you switch your tty into raw mode and resume it, you'll get resize events.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4526
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?