starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Code health: consider splitting Pane class into leaf and parent classes #4536

New Issue
Open
opened 2026-01-30 23:49:54 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 23:49:54 +00:00
Owner
Copy Link

Originally created by @mcpiroman on GitHub (Oct 18, 2019).

Idea: Split Pane class into LeafPane and ParentPane, both inheriting from abstract base Pane.

Currently Pane class has many members that are used only in leaf or only in parent mode. IMHO proposed splitting would make the code much cleaner and safer (e.g. from accidentally accessing a terminal when we're not a leaf). There is a long way ahead of panes so this might be worthwhile.

Originally created by @mcpiroman on GitHub (Oct 18, 2019). Idea: Split `Pane` class into `LeafPane` and `ParentPane`, both inheriting from abstract base `Pane`. Currently Pane class has many members that are used only in leaf or only in parent mode. IMHO proposed splitting would make the code much cleaner and safer (e.g. from accidentally accessing a terminal when we're not a leaf). There is a long way ahead of panes so this might be worthwhile.
claunia added the Issue-TaskProduct-TerminalArea-UserInterfaceArea-CodeHealth labels 2026-01-30 23:49:54 +00:00
claunia commented 2026-01-30 23:49:54 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Oct 21, 2019):

This one really needs @zadjii-msft's input. Thanks!

@DHowett-MSFT commented on GitHub (Oct 21, 2019): This one really needs @zadjii-msft's input. Thanks!
claunia commented 2026-01-30 23:49:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 25, 2019):

This seems to make sense to me. I can't think of a good reason why we wouldn't want it to be that way TBH.

@zadjii-msft commented on GitHub (Oct 25, 2019): This seems to make sense to me. I can't think of a good reason why we _wouldn't_ want it to be that way TBH.
claunia commented 2026-01-30 23:49:55 +00:00
Author
Owner
Copy Link

@mcpiroman commented on GitHub (Oct 25, 2019):

And to support non-terminal panes (#997), maybe also make LeafPane abstract and then inherit from it in TerminalPane and alike. What do you think?

@mcpiroman commented on GitHub (Oct 25, 2019): And to support non-terminal panes (#997), maybe also make LeafPane abstract and then inherit from it in TerminalPane and alike. What do you think?
claunia commented 2026-01-30 23:49:55 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 25, 2019):

So as far as #997 is concerned, I actually prototyped a bunch of that back in July, but never got it polished enough to release. YOu can see where I was going with it in this branch:
https://github.com/microsoft/terminal/compare/dev/migrie/f/non-terminal-panes

There's a good chance that reafactoring into parent/leaf panes would make this process even easier, but I was considering just adding an entire other abstraction layer between the Pane and the content anyways.

@zadjii-msft commented on GitHub (Oct 25, 2019): So as far as #997 is concerned, I actually prototyped a bunch of that back in July, but never got it polished enough to release. YOu can see where I was going with it in this branch: https://github.com/microsoft/terminal/compare/dev/migrie/f/non-terminal-panes There's a good chance that reafactoring into parent/leaf panes would make this process even easier, but I was considering just adding an entire other abstraction layer between the Pane and the content anyways.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-UserInterface Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4536
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?