REGRESSION: HTML Copy Broken #4543

Closed
opened 2026-01-30 23:50:02 +00:00 by claunia · 4 comments
Owner

Originally created by @carlos-zamora on GitHub (Oct 19, 2019).

Originally assigned to: @carlos-zamora on GitHub.

Environment

Occurs in commit 9c7e8ce1e3 (master as of Oct. 18, 4:50 PM PST ).

Steps to reproduce

make a selection
copy it
paste to ms word

Expected behavior

formatted text

Actual behavior

formatted text paste does nothing
pasting text only works fine

Originally created by @carlos-zamora on GitHub (Oct 19, 2019). Originally assigned to: @carlos-zamora on GitHub. # Environment Occurs in commit 9c7e8ce1e38dafc019edca1b562fcbf43ed9652c (master as of Oct. 18, 4:50 PM PST ). # Steps to reproduce make a selection copy it paste to ms word # Expected behavior formatted text # Actual behavior formatted text paste does nothing pasting text only works fine
Author
Owner

@carlos-zamora commented on GitHub (Oct 19, 2019):

Probably related to PR #3215. (remember to look at PR without whitespace changes for your own sanity)

After running a quick test, the issue is caused by TextBuffer::GenHTML(). The html data is not output properly. Since this is shared code between ConHost and Terminal, I'm adding an additional label.

Adding Help-Wanted so that anybody can try to fix it over the weekend. If not, I'll take a look on Monday.

@carlos-zamora commented on GitHub (Oct 19, 2019): Probably related to PR #3215. (remember to look at PR without whitespace changes for your own sanity) After running a quick test, the issue is caused by `TextBuffer::GenHTML()`. The html data is not output properly. Since this is shared code between ConHost and Terminal, I'm adding an additional label. Adding Help-Wanted so that anybody can try to fix it over the weekend. If not, I'll take a look on Monday.
Author
Owner

@DHowett-MSFT commented on GitHub (Oct 19, 2019):

#3215 only touches code in conhost (Win32 Interactivity) 😄 it’s not a likely culprit.

@DHowett-MSFT commented on GitHub (Oct 19, 2019): #3215 only touches code in conhost (Win32 Interactivity) :smile: it’s not a likely culprit.
Author
Owner

@DHowett-MSFT commented on GitHub (Oct 19, 2019):

@0xabu is this similar to your report?

@DHowett-MSFT commented on GitHub (Oct 19, 2019): @0xabu is this similar to your report?
Author
Owner

@0xabu commented on GitHub (Oct 19, 2019):

@DHowett-MSFT yes, same symptoms. Regressed between 0.5.2762 and 0.6.2911.

@0xabu commented on GitHub (Oct 19, 2019): @DHowett-MSFT yes, same symptoms. Regressed between 0.5.2762 and 0.6.2911.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4543