Diagonal blanks when using vim #4581

Closed
opened 2026-01-30 23:51:09 +00:00 by claunia · 13 comments
Owner

Originally created by @lzybkr on GitHub (Oct 21, 2019).

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.6.2911.0

Any other software?
Windows vim 8.1.1006

Steps to reproduce

Open a file in vim and type Ctrl+b repeatedly. The 3 screenshots below are each after typing Ctrl+b once.

Expected behavior

No weird blank diagonals while using vim.

Actual behavior

image
image
image

Originally created by @lzybkr on GitHub (Oct 21, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version (if applicable): 0.6.2911.0 Any other software? Windows vim 8.1.1006 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> Open a file in vim and type <kbd>Ctrl+b</kbd> repeatedly. The 3 screenshots below are each after typing <kbd>Ctrl+b</kbd> once. # Expected behavior No weird blank diagonals while using vim. # Actual behavior <!-- What's actually happening? --> ![image](https://user-images.githubusercontent.com/2148248/67248410-41fd7480-f419-11e9-911e-b8314ca66f5e.png) ![image](https://user-images.githubusercontent.com/2148248/67248420-488bec00-f419-11e9-800e-08024fa48ada.png) ![image](https://user-images.githubusercontent.com/2148248/67248430-4e81cd00-f419-11e9-8e2b-b94b7c32d5d1.png)
Author
Owner

@DHowett-MSFT commented on GitHub (Oct 22, 2019):

Repro'd. Time to pop into the debugger and see what's coming out of conhost. 😄

@DHowett-MSFT commented on GitHub (Oct 22, 2019): Repro'd. Time to pop into the debugger and see what's coming out of conhost. :smile:
Author
Owner

@DHowett-MSFT commented on GitHub (Oct 22, 2019):

This regressed with #2965 due to the cursor positioning changes.

@DHowett-MSFT commented on GitHub (Oct 22, 2019): This regressed with #2965 due to the cursor positioning changes.
Author
Owner

@skyline75489 commented on GitHub (Oct 22, 2019):

This is really a "wow" bug, as in "wow how did this happen" and also "wow how did you notice this".

@skyline75489 commented on GitHub (Oct 22, 2019): This is really a "wow" bug, as in "wow how did this happen" and also "wow how did you notice this".
Author
Owner

@skyline75489 commented on GitHub (Oct 22, 2019):

Yeah, I also think it may has something to do with #2965 . Should we just revert both #2965 and #2932 ?

@skyline75489 commented on GitHub (Oct 22, 2019): Yeah, I also think it may has something to do with #2965 . Should we just revert both #2965 and #2932 ?
Author
Owner

@DHowett-MSFT commented on GitHub (Oct 22, 2019):

There's two "real" solutions to the issue in #1360 -- one is to always do "deferred EOL" for terminal (if we go off the edge of the screen, only increment Y and reset X for the next character). This is partially supported by Cursor, which has deferred EOL options.

The other is to implement #780. 😄

@DHowett-MSFT commented on GitHub (Oct 22, 2019): There's two "real" solutions to the issue in #1360 -- one is to _always do "deferred EOL" for terminal_ (if we go off the edge of the screen, only increment Y and reset X for the _next_ character). This is partially supported by Cursor, which has deferred EOL options. The other is to implement #780. :smile:
Author
Owner

@DHowett-MSFT commented on GitHub (Oct 22, 2019):

@skyline75489 I wish we didn't have to, but I do feel safest about reverting both of them.

@DHowett-MSFT commented on GitHub (Oct 22, 2019): @skyline75489 I wish we didn't have to, but I do feel safest about reverting both of them.
Author
Owner

@skyline75489 commented on GitHub (Oct 22, 2019):

@DHowett-MSFT I'm OK with it. No hard feeling. The CJK support is, after all, right now far from ideal with #2213 still open. Reverting those commits doesn't really hurt anyone, at least not me.

But #1360 and the crash while resizing will still be in the dark. That's somewhat discomforting.

@skyline75489 commented on GitHub (Oct 22, 2019): @DHowett-MSFT I'm OK with it. No hard feeling. The CJK support is, after all, right now far from ideal with #2213 still open. Reverting those commits doesn't really hurt anyone, at least not me. But #1360 and the crash while resizing will still be in the dark. That's somewhat discomforting.
Author
Owner

@lzybkr commented on GitHub (Jan 29, 2020):

@DHowett-MSFT - I'm seeing this issue again in vim using Version: 0.9.271.0

image

I don't yet have a consistent repro though.

And note - the duplicate lines are expected in this screenshot, but the blanks on the duplicate lines are not.

@lzybkr commented on GitHub (Jan 29, 2020): @DHowett-MSFT - I'm seeing this issue again in vim using Version: 0.9.271.0 ![image](https://user-images.githubusercontent.com/2148248/73384118-7639ca00-427f-11ea-94e1-11828c67bb7e.png) I don't yet have a consistent repro though. And note - the duplicate lines are expected in this screenshot, but the blanks on the duplicate lines are not.
Author
Owner

@DHowett-MSFT commented on GitHub (Jan 29, 2020):

Ugh.

@DHowett-MSFT commented on GitHub (Jan 29, 2020): Ugh.
Author
Owner

@DHowett-MSFT commented on GitHub (Jan 31, 2020):

This likely regressed with #4150 (@lhecker) -- this ares has traditionally been frustrating to work in because Terminal doesn't support Delayed EOL properly.

@DHowett-MSFT commented on GitHub (Jan 31, 2020): This likely regressed with #4150 (@lhecker) -- this ares has traditionally been frustrating to work in because Terminal doesn't support Delayed EOL properly.
Author
Owner

@lhecker commented on GitHub (Feb 1, 2020):

I'm sorry. 😓 Normally I'd try and remedy the issue now, but I'm sadly unable to reproduce it.
I tried various files in vim and in none of them did CtrlB generate any blank spots for me. Do I have to modify vim in any fashion for this to happen?

@lhecker commented on GitHub (Feb 1, 2020): I'm sorry. 😓 Normally I'd try and remedy the issue now, but I'm sadly unable to reproduce it. I tried various files in vim and in none of them did <kbd>Ctrl</kbd><kbd>B</kbd> generate any blank spots for me. Do I have to modify vim in any fashion for this to happen?
Author
Owner

@zadjii-msft commented on GitHub (Apr 2, 2020):

Hey @lzybkr are you still seeing this? If you can consistently repro this, @DHowett-MSFT's got an idea of how you might be able to get us some debug output to help us investigate ☺️

@zadjii-msft commented on GitHub (Apr 2, 2020): Hey @lzybkr are you still seeing this? If you can consistently repro this, @DHowett-MSFT's got an idea of how you might be able to get us some debug output to help us investigate ☺️
Author
Owner

@lzybkr commented on GitHub (Apr 3, 2020):

I haven't seen it for awhile, I'll close it and reopen if I see it again.

@lzybkr commented on GitHub (Apr 3, 2020): I haven't seen it for awhile, I'll close it and reopen if I see it again.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4581