starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add more abstracted VT render tests #4631

New Issue
Open
opened 2026-01-30 23:52:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 23:52:24 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Oct 24, 2019).

I've had a mind to add a test where we just make a Renderer with a Xterm256 engine, then trigger callbacks on the IRenderTarget, and make sure the frame is what we want for a while now that the pieces are tossed apart a bit nicer now, but I've never had the time

The VTRenderTests are not great. I think it'd be better if we could have a test that more simulated "something happened in the console, did we render the right thing?". In the past, the render engines, threads and Renderer were all too coupled to make a easy unittest of it, but as the code's gotten, better, this seems more resonable.

I imagine a test suite that's authored like this:

  1. Create a Renderer with a Xterm256 engine (preferably in the TEST_METHOD_SETUP)
  2. Grab a handle to it's IRenderTarget (preferably in the TEST_METHOD_SETUP)
  3. Do some stuff to the IRenderTarget
  4. Call PaintFrame on the render
  5. Check that the frame painted is what we expected
(from conversation with @DHowett-MSFT)
Originally created by @zadjii-msft on GitHub (Oct 24, 2019). > I've had a mind to add a test where we just make a Renderer with a Xterm256 engine, then trigger callbacks on the IRenderTarget, and make sure the frame is what we want for a while now that the pieces are tossed apart a bit nicer now, but I've never had the time The VTRenderTests are _not great_. I think it'd be better if we could have a test that more simulated "something happened in the console, did we render the right thing?". In the past, the render engines, threads and Renderer were all too coupled to make a easy unittest of it, but as the code's gotten, better, this seems more resonable. I imagine a test suite that's authored like this: 1. Create a `Renderer` with a Xterm256 engine (preferably in the `TEST_METHOD_SETUP`) 2. Grab a handle to it's `IRenderTarget` (preferably in the `TEST_METHOD_SETUP`) 3. Do some stuff to the `IRenderTarget` 4. Call `PaintFrame` on the render 5. Check that the frame painted is what we expected ###### (from conversation with @DHowett-MSFT)
claunia added the Issue-TaskProduct-ConptyArea-CodeHealth labels 2026-01-30 23:52:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Product-Conpty
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4631
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?