starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Initial window height calculation regression #4854

New Issue
Closed
opened 2026-01-30 23:58:13 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 23:58:13 +00:00
Owner
Copy Link

Originally created by @mcpiroman on GitHub (Nov 7, 2019).

Initial window height is off by titlebar height. This got regressed by #3394 in:

357e835f5d/src/cascadia/WindowsTerminal/AppHost.cpp (L197-L210)

That also blocks #3181 which relys on this size calculation.

Steps to reproduce

  1. Set fontSize to 50
  2. Set initialRows to 2
  3. Launch terminal

Expected behavior

2 rows should fit in the window

Actual behavior

About 1.5 of a row fits.

cc @greg904.

Originally created by @mcpiroman on GitHub (Nov 7, 2019). Initial window height is off by titlebar height. This got regressed by #3394 in: https://github.com/microsoft/terminal/blob/357e835f5d37492812e33eac1dd995232c19de63/src/cascadia/WindowsTerminal/AppHost.cpp#L197-L210 That also blocks #3181 which relys on this size calculation. # Steps to reproduce 1. Set `fontSize` to 50 2. Set `initialRows` to 2 3. Launch terminal # Expected behavior 2 rows should fit in the window # Actual behavior About 1.5 of a row fits. cc @greg904.
claunia added the Issue-BugResolution-DuplicateProduct-TerminalArea-UserInterface labels 2026-01-30 23:58:13 +00:00
claunia commented 2026-01-30 23:58:14 +00:00
Author
Owner
Copy Link

@beviu commented on GitHub (Nov 7, 2019):

Are you sure it's a regression? I just tried with 6f36f8b (before the PR was merged) and the size is also incorrect.

Before the PR, it was calling GetFrameMargins to calculate the size which looks like it includes the title bar's height because it calls GetDragAreaRect and adds the height to the result BUT during my debugging I found that during the initialization, the drag bar is not set yet so GetDragAreaRect returns 0 so GetFrameMargins doesn't include the title bar.

BTW here is a TODO for this (it was supposed say "the height of the title bar" for the second option instead of "tab bar" but I thought I had removed this comment so I didn't fix the comment):
357e835f5d/src/cascadia/TerminalApp/App.cpp (L337-L342)

I didn't fix this bug because it was too hard and (I'm pretty sure, see above) the bug was already there before the PR.

Sorry for breaking your PR :(

Maybe adding static_cast<LONG>(_dragBar or _titlebar.ActualHeight() * GetCurrentDpiScale()) to the height will work? (but as I said above it will probably not work for the initial size calculation because _dragBar is not initialized)

@beviu commented on GitHub (Nov 7, 2019): Are you sure it's a regression? I just tried with 6f36f8b (before the PR was merged) and the size is also incorrect. Before the PR, it was calling `GetFrameMargins` to calculate the size which looks like it includes the title bar's height because it calls `GetDragAreaRect` and adds the height to the result BUT during my debugging I found that during the initialization, the drag bar is not set yet so `GetDragAreaRect` returns 0 so `GetFrameMargins` doesn't include the title bar. BTW here is a TODO for this (it was supposed say "the height of the title bar" for the second option instead of "tab bar" but I thought I had removed this comment so I didn't fix the comment): https://github.com/microsoft/terminal/blob/357e835f5d37492812e33eac1dd995232c19de63/src/cascadia/TerminalApp/App.cpp#L337-L342 I didn't fix this bug because it was too hard and (I'm pretty sure, see above) the bug was already there before the PR. Sorry for breaking your PR :( Maybe adding `static_cast<LONG>(_dragBar or _titlebar.ActualHeight() * GetCurrentDpiScale())` to the height will work? (but as I said above it will probably not work for the initial size calculation because _dragBar is not initialized)
claunia commented 2026-01-30 23:58:14 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 7, 2019):

For the record, I don't believe this regressed. I thought it was always broken 😝

@zadjii-msft commented on GitHub (Nov 7, 2019): For the record, I don't _believe_ this regressed. I thought it was always broken 😝
claunia commented 2026-01-30 23:58:14 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 7, 2019):

Also, I think this one is probably a /dupe of #2061

@zadjii-msft commented on GitHub (Nov 7, 2019): Also, I think this one is probably a /dupe of #2061
claunia commented 2026-01-30 23:58:15 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 7, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Nov 7, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-30 23:58:15 +00:00
Author
Owner
Copy Link

@mcpiroman commented on GitHub (Nov 8, 2019):

Ah ok then, sorry for my accusement. My PR stopped working after I merged with this one because of removed GetDragArea, but I didn't realized it wasn't working with initial sizing before. As to solving this problem, #3182 might help.

@mcpiroman commented on GitHub (Nov 8, 2019): Ah ok then, sorry for my accusement. My PR stopped working after I merged with this one because of removed GetDragArea, but I didn't realized it wasn't working with initial sizing before. As to solving this problem, #3182 might help.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4854
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?