starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Refactor Search module to have different implementations for Terminal and ConHost #4946

New Issue
Closed
opened 2026-01-31 00:01:17 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 00:01:17 +00:00
Owner
Copy Link

Originally created by @KaiyuWang16 on GitHub (Nov 12, 2019).

Description of the new feature/enhancement

This is a follow up of https://github.com/microsoft/terminal/pull/3279. Search module is migrated as a shared component for Terminal and ConHost. However, Color method is used in ConHost but not in Terminal. For now, in Terminal directory we only call Terminal::ColorSelection, which does nothing but just throws exception. We need to consider refactor the codes to provide ConHost and Terminal different implementation.

A possible fix is to make Search an abstract class and provide different implementation in Terminal and ConHost.

Proposed technical implementation details (optional)

Search class can be an abstract class, and we implement it in Terminal and ConHost directory. In this way we can have more specific realization of the Color method.

Search module is well-designed and implemented and can fit Terminal and ConHost's needs.

Originally created by @KaiyuWang16 on GitHub (Nov 12, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement This is a follow up of https://github.com/microsoft/terminal/pull/3279. Search module is migrated as a shared component for Terminal and ConHost. However, Color method is used in ConHost but not in Terminal. For now, in Terminal directory we only call Terminal::ColorSelection, which does nothing but just throws exception. We need to consider refactor the codes to provide ConHost and Terminal different implementation. A possible fix is to make Search an abstract class and provide different implementation in Terminal and ConHost. <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) Search class can be an abstract class, and we implement it in Terminal and ConHost directory. In this way we can have more specific realization of the Color method. <!-- A clear and concise description of what you want to happen. --> Search module is well-designed and implemented and can fit Terminal and ConHost's needs.
claunia commented 2026-01-31 00:01:18 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (May 13, 2020):

This seems more of a CodeHealth thing to me. I'm throwing it into our v2 milestone and assigning it to myself for now.

This might be a random thing we should do as a part of working on Search v2 in #3920.

@carlos-zamora commented on GitHub (May 13, 2020): This seems more of a CodeHealth thing to me. I'm throwing it into our v2 milestone and assigning it to myself for now. This might be a random thing we should do as a part of working on Search v2 in #3920.
claunia commented 2026-01-31 00:01:18 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 21, 2023):

I'm gonna go ahead and close this issue. Both applications now use the exact same functionality. Also, I rewrote Search the past few days and it's now 33 LOC. It's not a maintenance burden anymore. 🙂

@lhecker commented on GitHub (Aug 21, 2023): I'm gonna go ahead and close this issue. Both applications now use the exact same functionality. Also, I rewrote `Search` the past few days and it's now 33 LOC. It's not a maintenance burden anymore. 🙂
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Needs-Tag-Fix Product-Conhost Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4946
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?