starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Possible regression of emoji rendering since 0.6 #4961

New Issue
Closed
opened 2026-01-31 00:01:38 +00:00 by claunia · 15 comments
claunia commented 2026-01-31 00:01:38 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Nov 13, 2019).

Originally assigned to: @DHowett-MSFT on GitHub.

@DHowett-MSFT my man. I'm seeing regression on current master 306e751639

图片

Originally posted by @skyline75489 in https://github.com/microsoft/terminal/issues/3546#issuecomment-553266974

Originally created by @zadjii-msft on GitHub (Nov 13, 2019). Originally assigned to: @DHowett-MSFT on GitHub. @DHowett-MSFT my man. I'm seeing regression on current master https://github.com/microsoft/terminal/commit/306e75163929161b130872dcae890686da57790d ![图片](https://user-images.githubusercontent.com/4710575/68740302-ba74e100-0625-11ea-8ca4-c02fbf7cc099.png) _Originally posted by @skyline75489 in https://github.com/microsoft/terminal/issues/3546#issuecomment-553266974_
claunia commented 2026-01-31 00:01:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 13, 2019):

I'm going to pre-emptively mark this as blocking. We can discuss in triage if this isn't that bad of a regression.

UNFORTUNATELY, I'm not seeing this at all myself :( Black is 0.6, purple is master:
image

@zadjii-msft commented on GitHub (Nov 13, 2019): I'm going to pre-emptively mark this as blocking. We can discuss in triage if this isn't that bad of a regression. UNFORTUNATELY, I'm not seeing this at all myself :( Black is 0.6, purple is master: ![image](https://user-images.githubusercontent.com/18356694/68772523-99919900-05ef-11ea-8d5a-0b95ae6a4a01.png)
claunia commented 2026-01-31 00:01:39 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Nov 13, 2019):

Could it be my locale setting? I'm in zh-CN locale.

@skyline75489 commented on GitHub (Nov 13, 2019): Could it be my locale setting? I'm in zh-CN locale.
claunia commented 2026-01-31 00:01:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 13, 2019):

@skyline75489 That's the first thing I thought of. I'd really hate if a CRT change like that would cause this, but hey, who knows.

Just to try and rule out other factors, could you try the following python script?


print('''\
Combining Diacritics    | [a\u0300\u0304]
Polytonic Greek         | [ᾊ] [Α\u0313\u0300\u0345]
Ideographic Variation   | [東京都葛\U000E0101飾区] [奈良県葛\U000E0100城市]
Composite Hangul        | [\u1100\u116A\u11B3]
Combining Dakuten       | [か\u309A]
Emoji vs Text           | [\u2602] [\u2602\uFE0E] [\u2602\uFE0F]
Emoji                   | [\U0001F469]
Emoji with Skin Tone    | [\U0001F469\U0001F3FB]
Emoji Variation and ZWJ | [\U0001F469\U0001F3FB\u200D\U0001F4BB]
''')

That should be the same as the Node.JS one - I just want to make sure to rule Node out in this case.

@zadjii-msft commented on GitHub (Nov 13, 2019): @skyline75489 That's the first thing I thought of. I'd really hate if a CRT change like that would cause this, but hey, who knows. Just to try and rule out other factors, could you try the following python script? ```python print('''\ Combining Diacritics | [a\u0300\u0304] Polytonic Greek | [ᾊ] [Α\u0313\u0300\u0345] Ideographic Variation | [東京都葛\U000E0101飾区] [奈良県葛\U000E0100城市] Composite Hangul | [\u1100\u116A\u11B3] Combining Dakuten | [か\u309A] Emoji vs Text | [\u2602] [\u2602\uFE0E] [\u2602\uFE0F] Emoji | [\U0001F469] Emoji with Skin Tone | [\U0001F469\U0001F3FB] Emoji Variation and ZWJ | [\U0001F469\U0001F3FB\u200D\U0001F4BB] ''') ``` That should be the same as the Node.JS one - I just want to make sure to rule Node out in this case.
claunia commented 2026-01-31 00:01:40 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Nov 13, 2019):

I'm seeing the same thing with python.

图片

@skyline75489 commented on GitHub (Nov 13, 2019): I'm seeing the same thing with python. ![图片](https://user-images.githubusercontent.com/4710575/68774414-08aad400-0668-11ea-8ece-3eca6f6730ac.png)
claunia commented 2026-01-31 00:01:40 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Nov 13, 2019):

As long as I revert ddcc06e911 (even on master), everything is back to normal. Well not really “normal” but relatively “normal”. You got the idea.

@skyline75489 commented on GitHub (Nov 13, 2019): As long as I revert ddcc06e911a18250c8544c7ea83011451e8256a2 (even on master), everything is back to normal. Well not really “normal” but relatively “normal”. You got the idea.
claunia commented 2026-01-31 00:01:40 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 13, 2019):

@skyline75489 what if you only revert the _VC_Target_Library_Platform part?

@DHowett-MSFT commented on GitHub (Nov 13, 2019): @skyline75489 what if you only revert the `_VC_Target_Library_Platform` part?
claunia commented 2026-01-31 00:01:41 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Nov 13, 2019):

You've got to be kidding me. The App CRT is different by locale than the Desktop CRT? :|

@miniksa commented on GitHub (Nov 13, 2019): You've got to be kidding me. The App CRT is different by locale than the Desktop CRT? :|
claunia commented 2026-01-31 00:01:41 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Nov 14, 2019):

Would it be even more weird if I say that DynamicLibrary is the key? I change winconpty back to DynamicLibrary and it works. Both _VC_Target_Library_Platform and onecoreuap_apiset.lib are seemingly irrelevant.

@skyline75489 commented on GitHub (Nov 14, 2019): Would it be even more weird if I say that `DynamicLibrary` is the key? I change `winconpty` back to `DynamicLibrary` and it works. Both `_VC_Target_Library_Platform` and `onecoreuap_apiset.lib` are seemingly irrelevant.
claunia commented 2026-01-31 00:01:42 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 14, 2019):

Of course! This is the 19H1 emoji bug! @miniksa we aren’t linking the right CreatePseudoConsole. It’s probably the linkage declspec...

@DHowett-MSFT commented on GitHub (Nov 14, 2019): Of course! This is the 19H1 emoji bug! @miniksa we aren’t linking the right CreatePseudoConsole. It’s probably the linkage declspec...
claunia commented 2026-01-31 00:01:42 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 14, 2019):

We can’t repro it locally because the Vb conhost has the fixes.

@DHowett-MSFT commented on GitHub (Nov 14, 2019): We can’t repro it locally because the Vb conhost has the fixes.
claunia commented 2026-01-31 00:01:42 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Nov 14, 2019):

Glad you know where the problem is. Guess now I don't need to change my PC's locale to en-US 😄

@skyline75489 commented on GitHub (Nov 14, 2019): Glad you know where the problem is. Guess now I don't need to change my PC's locale to en-US 😄
claunia commented 2026-01-31 00:01:42 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 14, 2019):

I’m assigning myself because I have the most context.

@DHowett-MSFT commented on GitHub (Nov 14, 2019): I’m assigning myself because I have the most context.
claunia commented 2026-01-31 00:01:43 +00:00
Author
Owner
Copy Link

@JustinGrote commented on GitHub (Nov 15, 2019):

Potentially related, some emojis are super tiny on my system in the console but fine in the titlebar? (They are fine in VSCode et. al.)
image

Just checked and I don't think it's a DPI issue, I dropped mine down to 100% from 175% and same issue.

@JustinGrote commented on GitHub (Nov 15, 2019): Potentially related, some emojis are super tiny on my system in the console but fine in the titlebar? (They are fine in VSCode et. al.) ![image](https://user-images.githubusercontent.com/15258962/68920906-addab080-072b-11ea-9f02-598333a2012c.png) Just checked and I don't think it's a DPI issue, I dropped mine down to 100% from 175% and same issue.
claunia commented 2026-01-31 00:01:43 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 16, 2019):

@JustinGrote that one is #900 😄

@DHowett-MSFT commented on GitHub (Nov 16, 2019): @JustinGrote that one is #900 :smile:
claunia commented 2026-01-31 00:01:44 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 16, 2019):

(also, we don't support VS16/U+FE0F for a bunch of reasons that are being covered in active threads about unicode (#1472))

@DHowett-MSFT commented on GitHub (Nov 16, 2019): (also, we don't support VS16/`U+FE0F` for a bunch of reasons that are being covered in active threads about unicode (#1472))
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalConnection Issue-Bug Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?