starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Blacklist Docker for Windows WSL2 Service Machines #4967

New Issue
Closed
opened 2026-01-31 00:01:48 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 00:01:48 +00:00
Owner
Copy Link

Originally created by @bushidocodes on GitHub (Nov 13, 2019).

Description of the new feature/enhancement

The latest version of Docker for Windows is adding a WSL2-based backend powered by a series of service machines. Terminal currently discovers these and adds them as options that the user can select. These should probably be blacklisted from being presented to the user in the short-term. I imagine a better long-term solution is for WSL2 to be able to use metadata to differentiate service-machines from user-created machines that I might want to log into.

image

  [
  ...
        {
            "guid": "{d8afdc0e-a636-5b68-89dd-50a9d0b54349}",
            "hidden": false,
            "name": "docker-desktop-data",
            "source": "Windows.Terminal.Wsl"
        },
        {
            "guid": "{570fcb8d-792c-5ac7-ab1f-5cfb2cdfdb99}",
            "hidden": false,
            "name": "docker-desktop",
            "source": "Windows.Terminal.Wsl"
        }
  ],

Proposed technical implementation details (optional)

Originally created by @bushidocodes on GitHub (Nov 13, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement The latest version of Docker for Windows is adding a WSL2-based backend powered by a series of service machines. Terminal currently discovers these and adds them as options that the user can select. These should probably be blacklisted from being presented to the user in the short-term. I imagine a better long-term solution is for WSL2 to be able to use metadata to differentiate service-machines from user-created machines that I might want to log into. ![image](https://user-images.githubusercontent.com/8700322/68788886-4bda5800-0612-11ea-8016-13a803b97f08.png) ```json [ ... { "guid": "{d8afdc0e-a636-5b68-89dd-50a9d0b54349}", "hidden": false, "name": "docker-desktop-data", "source": "Windows.Terminal.Wsl" }, { "guid": "{570fcb8d-792c-5ac7-ab1f-5cfb2cdfdb99}", "hidden": false, "name": "docker-desktop", "source": "Windows.Terminal.Wsl" } ], ``` <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. -->
claunia commented 2026-01-31 00:01:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 13, 2019):

Ugh. I knew this day would come!

@benhill should we just, like, match the name or something? That seems bad.

@DHowett commented on GitHub (Nov 13, 2019): Ugh. I knew this day would come! @benhill should we just, like, match the name or something? That seems bad.
claunia commented 2026-01-31 00:01:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 13, 2019):

@benhillis is the right one 😉

@zadjii-msft commented on GitHub (Nov 13, 2019): @benhillis is the right one 😉
claunia commented 2026-01-31 00:01:49 +00:00
Author
Owner
Copy Link

@benhillis commented on GitHub (Nov 13, 2019):

I don't have a strong opinion, but a blacklist doesn't seem like a terrible idea.

@benhillis commented on GitHub (Nov 13, 2019): I don't have a strong opinion, but a blacklist doesn't seem like a terrible idea.
claunia commented 2026-01-31 00:01:50 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 13, 2019):

Sorry about tagging you into a random issue, wrong-Ben.

A disallow list doesn't sound terrible. I mean, it 100% does sound terrible, but it doesn't sound awful.

@DHowett-MSFT commented on GitHub (Nov 13, 2019): Sorry about tagging you into a random issue, wrong-Ben. A disallow list doesn't sound terrible. I mean, it 100% does sound terrible, but it doesn't sound _awful_.
claunia commented 2026-01-31 00:01:50 +00:00
Author
Owner
Copy Link

@benhillis commented on GitHub (Nov 13, 2019):

Semantics :)

I don't like it either, I just think it's really our only choice.

@benhillis commented on GitHub (Nov 13, 2019): Semantics :) I don't like it either, I just think it's really our only choice.
claunia commented 2026-01-31 00:01:50 +00:00
Author
Owner
Copy Link

@gmsantos commented on GitHub (Nov 13, 2019):

As a workaround, I set these profiles as hidden:

    {
        "guid": "{570fcb8d-792c-5ac7-ab1f-5cfb2cdfdb99}",
        "hidden": true,
        "name": "docker-desktop",
        "source": "Windows.Terminal.Wsl"
    },
    {
        "guid": "{d8afdc0e-a636-5b68-89dd-50a9d0b54349}",
        "hidden": true,
        "name": "docker-desktop-data",
        "source": "Windows.Terminal.Wsl"
    }

Maybe docker backend could be hidden as default...

@gmsantos commented on GitHub (Nov 13, 2019): As a workaround, I set these profiles as hidden: ``` { "guid": "{570fcb8d-792c-5ac7-ab1f-5cfb2cdfdb99}", "hidden": true, "name": "docker-desktop", "source": "Windows.Terminal.Wsl" }, { "guid": "{d8afdc0e-a636-5b68-89dd-50a9d0b54349}", "hidden": true, "name": "docker-desktop-data", "source": "Windows.Terminal.Wsl" } ``` Maybe docker backend could be hidden as default...
claunia commented 2026-01-31 00:01:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 14, 2020):

:tada:This issue was addressed in #4156, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.🎉

Handy links:

@ghost commented on GitHub (Jan 14, 2020): :tada:This issue was addressed in #4156, which has now been successfully released as `Windows Terminal Preview v0.8.10091.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.8.10091.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#4967
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?