starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Recognise Left and Right Shift in KEY_EVENT_RECORD.dwControlKeyState #501

New Issue
Open
opened 2026-01-30 21:53:50 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 21:53:50 +00:00
Owner
Copy Link

Originally created by @alabuzhev on GitHub (Dec 30, 2018).

https://docs.microsoft.com/en-us/windows/console/key-event-record-str

wincon.h:

#define RIGHT_ALT_PRESSED     0x0001 // the right alt key is pressed.
#define LEFT_ALT_PRESSED      0x0002 // the left alt key is pressed.
#define RIGHT_CTRL_PRESSED    0x0004 // the right ctrl key is pressed.
#define LEFT_CTRL_PRESSED     0x0008 // the left ctrl key is pressed.
#define SHIFT_PRESSED         0x0010 // the shift key is pressed.
#define NUMLOCK_ON            0x0020 // the numlock light is on.
#define SCROLLLOCK_ON         0x0040 // the scrolllock light is on.
#define CAPSLOCK_ON           0x0080 // the capslock light is on.
#define ENHANCED_KEY          0x0100 // the key is enhanced.

Is it possible to extend it with:

#define LEFT_SHIFT_PRESSED    0x0200 // the left shift key is pressed.
#define RIGHT_SHIFT_PRESSED   0x0400 // the right shift key is pressed.

?

Motivation:

  • Symmetry and flexibility.

For compatibility reasons SHIFT_PRESSED (0x0010) should be preserved and set on either Shift key press of course.

Originally created by @alabuzhev on GitHub (Dec 30, 2018). https://docs.microsoft.com/en-us/windows/console/key-event-record-str wincon.h: ```C++ #define RIGHT_ALT_PRESSED 0x0001 // the right alt key is pressed. #define LEFT_ALT_PRESSED 0x0002 // the left alt key is pressed. #define RIGHT_CTRL_PRESSED 0x0004 // the right ctrl key is pressed. #define LEFT_CTRL_PRESSED 0x0008 // the left ctrl key is pressed. #define SHIFT_PRESSED 0x0010 // the shift key is pressed. #define NUMLOCK_ON 0x0020 // the numlock light is on. #define SCROLLLOCK_ON 0x0040 // the scrolllock light is on. #define CAPSLOCK_ON 0x0080 // the capslock light is on. #define ENHANCED_KEY 0x0100 // the key is enhanced. ``` Is it possible to extend it with: ```C++ #define LEFT_SHIFT_PRESSED 0x0200 // the left shift key is pressed. #define RIGHT_SHIFT_PRESSED 0x0400 // the right shift key is pressed. ``` ? Motivation: - Symmetry and flexibility. For compatibility reasons SHIFT_PRESSED (0x0010) should be preserved and set on either Shift key press of course.
claunia added the Issue-FeatureProduct-ConhostArea-Input labels 2026-01-30 21:53:51 +00:00
claunia commented 2026-01-30 21:53:51 +00:00
Author
Owner
Copy Link

@eugenesvk commented on GitHub (May 21, 2024):

What about the most important control key of all :)

  • ⊞ the Windows key itself?

Should also be part of the bitflags?

Also would be great to include other modifier keys used in advanced keybinding scenarios (since left vs right modifier support is very poor in general):

  • KANA
  • ROYA
  • LOYA

https://www.kbdedit.com/manual/low_level_modifiers.html#Roya_Loya

https://www.kbdedit.com/manual/ex13_replacing_altgr_with_kana.html

@eugenesvk commented on GitHub (May 21, 2024): What about the most important control key of all :) - ⊞ the Windows key itself? Should also be part of the bitflags? Also would be great to include other modifier keys used in advanced keybinding scenarios (since left vs right modifier support is very poor in general): - KANA - ROYA - LOYA https://www.kbdedit.com/manual/low_level_modifiers.html#Roya_Loya https://www.kbdedit.com/manual/ex13_replacing_altgr_with_kana.html
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Input Issue-Feature Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#501
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?