starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Clicking the current tab to raise the window should focus the text area #5043

New Issue
Closed
opened 2026-01-31 00:03:38 +00:00 by claunia · 22 comments
claunia commented 2026-01-31 00:03:38 +00:00
Owner
Copy Link

Originally created by @FaffeF on GitHub (Nov 17, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: 10.0.18363.0
Windows Terminal version: 0.6.2951.0

Any other software? Nope

Steps to reproduce

  1. Start Terminal
  2. Focus another window
  3. Re-focus Terminal by clicking on the active tab
  4. Enter text using your keyboard

Expected behavior

Raising the Terminal window should focus the text area no matter how you do it.

Works as expected if you click any other tab than the currently active.

Actual behavior

Text input is ignored even though the Terminal window has focus. Text input is restored when clicking the text area or focusing another tab.

Originally created by @FaffeF on GitHub (Nov 17, 2019). Originally assigned to: @zadjii-msft on GitHub. # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version: 0.6.2951.0 Any other software? Nope ``` # Steps to reproduce 1. Start Terminal 1. Focus another window 1. Re-focus Terminal by clicking on the active tab 1. Enter text using your keyboard # Expected behavior Raising the Terminal window should focus the text area no matter how you do it. Works as expected if you click any other tab than the currently active. # Actual behavior Text input is ignored even though the Terminal window has focus. Text input is restored when clicking the text area or focusing another tab.
claunia commented 2026-01-31 00:03:40 +00:00
Author
Owner
Copy Link

@egmontkob commented on GitHub (Nov 17, 2019):

gnome-terminal used to suffer from this problem, too. It was super annoying.

@egmontkob commented on GitHub (Nov 17, 2019): gnome-terminal used to suffer from this problem, too. It was super annoying.
claunia commented 2026-01-31 00:03:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 18, 2019):

Thanks for the report! This is actually something that's already being tracked in #1205 / #552, and is fortunately in PR in #3540. Hopefully should be fixed in the next release.

/dup #1205
/dup #552

@zadjii-msft commented on GitHub (Nov 18, 2019): Thanks for the report! This is actually something that's already being tracked in #1205 / #552, and is fortunately in PR in #3540. Hopefully should be fixed in the next release. /dup #1205 /dup #552
claunia commented 2026-01-31 00:03:40 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 18, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Nov 18, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 00:03:40 +00:00
Author
Owner
Copy Link

@FaffeF commented on GitHub (Nov 18, 2019):

Well, my searching skills are apparently not up to the task ¯_(ツ)_/¯

And that should probably be /dup #522, not 552

@FaffeF commented on GitHub (Nov 18, 2019): Well, my searching skills are apparently not up to the task ¯\_(ツ)_/¯ And that should probably be /dup #522, not 552
claunia commented 2026-01-31 00:03:40 +00:00
Author
Owner
Copy Link

@FaffeF commented on GitHub (Nov 26, 2019):

This is not fixed in 0.7.3291.0

@FaffeF commented on GitHub (Nov 26, 2019): This is not fixed in 0.7.3291.0
claunia commented 2026-01-31 00:03:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 26, 2019):

AH what happened?! This definitely was fixed in a previous commit of mine. Must have somehow regressed during the PR. I'll re-open and re-investigate.

@zadjii-msft commented on GitHub (Nov 26, 2019): AH what happened?! This definitely was fixed in a previous commit of mine. Must have somehow regressed during the PR. I'll re-open and re-investigate.
claunia commented 2026-01-31 00:03:41 +00:00
Author
Owner
Copy Link

@DJackman123 commented on GitHub (Jan 7, 2020):

Confirming that it doesn't work for me, either. I'm on version 0.8.3651.0 of Terminal. I played around with this a bit and found that it works fine when I use Alt-Tab to make Terminal the active window. It also works when I click on the tab bar (but not a tab) of Terminal, or when I click on an inactive tab, or even the drop-down menu. It also works when using Ctrl-Tab or clicking inactive tabs when Terminal is active.
However, if I click on the active tab then focus is removed from the text area of the window. This happens regardless of whether Terminal is the active window when clicking the tab.

@DJackman123 commented on GitHub (Jan 7, 2020): Confirming that it doesn't work for me, either. I'm on version 0.8.3651.0 of Terminal. I played around with this a bit and found that it works fine when I use Alt-Tab to make Terminal the active window. It also works when I click on the tab bar (but not a tab) of Terminal, or when I click on an inactive tab, or even the drop-down menu. It also works when using Ctrl-Tab or clicking inactive tabs when Terminal is active. However, if I click on the active tab then focus is removed from the text area of the window. This happens regardless of whether Terminal is the active window when clicking the tab.
claunia commented 2026-01-31 00:03:41 +00:00
Author
Owner
Copy Link

@FaffeF commented on GitHub (Mar 20, 2020):

A bit sad this is still not fixed in 0.10.781.0 😥

@FaffeF commented on GitHub (Mar 20, 2020): A bit sad this is still not fixed in 0.10.781.0 😥
claunia commented 2026-01-31 00:03:41 +00:00
Author
Owner
Copy Link

@gfody commented on GitHub (Jun 17, 2020):

Some additional usability notes as of 1.0.1401.0:
Once the tab has focus it keeps it, even if you alt-tab away and back, or use the minimize/restore buttons - the only way to get the cursor back in the terminal is to tab until it lands there or click the main terminal area.

Ideally the tab wouldn't capture focus at all, but it would probably also suffice to just make it so that clicking the tab switched focus to the terminal area.

@gfody commented on GitHub (Jun 17, 2020): Some additional usability notes as of 1.0.1401.0: Once the tab has focus it keeps it, even if you alt-tab away and back, or use the minimize/restore buttons - the only way to get the cursor back in the terminal is to tab until it lands there or click the main terminal area. Ideally the tab wouldn't capture focus at all, but it would probably also suffice to just make it so that clicking the tab switched focus to the terminal area.
claunia commented 2026-01-31 00:03:42 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 17, 2020):

the only way

Like, even clicking in the terminal region doesn't do it? Huh.

@DHowett commented on GitHub (Jun 17, 2020): > the only way Like, even _clicking in the terminal region_ doesn't do it? Huh.
claunia commented 2026-01-31 00:03:42 +00:00
Author
Owner
Copy Link

@gfody commented on GitHub (Jun 17, 2020):

the only way

Like, even clicking in the terminal region doesn't do it? Huh.

clicking works as long as you don't click on the tab

@gfody commented on GitHub (Jun 17, 2020): > > > the only way > > Like, even _clicking in the terminal region_ doesn't do it? Huh. clicking works as long as you don't click on the tab
claunia commented 2026-01-31 00:03:42 +00:00
Author
Owner
Copy Link

@mle-ii commented on GitHub (Aug 14, 2020):

This still repros in 1.1.2233.0.

@mle-ii commented on GitHub (Aug 14, 2020): This still repros in `1.1.2233.0`.
claunia commented 2026-01-31 00:03:42 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 14, 2020):

@mle-ii Yep, it sure will. That's why this issue is still open 😉

@zadjii-msft commented on GitHub (Aug 14, 2020): @mle-ii Yep, it sure will. That's why this issue is still open 😉
claunia commented 2026-01-31 00:03:43 +00:00
Author
Owner
Copy Link

@FaffeF commented on GitHub (Aug 14, 2020):

Really hard to fix, or just keeps getting left on the backlog?

@FaffeF commented on GitHub (Aug 14, 2020): Really hard to fix, or just keeps getting left on the backlog?
claunia commented 2026-01-31 00:03:43 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 14, 2020):

@FaffeF https://github.com/microsoft/terminal/pull/6290#issuecomment-674189421

@DHowett commented on GitHub (Aug 14, 2020): @FaffeF https://github.com/microsoft/terminal/pull/6290#issuecomment-674189421
claunia commented 2026-01-31 00:03:44 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 14, 2020):

Honestly a bit of both. Hard to come up with a good, comprehensive way to prevent this from regressing in the future, and also not be hard to maintain, and because of that, it just keeps getting left behind.

IIRC one of the solutions I imagined required that every UI element we add to manually do some work to do the right thing, and that's not great. Like having the cmdpal toss the focus back to the focused control isn't wrong, but it doesn't handle the search/find box appropriately. So we could do a similar thing with the tabs, presuming we fix the search box focus issue. But then also the tab color picker needs to manually toss the focus back, and the tab context menu, and the tab renamer, and anything else we might add, so that doesn't seem the most scalable

@zadjii-msft commented on GitHub (Aug 14, 2020): Honestly a bit of both. Hard to come up with a good, comprehensive way to prevent this from regressing in the future, and also not be hard to maintain, and because of that, it just keeps getting left behind. IIRC one of the solutions I imagined required that every UI element we add to manually do some work to do the right thing, and that's not great. Like having the cmdpal toss the focus back to the focused control isn't wrong, but it doesn't handle the search/find box appropriately. So we could do a similar thing with the tabs, presuming we fix the search box focus issue. But then also the tab color picker needs to manually toss the focus back, and the tab context menu, and the tab renamer, and anything else we might add, so that doesn't seem the most scalable
claunia commented 2026-01-31 00:03:45 +00:00
Author
Owner
Copy Link

@mle-ii commented on GitHub (Aug 14, 2020):

Luckily this is not too hard to work around. I tried a few things out, so besides clicking in the terminal window area one can hit tab 2 times or click a different tab and back to the tab you want. But yeah, I've sent a few words off into the ether after clicking a tab. LOL

I suppose some other possibilities until this can get fixed without breaking things is to show that the tab UI has focus (you can see focus shown if you hit left or right arrow key when the tab has focus) and/or flash when the tab UI has focus and you type. Or perhaps when certain keys, like say alpha/numeric are hit the focus moves to the terminal and text gets sent there.

What is odd is that Ctrl+Tab cycling around through the tabs or back again with Ctrl+Shift+Tab gives the window the proper focus when is back to that tab.

And I agree, getting focus right is very hard. I spent several years of my working career at MS in my past working on testing UI controls. :)

@mle-ii commented on GitHub (Aug 14, 2020): Luckily this is not too hard to work around. I tried a few things out, so besides clicking in the terminal window area one can hit tab 2 times or click a different tab and back to the tab you want. But yeah, I've sent a few words off into the ether after clicking a tab. LOL I suppose some other possibilities until this can get fixed without breaking things is to show that the tab UI has focus (you can see focus shown if you hit left or right arrow key when the tab has focus) and/or flash when the tab UI has focus and you type. Or perhaps when certain keys, like say alpha/numeric are hit the focus moves to the terminal and text gets sent there. What is odd is that Ctrl+Tab cycling around through the tabs or back again with Ctrl+Shift+Tab gives the window the proper focus when is back to that tab. And I agree, getting focus right is very hard. I spent several years of my working career at MS in my past working on testing UI controls. :)
claunia commented 2026-01-31 00:03:45 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Sep 1, 2020):

Yup. This behavior is very annoying.

@vefatica commented on GitHub (Sep 1, 2020): Yup. This behavior is very annoying.
claunia commented 2026-01-31 00:03:45 +00:00
Author
Owner
Copy Link

@JFLarvoire commented on GitHub (Oct 6, 2020):

This still happens in version 1.3.2651.0, and this is very annoying indeed:
Several times a day, I click on a tab, and type several words for nothing... until I notice they have not appeared in the terminal :-(
The strange thing is that the occurrence is unpredictable: Most of the times, it just works fine.

@JFLarvoire commented on GitHub (Oct 6, 2020): This still happens in version 1.3.2651.0, and this is very annoying indeed: Several times a day, I click on a tab, and type several words for nothing... until I notice they have not appeared in the terminal :-( The strange thing is that the occurrence is unpredictable: Most of the times, it just works fine.
claunia commented 2026-01-31 00:03:45 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #10048, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #10048, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 00:03:46 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #10048, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #10048, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 00:03:46 +00:00
Author
Owner
Copy Link

@FaffeF commented on GitHub (May 25, 2021):

Halleluja!

@FaffeF commented on GitHub (May 25, 2021): Halleluja!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5043
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?