About modal's context menu is not legible when using dark theme #5118

Closed
opened 2026-01-31 00:05:27 +00:00 by claunia · 5 comments
Owner

Originally created by @ducaale on GitHub (Nov 21, 2019).

Environment

Windows build number: 10.0.18363.476
Windows Terminal version (if applicable): 0.6.2951.0

Steps to reproduce

  1. Make sure Windows Terminal is in dark theme and Windows 10 default app mode is light
  2. Open about modal
  3. Highlight some text and right click

Expected behavior

Context menu should be legible with white text on dark background.

Actual behavior

Context menu text is not legible.

Screenshot (35)

Originally created by @ducaale on GitHub (Nov 21, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.18363.476 Windows Terminal version (if applicable): 0.6.2951.0 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. Make sure Windows Terminal is in dark theme and Windows 10 default app mode is light 2. Open `about` modal 3. Highlight some text and right click # Expected behavior Context menu should be legible with white text on dark background. <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior <!-- What's actually happening? --> Context menu text is not legible. ![Screenshot (35)](https://user-images.githubusercontent.com/16341131/69338535-5375ae80-0c5b-11ea-9bf8-b59d693a5a6f.png)
Author
Owner

@AritraNath commented on GitHub (Nov 21, 2019):

Works fine in my case....Proper legible white text.

2019-11-21 (1)

@AritraNath commented on GitHub (Nov 21, 2019): Works fine in my case....Proper legible white text. ![2019-11-21 (1)](https://user-images.githubusercontent.com/38553944/69342963-a028ac00-0c92-11ea-988c-2a9be3676c74.png)
Author
Owner

@zadjii-msft commented on GitHub (Nov 21, 2019):

@ducaale Did you switch to dark mode while the app was already running? Or did you launch the app in dark mode?

@zadjii-msft commented on GitHub (Nov 21, 2019): @ducaale Did you switch to dark mode while the app was already running? Or did you launch the app in dark mode?
Author
Owner

@ducaale commented on GitHub (Nov 21, 2019):

@zadjii-msft I launched the app in dark mode.

@ducaale commented on GitHub (Nov 21, 2019): @zadjii-msft I launched the app in dark mode.
Author
Owner

@ducaale commented on GitHub (Nov 21, 2019):

@AaChristian it seems that the color of text depends on the theme of windows and not on the theme of the terminal. the context menu is legible when windows default app mode is dark

Screenshot (42)

@ducaale commented on GitHub (Nov 21, 2019): @AaChristian it seems that the color of text depends on the theme of windows and not on the theme of the terminal. the context menu is legible when windows default app mode is dark ![Screenshot (42)](https://user-images.githubusercontent.com/16341131/69345979-f2090c00-0c69-11ea-99bf-ce1f011f271d.png)
Author
Owner

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5224, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5224, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5118