starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Any time we take a profile GUID, consider taking a profile name #5144

New Issue
Closed
opened 2026-01-31 00:06:08 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:06:08 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Nov 23, 2019).

starts with { = guid, and we'll need a helper that looks in your profile list for a name and turns it into a guid. This'll allow people to specify guidless profiles in future key bindings that let you specify guids, as well as in defaultProfile

Originally created by @DHowett-MSFT on GitHub (Nov 23, 2019). starts with `{` = guid, and we'll need a helper that looks in your profile list for a name and turns it into a guid. This'll allow people to specify guidless profiles in future key bindings that let you specify guids, as well as in `defaultProfile`
claunia commented 2026-01-31 00:06:09 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 23, 2019):

If somebody names their profile {something that looks like a guid}, I mean, that's their own fault.

@DHowett-MSFT commented on GitHub (Nov 23, 2019): If somebody names their profile `{something that looks like a guid}`, I mean, that's their own fault.
claunia commented 2026-01-31 00:06:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 25, 2019):

If somebody names their profile {something that looks like a guid}, I mean, that's their own fault.

If we fail to parse a GUID, we can always just fall back to looking up a name. Though I suppose if someone names their profile {an-actual-guid}, that's just begging for things to not work right.

@zadjii-msft commented on GitHub (Nov 25, 2019): > > > If somebody names their profile `{something that looks like a guid}`, I mean, that's their own fault. If we fail to parse a GUID, we can always just fall back to looking up a name. Though I suppose if someone names their profile `{an-actual-guid}`, that's just begging for things to not work right.
claunia commented 2026-01-31 00:06:09 +00:00
Author
Owner
Copy Link

@mkitzan commented on GitHub (Nov 27, 2019):

@DHowett-MSFT I can add a helper function in CascadiaSettings which takes a wstring profile name and returns a GUID, if there's a match. Is this kind of what you're thinking with this one?

@mkitzan commented on GitHub (Nov 27, 2019): @DHowett-MSFT I can add a helper function in `CascadiaSettings` which takes a `wstring` profile name and returns a `GUID`, if there's a match. Is this kind of what you're thinking with this one?
claunia commented 2026-01-31 00:06:10 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 28, 2019):

@mkitzan yep! I'd be careful though: @zadjii-msft is probably going to be working in this area soon, but you might beat him to it 😄

@DHowett-MSFT commented on GitHub (Nov 28, 2019): @mkitzan yep! I'd be careful though: @zadjii-msft is probably going to be working in this area _soon_, but you might beat him to it :smile:
claunia commented 2026-01-31 00:06:10 +00:00
Author
Owner
Copy Link

@mkitzan commented on GitHub (Nov 28, 2019):

@DHowett I've got the helper implemented which I can open a PR for. However, when looking at Profile, I found a function GetGuid marked noexcept which throws if the GUID is illegitimate. Many noexcept functions in CascadiaSettings use this function. Could be a bad time if this were to throw. Is the dev team aware of this/purposely did this? If not, I can open an issue and fix the noexcept labels (or just make the fix in the PR for this issue). Edit: I'm just going to open an issue for this.

@mkitzan commented on GitHub (Nov 28, 2019): @DHowett I've got the helper implemented which I can open a PR for. However, when looking at `Profile`, I found a function [`GetGuid`](https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalApp/Profile.cpp#L141) marked `noexcept` which throws if the GUID is illegitimate. Many `noexcept` functions in `CascadiaSettings` use this function. Could be a bad time if this were to throw. Is the dev team aware of this/purposely did this? ~If not, I can open an issue and fix the `noexcept` labels (or just make the fix in the PR for this issue).~ Edit: I'm just going to open an issue for this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5144
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?