starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Tab reordering drag and drop approach is confusing #5232

New Issue
Closed
opened 2026-01-31 00:08:14 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 00:08:14 +00:00
Owner
Copy Link

Originally created by @andriysavin on GitHub (Nov 27, 2019).

I find it confusing from the point of user experience that tab reordering is visually implemented as regular drag and drop. It makes me feel that in addition to reordering I can:

a) detach a tab into its own window, like I'm used to do with web browser tabs;
b) drag a tab from one terminal window to other and thus move the tab between windows (again, like in web browsers);
c) and some users may even expect that they can drop a tab into some other app (e.g. embed it into a word document).

My opinion on this is unless implementing features mentioned above is on the roadmap, tab reordering should not allow dragging a tab outside of the tab panel. Instead, the tab being moved should slide within the tab row. A good example is how the tabs are visually sliding during reordering in MS Edge (Chromium version).

And even if tab detaching is planned, it can be done exactly the same as in Edge (Chromium), i.e. the tab header is not floating with the mouse, but is detached with tab content after significant mouse movement.

Originally created by @andriysavin on GitHub (Nov 27, 2019). I find it confusing from the point of user experience that tab reordering is visually implemented as regular drag and drop. It makes me feel that in addition to reordering I can: a) detach a tab into its own window, like I'm used to do with web browser tabs; b) drag a tab from one terminal window to other and thus move the tab between windows (again, like in web browsers); c) and some users may even expect that they can drop a tab into some other app (e.g. embed it into a word document). My opinion on this is unless implementing features mentioned above is on the roadmap, tab reordering should not allow dragging a tab outside of the tab panel. Instead, the tab being moved should slide within the tab row. A good example is how the tabs are visually sliding during reordering in MS Edge (Chromium version). And even if tab detaching is planned, it can be done exactly the same as in Edge (Chromium), i.e. the tab header is not floating with the mouse, but is detached with tab content after significant mouse movement.
claunia commented 2026-01-31 00:08:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 27, 2019):

Thanks for the feedback! I definitely agree with the points you're making. Fortunately, tab tear-out is on the roadmap, but likely not until after 1.0. Before that, we should definitely just keep the tab in the row, with the sliding behavior. This is great feedback for the XAML team (and @teap in particular ☺️).

I've filed https://github.com/microsoft/microsoft-ui-xaml/issues/1685 upstream to make sure this gets added to WinUI, and so we can ingest it ourselves.

@zadjii-msft commented on GitHub (Nov 27, 2019): Thanks for the feedback! I definitely agree with the points you're making. Fortunately, tab tear-out _is_ on the roadmap, but likely not until after 1.0. Before that, we should definitely just keep the tab in the row, with the sliding behavior. This is great feedback for the XAML team (and @teap in particular ☺️). I've filed https://github.com/microsoft/microsoft-ui-xaml/issues/1685 upstream to make sure this gets added to WinUI, and so we can ingest it ourselves.
claunia commented 2026-01-31 00:08:15 +00:00
Author
Owner
Copy Link

@tstager commented on GitHub (Apr 24, 2020):

Do you guys realize that tab reordering crashes terminal if it was run as an administrator?

@tstager commented on GitHub (Apr 24, 2020): Do you guys realize that tab reordering crashes terminal if it was run as an administrator?
claunia commented 2026-01-31 00:08:15 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 24, 2020):

Uh we definitely fixed a bug like that two whole versions ago. Can you confirm the version you’re on?

@DHowett-MSFT commented on GitHub (Apr 24, 2020): Uh we definitely fixed a bug like that two whole versions ago. Can you confirm the version you’re on?
claunia commented 2026-01-31 00:08:15 +00:00
Author
Owner
Copy Link

@tstager commented on GitHub (Apr 24, 2020):

0.11.1121.0

@tstager commented on GitHub (Apr 24, 2020): 0.11.1121.0
claunia commented 2026-01-31 00:08:16 +00:00
Author
Owner
Copy Link

@tstager commented on GitHub (Apr 24, 2020):

0.11.1121.0

@tstager commented on GitHub (Apr 24, 2020): 0.11.1121.0
claunia commented 2026-01-31 00:08:16 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 24, 2020):

https://github.com/microsoft/terminal/pull/5542

It looks like we regressed this when we were cleaning some stuff up.

@DHowett-MSFT commented on GitHub (Apr 24, 2020): https://github.com/microsoft/terminal/pull/5542 It looks like we regressed this when we were cleaning some stuff up.
claunia commented 2026-01-31 00:08:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 13, 2021):

Huh so I'm looking through the backlog here, and I honestly think we're gonna get to #1256 before the WinUI team is going to be able to get to microsoft/microsoft-ui-xaml#1685. They're pretty swamped with Win11 work at the moment, and we've been making a lot of progress towards tear-out (see #5000).

I'm just going to close this for now. It's still a good idea for the WinUI TabView, but one we probably won't end up needing ourselves 😅

@zadjii-msft commented on GitHub (Jul 13, 2021): Huh so I'm looking through the backlog here, and I honestly think we're gonna get to #1256 before the WinUI team is going to be able to get to microsoft/microsoft-ui-xaml#1685. They're pretty swamped with Win11 work at the moment, and we've been making a lot of progress towards tear-out (see #5000). I'm just going to close this for now. It's still a good idea for the WinUI TabView, but one we probably won't end up needing ourselves 😅
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal Tracking-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5232
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?