Sometimes panes won't expand and take up blanks #5246

Closed
opened 2026-01-31 00:08:31 +00:00 by claunia · 6 comments
Owner

Originally created by @hez2010 on GitHub (Nov 27, 2019).

Environment

Windows build number: 18363.476
Windows Terminal version (if applicable): 0.7.3291.0

Steps to reproduce

  1. create lots of split panes and resize some panes.
  2. run exit on some of panes to close some panes.
  3. sometimes other panes won't take up the spaces of closed panes.

Expected behavior

Other panes should take up the blank space of the window after I close some panes.

Actual behavior

The blank spaces still leave blank.
image
image

However, if you resize the window, the panes will return to normal.

Originally created by @hez2010 on GitHub (Nov 27, 2019). # Environment ```none Windows build number: 18363.476 Windows Terminal version (if applicable): 0.7.3291.0 ``` # Steps to reproduce 1. create lots of split panes and resize some panes. 2. run `exit` on some of panes to close some panes. 3. sometimes other panes won't take up the spaces of closed panes. # Expected behavior Other panes should take up the blank space of the window after I close some panes. # Actual behavior The blank spaces still leave blank. ![image](https://user-images.githubusercontent.com/14960345/69729004-8985c780-1160-11ea-8353-078e6ddd8119.png) ![image](https://user-images.githubusercontent.com/14960345/69728791-167c5100-1160-11ea-8343-85b329e86719.png) However, if you resize the window, the panes will return to normal.
Author
Owner

@zadjii-msft commented on GitHub (Nov 27, 2019):

wowowow that looks really bad. Thanks for the report! This doesn't always repro, but it definitely does sometimes repro. Good enough for us to be able to investigate.

@zadjii-msft commented on GitHub (Nov 27, 2019): wowowow that looks really bad. Thanks for the report! This doesn't always repro, but it definitely does _sometimes_ repro. Good enough for us to be able to investigate.
Author
Owner

@DHowett-MSFT commented on GitHub (Nov 30, 2019):

Wait, this that modern art I've been hearing so much about

@DHowett-MSFT commented on GitHub (Nov 30, 2019): Wait, this that _modern art_ I've been hearing so much about
Author
Owner

@mcpiroman commented on GitHub (Nov 30, 2019):

For the record, I've been seeing this for a long time, so that's not something recent. I must have forgotten to file an issue.

@mcpiroman commented on GitHub (Nov 30, 2019): For the record, I've been seeing this for a long time, so that's not something recent. I must have forgotten to file an issue.
Author
Owner

@mcpiroman commented on GitHub (Dec 25, 2019):

I thing I've found the cause. But first, the simplest possible repro:

  1. Split pane
  2. Split the right pane
  3. Close the left-most pane

This happens when neighbour of closed pane is a pane in 'parent' state. It won't get resized, because it's children's are sizes are specified by fixed pixel amount. By contrast, a 'leaf' pane does resize, because the terminal control inside is set to fill the grid.
I don't quite understand the intent of https://github.com/microsoft/terminal/issues/3996#issuecomment-566676111, but that seems like the ideal solution for this issue.

@mcpiroman commented on GitHub (Dec 25, 2019): I thing I've found the cause. But first, the simplest possible repro: 1. Split pane 2. Split the right pane 3. Close the left-most pane This happens when neighbour of closed pane is a pane in 'parent' state. It won't get resized, because it's children's are sizes are specified by fixed pixel amount. By contrast, a 'leaf' pane does resize, because the terminal control inside is set to fill the grid. I don't quite understand the intent of https://github.com/microsoft/terminal/issues/3996#issuecomment-566676111, but that seems like the ideal solution for this issue.
Author
Owner

@zadjii-msft commented on GitHub (Dec 30, 2019):

@mcpiroman Ooh, that's a really good catch. That comment probably will fix this. Thanks!

@zadjii-msft commented on GitHub (Dec 30, 2019): @mcpiroman Ooh, that's a really good catch. That comment probably will fix this. Thanks!
Author
Owner

@ghost commented on GitHub (Mar 20, 2020):

:tada:This issue was addressed in #4953, which has now been successfully released as Windows Terminal Preview v0.10.781.0.🎉

Handy links:

@ghost commented on GitHub (Mar 20, 2020): :tada:This issue was addressed in #4953, which has now been successfully released as `Windows Terminal Preview v0.10.781.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.10.781.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5246