starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Bright foreground color hard-coded to be brightWhite, bold text invisible for light color schemes #5303

New Issue
Closed
opened 2026-01-31 00:10:06 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 00:10:06 +00:00
Owner
Copy Link

Originally created by @roblillack on GitHub (Nov 29, 2019).

Environment

Windows build number: Microsoft Windows NT 10.0.18363.0
Windows Terminal version (if applicable): 0.7.3291.0

Steps to reproduce

  1. Select light color scheme (dark foreground color on very light background color)
  2. Try to display bright text (ANSI escape code [1m) without specifying a non-default color, for example by running this in a WSL shell:
echo "this is $(tput bold)normal bright text$(tput sgr0) and this is $(tput setaf 1)$(tput bold)red bright text$(tput sgr0)."

Expected behavior

The words "normal bright text" should be visible (and, preferably, highlighted in some way or bold).

Actual behavior

Windows Terminal selects "bright white" as the default "bright foreground" color which in this case is the same as the background color. Also, compare it to the behavior of ConEmu below, that works:

image

Suggestion

There are multiple ways to solve this problem (which are separate from implementing bold support as discussed in #109):

  1. Add an option brightForeground to the color schemes so light schemes can set it to a dark color, or
  2. Add an option to ignore the [1m escape sequences altogether, or
  3. Implement a better algorithm that does not hardcode using "bright white" but chooses a fitting color from the palette based on the perceived "darkness" of the background color (say, go with "bright black" for light backgrounds, "bright white" for dark backgrounds)

I strongly suggest to go with option no. 1.

Originally created by @roblillack on GitHub (Nov 29, 2019). # Environment ```none Windows build number: Microsoft Windows NT 10.0.18363.0 Windows Terminal version (if applicable): 0.7.3291.0 ``` # Steps to reproduce 1. Select light color scheme (dark foreground color on very light background color) 2. Try to display _bright_ text (ANSI escape code `[1m`) without specifying a non-default color, for example by running this in a WSL shell: ``` echo "this is $(tput bold)normal bright text$(tput sgr0) and this is $(tput setaf 1)$(tput bold)red bright text$(tput sgr0)." ``` # Expected behavior The words "normal bright text" should be visible (and, preferably, highlighted in some way or bold). # Actual behavior Windows Terminal selects "bright white" as the default "bright foreground" color which in this case is the same as the background color. Also, compare it to the behavior of ConEmu below, that works: ![image](https://user-images.githubusercontent.com/37167/69890823-4b231080-12f8-11ea-853a-858e48d887aa.png) # Suggestion There are multiple ways to solve this problem (which are separate from implementing bold support as discussed in #109): 1. Add an option `brightForeground` to the color schemes so light schemes can set it to a dark color, _or_ 2. Add an option to ignore the `[1m` escape sequences altogether, _or_ 3. Implement a better algorithm that does not hardcode using "bright white" but chooses a fitting color from the palette based on the perceived "darkness" of the background color (say, go with "bright black" for light backgrounds, "bright white" for dark backgrounds) I strongly suggest to go with option no. 1.
claunia added the Resolution-Duplicate label 2026-01-31 00:10:06 +00:00
claunia commented 2026-01-31 00:10:07 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Nov 29, 2019):

This sounds the same as #3022, which was resolved as a duplicate of #2661 and #293.

@j4james commented on GitHub (Nov 29, 2019): This sounds the same as #3022, which was resolved as a duplicate of #2661 and #293.
claunia commented 2026-01-31 00:10:07 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Nov 30, 2019):

Yep, this is a /dupe of #2661 and #293. Thanks!

@DHowett-MSFT commented on GitHub (Nov 30, 2019): Yep, this is a /dupe of #2661 and #293. Thanks!
claunia commented 2026-01-31 00:10:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 30, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Nov 30, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5303
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?