Figure out copyWith{,out}Newlines, perhaps rename Keybinding Arg for Copy #5371

Closed
opened 2026-01-31 00:11:49 +00:00 by claunia · 3 comments
Owner

Originally created by @carlos-zamora on GitHub (Dec 3, 2019).

Originally assigned to: @carlos-zamora on GitHub.

Description of the new feature/enhancement

the discussion about what it means to strip newlines but not strip whitespace, strip whitespace but not strip newlines, strip all or strip nothing needs to be had in a followup issue.
-Dustin, December 2019

Proposed technical implementation details (optional)

trimWhitespace is weird and ambiguous. Here's some ideas that have been thrown out...

  • copyNewlines
  • stripNewlines

Keep in mind how this plays with box selection (holding alt key).

Originally created by @carlos-zamora on GitHub (Dec 3, 2019). Originally assigned to: @carlos-zamora on GitHub. # Description of the new feature/enhancement the discussion about what it means to strip newlines but not strip whitespace, strip whitespace but not strip newlines, strip all or strip nothing needs to be had in a followup issue. -Dustin, December 2019 # Proposed technical implementation details (optional) `trimWhitespace` is weird and ambiguous. Here's some ideas that have been thrown out... - `copyNewlines` - `stripNewlines` Keep in mind how this plays with box selection (holding alt key).
Author
Owner

@DHowett-MSFT commented on GitHub (Dec 5, 2019):

We may want to determine how often copyTextWithoutNewlinesButWithAllTheWhitespace is used.

@DHowett-MSFT commented on GitHub (Dec 5, 2019): We may want to determine how often `copyTextWithoutNewlinesButWithAllTheWhitespace` is used.
Author
Owner

@DHowett-MSFT commented on GitHub (Mar 25, 2020):

Kayla and I decided on singleLine.

@DHowett-MSFT commented on GitHub (Mar 25, 2020): Kayla and I decided on `singleLine`.
Author
Owner

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5216, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5216, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5371