Can quit git diff after the first page #5374

Open
opened 2026-01-31 00:11:56 +00:00 by claunia · 0 comments
Owner

Originally created by @metin on GitHub (Dec 4, 2019).

It gets stuck when hitting q in the middle of a git diff operation. It is fine if I quit in the first page. It is also fine if I keep paginating until end of the diff.

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.476]
Windows Terminal version (if applicable):   0.7.3291.0


Any other software?
Git for windows: git version 2.24.0.windows.2

Steps to reproduce

  1. cd to any git repository that has as much changes as it could cause pagination.
  2. type git diff and you should see something like this. at this stage you could quit by typing q

image

  1. Hit space to go to next page
  2. Hit q and it will get stuck and never quit
    image

Expected behavior

It shoul always quit from diff even I am in the middle.

Actual behavior

It gets stuck if I hit q in the middle of diff

Originally created by @metin on GitHub (Dec 4, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> It gets stuck when hitting `q` in the middle of a `git diff` operation. It is fine if I quit in the first page. It is also fine if I keep paginating until end of the diff. # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18362.476] Windows Terminal version (if applicable): 0.7.3291.0 Any other software? Git for windows: git version 2.24.0.windows.2 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. `cd` to any git repository that has as much changes as it could cause pagination. 2. type `git diff` and you should see something like this. at this stage you could quit by typing `q` ![image](https://user-images.githubusercontent.com/28767/70231765-079f2b00-176c-11ea-9633-103b1e30dd94.png) 3. Hit space to go to next page 4. Hit `q` and it will get stuck and never quit ![image](https://user-images.githubusercontent.com/28767/70231693-df173100-176b-11ea-87a7-0629c4dad4d2.png) # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> It shoul always quit from diff even I am in the middle. # Actual behavior It gets stuck if I hit `q` in the middle of diff <!-- What's actually happening? -->
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5374