starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Get the LocalTests running in CI again #5389

New Issue
Closed
opened 2026-01-31 00:12:19 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 00:12:19 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Dec 4, 2019).

Originally assigned to: @zadjii-msft on GitHub.

We created LocalTests_TerminalApp as a way to separate out the tests that couldn't be run in CI.

Originally, it's because we didn't have Xaml Islands in CI, so they wouldn't work there. Then, we were able to remove the unittest's dependency on XAML Islands (#3833). However, the tests still don't work in CI, because they require the Microsoft.VCLibs.140.00.Debug framework package, which isn't deployed by default on our CI machines.

An upcoming TAEF release will let us deploy the package from our test's folder, but we need to wait for an updated TAEF for that. This task represents looping back on that thread to get the updated TAEF and configure the tests to run in CI again. Then we can get rid of the LocalTests project, and just have one set of unittests for the TerminalApp.

Originally created by @zadjii-msft on GitHub (Dec 4, 2019). Originally assigned to: @zadjii-msft on GitHub. We created `LocalTests_TerminalApp` as a way to separate out the tests that couldn't be run in CI. Originally, it's because we didn't have Xaml Islands in CI, so they wouldn't work there. Then, we were able to remove the unittest's dependency on XAML Islands (#3833). However, the tests still don't work in CI, because they require the `Microsoft.VCLibs.140.00.Debug` framework package, which isn't deployed by default on our CI machines. An upcoming TAEF release will let us deploy the package from our test's folder, but we need to wait for an updated TAEF for that. This task represents looping back on that thread to get the updated TAEF and configure the tests to run in CI again. Then we can get rid of the LocalTests project, and just have one set of unittests for the TerminalApp.
claunia commented 2026-01-31 00:12:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 8, 2020):

With #4105 merging soon, we're updated to a version of TAEF that'll work for installing framework packages automatically. However, I need to find the right way to get

the dependency AppX next to TE.exe or next to the test

so that TAEF can install it. Should that be in it's own nuget that we have the CI build pull down? Should we just ship it in our dep/ directory, and have the TestHostApp copy it over to it's output path?

This issue is now tracking just that work.

@zadjii-msft commented on GitHub (Jan 8, 2020): With #4105 merging soon, we're updated to a version of TAEF that'll work for installing framework packages automatically. However, I need to find the right way to get > the dependency AppX next to TE.exe or next to the test so that TAEF can install it. Should that be in it's own nuget that we have the CI build pull down? Should we just ship it in our `dep/` directory, and have the `TestHostApp` copy it over to it's output path? This issue is now tracking just that work.
claunia commented 2026-01-31 00:12:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 22, 2022):

2022 notes:

Tried this again in dev/migrie/b/12788-did-it-work
, specifically, 3c54c07f30.

  • I tried to remove all the package dependencies from the testhostapp, so they didn't get pulled down.
  • I tried to bundle the CRT / vclibs in with the app itself. That I think I did wrong.
  • I needed to move the localtests to run on the windows-2019 agents. On the normal agents the tests run non-interactively, and that messes with UWP deployment. Without this, you'll see some errors like 0x8000401A, CO_E_RUNAS_LOGON_FAILURE.

I bet we could fix #12788 and this in a single go, but I have hit my experience limit with the VCLibs

@zadjii-msft commented on GitHub (Jun 22, 2022): 2022 notes: Tried this again in [`dev/migrie/b/12788-did-it-work`](https://github.com/microsoft/terminal/tree/dev/migrie/b/12788-did-it-work) , specifically, 3c54c07f30fbb7e7d9bdf64272e9a804b4a67a3f. * I tried to remove all the package dependencies from the testhostapp, so they didn't get pulled down. * I tried to bundle the CRT / vclibs in with the app itself. That I think I did wrong. * I needed to move the localtests to run on the `windows-2019` agents. On the normal agents the tests run non-interactively, and that messes with UWP deployment. Without this, you'll see some errors like `0x8000401A`, `CO_E_RUNAS_LOGON_FAILURE`. I bet we could fix #12788 and this in a single go, but I have hit my experience limit with the VCLibs * https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines.md * https://github.com/microsoft/terminal/pull/5661/files * https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines/HybridCRT.md * https://github.com/microsoft/WindowsAppSDK/blob/main/HybridCRT.props
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Area-CodeHealth Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5389
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?