starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Title event handler attached to control on tab discards title variable #5444

New Issue
Closed
opened 2026-01-31 00:13:31 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:13:31 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (Dec 6, 2019).

Originally assigned to: @zadjii-msft on GitHub.

9145903e11/src/cascadia/TerminalApp/Tab.cpp (L320-L328)

I'm trying to make the Telnet and Azure connection types set a title when they start up on the tab.

They're calling the ESC]0;

Originally created by @miniksa on GitHub (Dec 6, 2019). Originally assigned to: @zadjii-msft on GitHub. https://github.com/microsoft/terminal/blob/9145903e118bfa3b48749694689aec3a191bc4ac/src/cascadia/TerminalApp/Tab.cpp#L320-L328 I'm trying to make the Telnet and Azure connection types set a title when they start up on the tab. They're calling the ESC]0;<title>BEL sequence on the output handlers to make it happen. Turns out that title makes it all the way to here and then is completely discarded in favor of whatever's already on the title.
claunia commented 2026-01-31 00:13:33 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Dec 6, 2019):

@zadjii-msft, this is the thing I was talking about.

@miniksa commented on GitHub (Dec 6, 2019): @zadjii-msft, this is the thing I was talking about.
claunia commented 2026-01-31 00:13:33 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 6, 2019):

I looked into this. Emitting a title during Start() forces Pane to ask Control for its title before _initializedTerminal is true.

We need to rework the title eventing, and also fix starting titles to actually apply to the terminal instead of letting conhost spout it back at us.

@DHowett-MSFT commented on GitHub (Dec 6, 2019): I looked into this. Emitting a title during Start() forces Pane to ask Control for its title before `_initializedTerminal` is `true`. We need to rework the title eventing, and also fix starting titles to actually apply to the _terminal_ instead of letting conhost spout it back at us.
claunia commented 2026-01-31 00:13:33 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 9, 2019):

For the record, discarding the value of newTitle is intentional here. The Tab doesn't have a TitleChanged event, only the control does. So we hook up a handler to every control's TitleChanged event as a way of getting notified that the Tab's title might have changed.

We maybe should just set the Tab's title to the StartingTitle of the first control added to the tab, if that property is set, rather than waiting for the title to roundtrip through conpty to us.

@zadjii-msft commented on GitHub (Dec 9, 2019): For the record, discarding the value of `newTitle` is intentional here. The `Tab` doesn't have a TitleChanged event, only the control does. So we hook up a handler to every control's `TitleChanged` event as a way of getting notified that the `Tab`'s title _might_ have changed. We maybe should just set the Tab's title to the `StartingTitle` of the first control added to the tab, if that property is set, rather than waiting for the title to roundtrip through conpty to us.
claunia commented 2026-01-31 00:13:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 13, 2021):

@miniksa do we think this is still important? At some point, we changed Terminal::GetConsoleTitle to return the _startingTitle if the title isn't set by VT. Looks like that was in #6433, which was roughly the 1.1 timeframe.

You can go ahead and reopen if you want to veto.

@zadjii-msft commented on GitHub (Jul 13, 2021): @miniksa do we think this is still important? At some point, we changed `Terminal::GetConsoleTitle` to return the `_startingTitle` if the title isn't set by VT. Looks like that was in #6433, which was roughly the 1.1 timeframe. You can go ahead and reopen if you want to veto.
claunia commented 2026-01-31 00:13:34 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jul 13, 2021):

Nah its fine thanks.

@miniksa commented on GitHub (Jul 13, 2021): Nah its fine thanks.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-TerminalControl Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5444
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?