starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Use SSH2 instead of telnetpp #5481

New Issue
Closed
opened 2026-01-31 00:14:23 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 00:14:23 +00:00
Owner
Copy Link

Originally created by @WSLUser on GitHub (Dec 9, 2019).

Description of the new feature/enhancement

Instead of using insecure telnet, why not use ssh? Even devs have to consider security. https://github.com/mscdex/ssh2 seems like a suitable replacement to telnetpp. Granted it's in TS/JS instead of C++ but we already have some JS for windbg so precedent set.

A clear and concise description of what the problem is that the new feature would solve.

Describe why and how a user would use this new functionality (if applicable).

Removes a security vulnerability.

Proposed technical implementation details (optional)

A clear and concise description of what you want to happen.

Have a secure alternative to telnet.

Originally created by @WSLUser on GitHub (Dec 9, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Instead of using insecure telnet, why not use ssh? Even devs have to consider security. https://github.com/mscdex/ssh2 seems like a suitable replacement to telnetpp. Granted it's in TS/JS instead of C++ but we already have some JS for windbg so precedent set. # A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). Removes a security vulnerability. # Proposed technical implementation details (optional) # A clear and concise description of what you want to happen. Have a secure alternative to telnet.
claunia added the Issue-QuestionNeeds-Tag-FixResolution-Answered labels 2026-01-31 00:14:23 +00:00
claunia commented 2026-01-31 00:14:24 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 9, 2019):

Hey thanks for your concern! The telnet connection added in #3858 isn't really supposed to be a public-facing tool. In fact, it's something that we've only really added for internal testing. We know telnet's not particularly secure, but we have no intention of the public ever using it 😉

@zadjii-msft commented on GitHub (Dec 9, 2019): Hey thanks for your concern! The telnet connection added in #3858 isn't really supposed to be a public-facing tool. In fact, it's something that we've only really added for internal testing. We _know_ telnet's not particularly secure, but we have no intention of the public ever using it 😉
claunia commented 2026-01-31 00:14:24 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 9, 2019):

Additionally: the existence of a telnet client is not in itself a security issue.

@DHowett-MSFT commented on GitHub (Dec 9, 2019): Additionally: the existence of a telnet _client_ is not in itself a security issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Question Needs-Tag-Fix Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?