starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

SetConsoleScreenBufferSize(something < viewport) crashes ConPTY host #5494

New Issue
Closed
opened 2026-01-31 00:14:40 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 00:14:40 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Dec 11, 2019).

Originally assigned to: @zadjii-msft on GitHub.

  1. A pseudoconsole host is a headless console
  2. Headless consoles have no minimum size
  3. SetConsoleScreenBufferSize(new) checks to make sure the following are true:
    • new is within minimum size
    • new is within current viewport size
  4. SetConsoleScreenBufferSize only does this check if a console is headful (i.e. not headless)

381b11521a/src/host/getset.cpp (L509-L519)

  1. When we're attached to a conpty, it happily resizes the buffer to be smaller than the viewport.
  2. The next time the whole screen is invalidated (or whenever luck strikes, really), the renderer tries to render the whole viewport, which is now outside the bounds of the buffer.

This part of the check should probably be moved outside of the "are we headful" block;
381b11521a/src/host/getset.cpp (L514-L515)

Trivial repro code:

#include <Windows.h>
int main(int argc, char *argv[])
{
	HANDLE hStdOut = GetStdHandle(STD_OUTPUT_HANDLE);
	SetConsoleScreenBufferSize(hStdOut, {10,10});
	return 0;
}

This purchases a nice plot of land overlooking a cemetery for both WSL interop and Windows Terminal. 😄

Originally created by @DHowett-MSFT on GitHub (Dec 11, 2019). Originally assigned to: @zadjii-msft on GitHub. 1. A pseudoconsole host is a headless console 2. Headless consoles have no minimum size 3. `SetConsoleScreenBufferSize(new)` checks to make sure the following are true: * `new` is within _minimum size_ * `new` is within _current viewport size_ 4. `SetConsoleScreenBufferSize` only does this check if a console is headful (i.e. not headless) https://github.com/microsoft/terminal/blob/381b11521aaaa9a84eea2a308e65d4c5097cc57d/src/host/getset.cpp#L509-L519 5. When we're attached to a conpty, it _happily_ resizes the buffer to be smaller than the viewport. 6. The next time the whole screen is invalidated (or whenever luck strikes, really), the renderer tries to render the whole viewport, which is now outside the bounds of the buffer. This part of the check should _probably_ be moved outside of the "are we headful" block; https://github.com/microsoft/terminal/blob/381b11521aaaa9a84eea2a308e65d4c5097cc57d/src/host/getset.cpp#L514-L515 Trivial repro code: ```cpp #include <Windows.h> int main(int argc, char *argv[]) { HANDLE hStdOut = GetStdHandle(STD_OUTPUT_HANDLE); SetConsoleScreenBufferSize(hStdOut, {10,10}); return 0; } ``` This purchases a nice plot of land overlooking a cemetery for both WSL interop _and_ Windows Terminal. :smile:
claunia commented 2026-01-31 00:14:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 12, 2019):

 RETURN_HR_IF(E_INVALIDARG, (size.X < screenInfo.GetViewport().Width() || 
                             size.Y < screenInfo.GetViewport().Height())); 

 if (!ServiceLocator::LocateGlobals().IsHeadless()) 
 { 
     COORD const coordMin = screenInfo.GetMinWindowSizeInCharacters(); 
     // clang-format off 
     // Make sure requested screen buffer size isn't smaller than the window. 
     RETURN_HR_IF(E_INVALIDARG, (size.Y < coordMin.Y || 
                                 size.X < coordMin.X)); 
     // clang-format on 
 }
@zadjii-msft commented on GitHub (Dec 12, 2019): ```c++ RETURN_HR_IF(E_INVALIDARG, (size.X < screenInfo.GetViewport().Width() || size.Y < screenInfo.GetViewport().Height())); if (!ServiceLocator::LocateGlobals().IsHeadless()) { COORD const coordMin = screenInfo.GetMinWindowSizeInCharacters(); // clang-format off // Make sure requested screen buffer size isn't smaller than the window. RETURN_HR_IF(E_INVALIDARG, (size.Y < coordMin.Y || size.X < coordMin.X)); // clang-format on } ```
claunia commented 2026-01-31 00:14:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 14, 2020):

:tada:This issue was addressed in #4021, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.🎉

Handy links:

@ghost commented on GitHub (Jan 14, 2020): :tada:This issue was addressed in #4021, which has now been successfully released as `Windows Terminal Preview v0.8.10091.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.8.10091.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Issue-Bug Needs-Tag-Fix Product-Conpty Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5494
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?