starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Bind TerminalPage's TabView to TerminalPage::_tabs #5516

New Issue
Closed
opened 2026-01-31 00:15:14 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 00:15:14 +00:00
Owner
Copy Link

Originally created by @leonMSFT on GitHub (Dec 11, 2019).

Originally assigned to: @leonMSFT on GitHub.

Currently, Tab is a regular C++ class. This gives us some annoying headaches when trying to tie Tabs to the UI. For example, as described in #2740, TerminalPage keeps track of two separate vectors of Tab that need to be kept in sync. There's one vector of TabViewItems specifically used by the TabView and another vector of <shared_ptr<Tab>>. Updating one requires an update on the other one.

This could be avoided by using an observable vector of Tab that's bound to the XAML control. However, this requires Tab to be converted to a WinRT class. This would also make future attempts to use Tab in XAML controls much easier. (such as in #1502)

EDIT: as of #4350, Tab has been converted into a WinRT type, and TerminalPage::_tabs has been converted to an IObservableVector. What's left is to bind TerminalPage's TabView to that vector.

Originally created by @leonMSFT on GitHub (Dec 11, 2019). Originally assigned to: @leonMSFT on GitHub. Currently, `Tab` is a regular C++ class. This gives us some annoying headaches when trying to tie `Tab`s to the UI. For example, as described in #2740, `TerminalPage` keeps track of two separate vectors of `Tab` that need to be kept in sync. There's one vector of `TabViewItems` specifically used by the `TabView` and another vector of `<shared_ptr<Tab>>`. Updating one requires an update on the other one. This could be avoided by using an observable vector of `Tab` that's bound to the XAML control. However, this requires `Tab` to be converted to a WinRT class. This would also make future attempts to use `Tab` in XAML controls much easier. (such as in #1502) EDIT: as of #4350, `Tab` has been converted into a WinRT type, and `TerminalPage::_tabs` has been converted to an `IObservableVector`. What's left is to bind `TerminalPage`'s TabView to that vector.
claunia added the Issue-TaskNeeds-Tag-FixProduct-TerminalArea-CodeHealth labels 2026-01-31 00:15:14 +00:00
claunia commented 2026-01-31 00:15:15 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 11, 2019):

(minor warning callout to @mkitzan as well: he requested this on a recent code review, and we're officially booking team work on it. 😄)

@DHowett-MSFT commented on GitHub (Dec 11, 2019): (minor warning callout to @mkitzan as well: he requested this on a recent code review, and we're officially booking team work on it. :smile:)
claunia commented 2026-01-31 00:15:15 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 12, 2019):

I'm yanking triage and scoping it into 1912. 😄

@DHowett-MSFT commented on GitHub (Dec 12, 2019): I'm yanking triage and scoping it into 1912. :smile:
claunia commented 2026-01-31 00:15:15 +00:00
Author
Owner
Copy Link

@leonMSFT commented on GitHub (Jun 22, 2020):

Closing because we actually need access to the TabViewItem to perform some of our custom modifications like tab color and tab title boxes (and maybe future modifications), and so letting us have total control of our TabViewItems is needed, so this in fact is the way

@leonMSFT commented on GitHub (Jun 22, 2020): Closing because we actually need access to the TabViewItem to perform some of our custom modifications like tab color and tab title boxes (and maybe future modifications), and so letting us have total control of our TabViewItems is needed, so this in fact _is the way_
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5516
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?