starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

When the renderer requires too many retries, try gracefully surviving #5600

New Issue
Closed
opened 2026-01-31 00:17:04 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 00:17:04 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Dec 17, 2019).

Today I had DWM or some graphics driver or something take a real long trip upstate. Fortunately, the Terminal didn't immediately crash. However, when the rendering did return, the terminal eventually did crash, because the renderer required too many tries to paint the frame.

while (tries > 0)
{
    const auto hr = _PaintFrameForEngine(pEngine);
    if (E_PENDING == hr)
    {
        if (--tries == 0)
        {
            FAIL_FAST_HR_MSG(E_UNEXPECTED, "A rendering engine required too many retries.");
        }
        continue;
    }
    LOG_IF_FAILED(hr);
    break;
}

@miniksa ca correct me if I'm wrong here, but I think this should maybe just gracefully do nothing, maybe log a message.

I have no idea how to repro this manually, maybe taskkill /f /im dwm.exe would work, but I don't really want to try again.

Originally created by @zadjii-msft on GitHub (Dec 17, 2019). Today I had DWM or some graphics driver or something take a real _long_ trip upstate. Fortunately, the Terminal didn't immediately crash. However, when the rendering did return, the terminal eventually did crash, because the renderer required too many tries to paint the frame. ```c++ while (tries > 0) { const auto hr = _PaintFrameForEngine(pEngine); if (E_PENDING == hr) { if (--tries == 0) { FAIL_FAST_HR_MSG(E_UNEXPECTED, "A rendering engine required too many retries."); } continue; } LOG_IF_FAILED(hr); break; } ``` @miniksa ca correct me if I'm wrong here, but I think this should maybe just gracefully _do nothing_, maybe log a message. I have no idea how to repro this manually, maybe `taskkill /f /im dwm.exe` would work, but I don't really want to try again.
claunia commented 2026-01-31 00:17:05 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jan 3, 2020):

@miniksa Michael Niksa FTE ca correct me if I'm wrong here, but I think this should maybe just gracefully do nothing, maybe log a message.

I have no idea how to repro this manually, maybe taskkill /f /im dwm.exe would work, but I don't really want to try again.

I think maybe we need to identify the reason behind the failure and determine which ones are worth retrying and which ones are unrecoverable.

Also, I'd want to look back in time and check the blame on the file to find the commit/PR/discussion that added that retry loop to see if we can gain some insight on whether the retry loop is mitigating some other usually recoverable issue or whether we must fail for some specific reason.

@miniksa commented on GitHub (Jan 3, 2020): > @miniksa Michael Niksa FTE ca correct me if I'm wrong here, but I think this should maybe just gracefully _do nothing_, maybe log a message. > > I have no idea how to repro this manually, maybe `taskkill /f /im dwm.exe` would work, but I don't really want to try again. I think maybe we need to identify the reason behind the failure and determine which ones are worth retrying and which ones are unrecoverable. Also, I'd want to look back in time and check the blame on the file to find the commit/PR/discussion that added that retry loop to see if we can gain some insight on whether the retry loop is mitigating some other usually recoverable issue or whether we must fail for some specific reason.
claunia commented 2026-01-31 00:17:05 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 3, 2020):

@miniksa so, that was me. We were failing when we lost dcomp/dwm and the swap chain flip method failed with "E_PLEASE_RETRY_MY_DEVICE_WENT_AWAY".

@DHowett-MSFT commented on GitHub (Jan 3, 2020): @miniksa so, that was me. We were failing when we lost dcomp/dwm and the swap chain flip method failed with "E_PLEASE_RETRY_MY_DEVICE_WENT_AWAY".
claunia commented 2026-01-31 00:17:06 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jan 3, 2020):

I still feel like there's a maximum number of times to retry when your graphics pipeline soils the bed. Just like when you have bigger problems when your entire machine is out of available virtual memory.

@miniksa commented on GitHub (Jan 3, 2020): I still feel like there's a maximum number of times to retry when your graphics pipeline soils the bed. Just like when you have bigger problems when your entire machine is out of available virtual memory.
claunia commented 2026-01-31 00:17:06 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2020):

@miniksa that's probably true, but I still thought it was peculiar that the Terminal was the only app that beef'd it when the display crashed like that. Even Teams survived. Maybe there's some other event we're missing, like SwapChainPanel::OnDisplayBeefedIt, that we can use to disable/re-enable the render engine.

@zadjii-msft commented on GitHub (Jan 3, 2020): @miniksa that's probably true, but I still thought it was peculiar that the Terminal was the only app that beef'd it when the display crashed like that. Even Teams survived. Maybe there's some other event we're missing, like `SwapChainPanel::OnDisplayBeefedIt`, that we can use to disable/re-enable the render engine.
claunia commented 2026-01-31 00:17:06 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Jan 3, 2020):

SwapChainPanel::OnDisplayBeefedIt

Yes.

@miniksa commented on GitHub (Jan 3, 2020): > `SwapChainPanel::OnDisplayBeefedIt` Yes.
claunia commented 2026-01-31 00:17:06 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 12, 2020):

It turns out that we did this for v1 in #5353!

@DHowett-MSFT commented on GitHub (May 12, 2020): It turns out that we did this for v1 in #5353!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Available Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5600
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?