starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

The first keystroke after dismissing the find dialog is eaten #5602

New Issue
Closed
opened 2026-01-31 00:17:11 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 00:17:11 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Dec 17, 2019).

Originally assigned to: @KaiyuWang16 on GitHub.

Repro Steps:

  1. Open the find dialog
  2. Type some text
  3. Press esc to dismiss the dialog
  4. type some characters

Actual behavior:

The first character typed after dismissing doesn't get sent to the TermControl

Expected

All the characters typed after dismissing the dialog should be sent to the TermControl/TerminalConnection

Originally created by @zadjii-msft on GitHub (Dec 17, 2019). Originally assigned to: @KaiyuWang16 on GitHub. ### Repro Steps: 1. Open the find dialog 2. Type some text 3. Press <kbd>esc</kbd> to dismiss the dialog 4. type some characters ### Actual behavior: The first character typed after dismissing doesn't get sent to the `TermControl` ### Expected All the characters typed after dismissing the dialog should be sent to the `TermControl`/`TerminalConnection`
claunia commented 2026-01-31 00:17:12 +00:00
Author
Owner
Copy Link

@KaiyuWang16 commented on GitHub (Dec 19, 2019):

Hi @zadjii-msft , I wonder if you can try again and repo this now ? Actually, I cannot repo this.

@KaiyuWang16 commented on GitHub (Dec 19, 2019): Hi @zadjii-msft , I wonder if you can try again and repo this now ? Actually, I cannot repo this.
claunia commented 2026-01-31 00:17:12 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 19, 2019):

@KaiyuWang16 have you tried with both the keyboard and the mouse?

@DHowett-MSFT commented on GitHub (Dec 19, 2019): @KaiyuWang16 have you tried with both the keyboard _and_ the mouse?
claunia commented 2026-01-31 00:17:12 +00:00
Author
Owner
Copy Link

@KaiyuWang16 commented on GitHub (Dec 19, 2019):

@KaiyuWang16 have you tried with both the keyboard and the mouse?

Yes, I used "Esc" and mouse to close the search dialog.

@KaiyuWang16 commented on GitHub (Dec 19, 2019): > @KaiyuWang16 have you tried with both the keyboard and the mouse? Yes, I used "Esc" and mouse to close the search dialog.
claunia commented 2026-01-31 00:17:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 20, 2019):

Oh I see what's happening. It doesn't really repro in cmd, but it does fairly consistently in a bash shell. The reason is not that the search box is eating a char, but the Esc is getting turned into a literal Esc sent to the input, and bash treats this specially.

You can really see this "esc to the input" if you try the following in a cmd tab:

  1. Type a command, but don't enter it. Just leave it on the prompt line
  2. Open the find dialog
  3. Dismiss it with Esc

You'll see that the command you've typed is now gone, as if you hit Esc in cmd

@zadjii-msft commented on GitHub (Dec 20, 2019): Oh I see what's happening. It doesn't _really_ repro in `cmd`, but it does fairly consistently in a `bash` shell. The reason is not that the search box is eating a char, but the <kbd>Esc</kbd> is getting turned into a literal `Esc` sent to the input, and `bash` treats this specially. You can really see this "`esc` to the input" if you try the following in a `cmd` tab: 1. Type a command, but _don't_ enter it. Just leave it on the prompt line 2. Open the find dialog 3. Dismiss it with <kbd>Esc</kbd> You'll see that the command you've typed is now gone, as if you hit <kbd>Esc</kbd> in `cmd`
claunia commented 2026-01-31 00:17:12 +00:00
Author
Owner
Copy Link

@KaiyuWang16 commented on GitHub (Jan 2, 2020):

@zadjii-msft this PR should fix this issue: https://github.com/microsoft/terminal/pull/4028 I can not repro now.

@KaiyuWang16 commented on GitHub (Jan 2, 2020): @zadjii-msft this PR should fix this issue: https://github.com/microsoft/terminal/pull/4028 I can not repro now.
claunia commented 2026-01-31 00:17:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 2, 2020):

@DHowett-MSFT confirmed for me that #4028 fixed this as well 😄

@zadjii-msft commented on GitHub (Jan 2, 2020): @DHowett-MSFT confirmed for me that #4028 fixed this as well 😄
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5602
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?