starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Figure out how to test our .xaml classes #5606

New Issue
Closed
opened 2026-01-31 00:17:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 00:17:16 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Dec 17, 2019).

We've made some great progress on testing recently. However, the TabTests are still incapable of creating types that user their own XAML file. Case in point here is TerminalPage. It fails when we attempt to InitializeComponent, because xaml attempts to load ms-appx:///TerminalApp/TerminalPage.xaml. I'm not really sure at the moment why that's not able to be loaded.

I do know that we're not using the resources.pri file here for this test. I've tried manually generating a resources.pri using a lightly modified version of CascadiaPackage's priconfig.xml and the following commands:

makepri new  /mn TerminalApp.LocalTests.AppxManifest.xml /pr . /cf mypriconfig4.xml /verbose /o
makepri dump /if resources.pri /of resources.xml /o

However, if I do that directly, then the App.xbf gets stuck into the resources.pri with the files we do need, which causes the test to explode again.

I tried manually moving the following files to a TerminalApp subdir of , and adding them to filtered.layout.resfiles. That got them into Files/TerminalApp in the resources.pri file, but didn't fix the loading issue. Seemed like they only had their paths added, not the files themselves.

TerminalApp\MinMaxCloseControl.xbf
TerminalApp\TabRowControl.xbf
TerminalApp\TerminalPage.xbf
TerminalApp\TitlebarControl.xbf

I also tried just not compiling App.xaml/idl/h/cpp as a part of TerminalAppLib.vcxproj, and still just including the ...\x64\Debug\TerminalAppLib\TerminalApp.pri line in pri.resfiles. This placed the TerminalApp .xbf files in the right place, without the App.xbf, but it still failed to parse TerminalPage.xaml. I was hoping that I could just move App.xaml to it's own project, and get rd of a bunch of this chaos. Unfortunately, this did not work.

I don't have any ideas how to fix this at the moment.

Originally created by @zadjii-msft on GitHub (Dec 17, 2019). We've made some great progress on testing recently. However, the `TabTests` are still incapable of creating types that user their own XAML file. Case in point here is `TerminalPage`. It fails when we attempt to `InitializeComponent`, because xaml attempts to load `ms-appx:///TerminalApp/TerminalPage.xaml`. I'm not really sure at the moment why that's not able to be loaded. I do know that we're not using the `resources.pri` file here for this test. I've tried manually generating a `resources.pri` using a lightly modified version of `CascadiaPackage`'s `priconfig.xml` and the following commands: ``` makepri new /mn TerminalApp.LocalTests.AppxManifest.xml /pr . /cf mypriconfig4.xml /verbose /o makepri dump /if resources.pri /of resources.xml /o ``` However, if I do that directly, then the `App.xbf` gets stuck into the `resources.pri` with the files we do need, which causes the test to explode again. I tried manually moving the following files to a `TerminalApp` subdir of , and adding them to `filtered.layout.resfiles`. That got them into `Files/TerminalApp` in the `resources.pri` file, but didn't fix the loading issue. Seemed like they only had their paths added, not the files themselves. ``` TerminalApp\MinMaxCloseControl.xbf TerminalApp\TabRowControl.xbf TerminalApp\TerminalPage.xbf TerminalApp\TitlebarControl.xbf ``` I also tried just _not_ compiling App.xaml/idl/h/cpp as a part of `TerminalAppLib.vcxproj`, and still just including the `...\x64\Debug\TerminalAppLib\TerminalApp.pri` line in `pri.resfiles`. This placed the `TerminalApp` .xbf files in the right place, without the `App.xbf`, but it _still_ failed to parse `TerminalPage.xaml`. I was hoping that I could just move `App.xaml` to it's own project, and get rd of a bunch of this chaos. Unfortunately, this did not work. I don't have any ideas how to fix this at the moment.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Area-CodeHealth Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5606
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?