starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Investigate Defering Pane initialization until after layout is completed #5619

New Issue
Closed
opened 2026-01-31 00:17:36 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:17:36 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Dec 17, 2019).

Found during the course of investigating #607. Right now we attempt to create the UI of the Pane immediately on construction. While investigating commandline args, I'd try to create a bunch of Panes. This didn't work, because the Pane would have 0 height/width, and would fail to create the UI, or attache the child, until a resize came through.

This is overall bad. We should probably wait until we complete the first layout to calculate how much size we have. Part of the reason this was so bad is that we're manually setting the width/height of our rows/columns to the number of pixels equal to some % of what's available. When that's being calculated, there's only 0px available.

Originally created by @zadjii-msft on GitHub (Dec 17, 2019). Found during the course of investigating #607. Right now we attempt to create the UI of the Pane _immediately_ on construction. While investigating commandline args, I'd try to create a bunch of `Pane`s. This didn't work, because the Pane would have 0 height/width, and would fail to create the UI, or attache the child, until a resize came through. This is overall bad. We should probably wait until we complete the first layout to calculate how much size we have. Part of the reason this was so bad is that we're manually setting the width/height of our rows/columns to the number of pixels equal to some % of what's available. When that's being calculated, there's only 0px available.
claunia added the Issue-TaskNeeds-Tag-FixProduct-TerminalArea-UserInterface labels 2026-01-31 00:17:36 +00:00
claunia commented 2026-01-31 00:17:37 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 17, 2019):

I just had a crazy thought. Have we been missing something Xaml gives us for free for a long time?

<ColumnDefinition Width="49*" />
<ColumnDefinition Width="51*" />

Star sizes are proportional-weighted; perhaps we can parlay that into percentages?

@DHowett-MSFT commented on GitHub (Dec 17, 2019): I just had a crazy thought. Have we been missing something Xaml gives us for free for a long time? ``` <ColumnDefinition Width="49*" /> <ColumnDefinition Width="51*" /> ``` `Star` sizes are proportional-weighted; perhaps we can parlay that into percentages?
claunia commented 2026-01-31 00:17:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 17, 2019):

@DHowett-MSFT huh. Never considered that. Though, I don't think that'll really work, since I think those have to be integer values. When we add the pane snapping in #3181, the percentages won't be even integers anymore, we'll start getting crazy fractions.

@zadjii-msft commented on GitHub (Dec 17, 2019): @DHowett-MSFT huh. Never considered that. Though, I don't think that'll really work, since I think those have to be integer values. When we add the pane snapping in #3181, the percentages won't be even integers anymore, we'll start getting crazy fractions.
claunia commented 2026-01-31 00:17:37 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 17, 2019):

Nah, docs say they can be weird things like 0.5* and stuff.

@DHowett-MSFT commented on GitHub (Dec 17, 2019): Nah, docs say they can be weird things like `0.5*` and stuff.
claunia commented 2026-01-31 00:17:38 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 17, 2019):

no way. Then yea we could probably use that. Thanks for the tip!

@zadjii-msft commented on GitHub (Dec 17, 2019): no way. Then yea we could probably use that. Thanks for the tip!
claunia commented 2026-01-31 00:17:38 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 14, 2023):

Uh, it kinda looks like we already do this. Neat. Either that, or I firmly don't remember what I was talking about here. Either way:

@zadjii-msft commented on GitHub (Apr 14, 2023): Uh, it kinda looks like we already do this. Neat. Either that, or I firmly don't remember what I was talking about here. Either way:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?