starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Windows Terminal crash when background image path contains tilde #5628

New Issue
Closed
opened 2026-01-31 00:17:47 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 00:17:47 +00:00
Owner
Copy Link

Originally created by @patriksvensson on GitHub (Dec 17, 2019).

Environment

Windows build number: Microsoft Windows NT 10.0.19041.0
Windows Terminal version (if applicable): 0.7.3451.0

Steps to reproduce

In profiles.json under a profile, add a background image path that references the home directory ~.

{
    ...
    "profiles": [
        {
            "name": "Windows PowerShell",
            "backgroundImage": "~/Pictures/Console/PowerShell.png",
        }
    ...
}

Expected behavior

Should not crash. Should show the expected background image.

Actual behavior

Windows Terminal crash at startup.

Originally created by @patriksvensson on GitHub (Dec 17, 2019). # Environment ```none Windows build number: Microsoft Windows NT 10.0.19041.0 Windows Terminal version (if applicable): 0.7.3451.0 ``` # Steps to reproduce In `profiles.json` under a profile, add a background image path that references the home directory `~`. ```json { ... "profiles": [ { "name": "Windows PowerShell", "backgroundImage": "~/Pictures/Console/PowerShell.png", } ... } ``` # Expected behavior Should not crash. Should show the expected background image. # Actual behavior Windows Terminal crash at startup.
claunia added the Resolution-Duplicate label 2026-01-31 00:17:47 +00:00
claunia commented 2026-01-31 00:17:48 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 19, 2019):

This looks like a /dupe of #2329, which we'll reopen. They're largely the same bug caused by the same issue somewhere in XAML land.

@DHowett-MSFT commented on GitHub (Dec 19, 2019): This looks like a /dupe of #2329, which we'll reopen. They're largely the same bug caused by the same issue somewhere in XAML land.
claunia commented 2026-01-31 00:17:48 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 19, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Dec 19, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 00:17:48 +00:00
Author
Owner
Copy Link

@mkitzan commented on GitHub (Dec 19, 2019):

@DHowett-MSFT I'm not sure if this is a dup since a tilde in the icon path doesn't crash WT (at least, I wasn't able to repro with a few examples). Very weird.

@mkitzan commented on GitHub (Dec 19, 2019): @DHowett-MSFT I'm not sure if this is a dup since a tilde in the icon path doesn't crash WT (at least, I wasn't able to repro with a few examples). Very weird.
claunia commented 2026-01-31 00:17:48 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 19, 2019):

@mkitzan I believe they are, but for reasons I didn't quite explain up front. 😄 Invalid resource paths to images (or all types) that end up getting displayed on a XAML surface end up running through the internet resource downloader somewhere deep in, uh, internet explorer libraries. Depending on where the image would have appeared in the visual tree, the exception caused by failing to load it can come out of different places.
Sometimes, it'll come right out when you try to create the image resource. Other times, it'll only come out when you attempt to navigate to a screen that contains that resource.
Since icons and backgrounds are just stuck into image views at the end of the day, I believe they're the same issue.

@DHowett-MSFT commented on GitHub (Dec 19, 2019): @mkitzan I believe they are, but for reasons I didn't quite explain up front. :smile: Invalid resource paths to images (or all types) that end up getting displayed on a XAML surface end up running through the internet resource downloader somewhere deep in, uh, _internet explorer libraries_. Depending on where the image would have appeared in the visual tree, the exception caused by failing to load it can come out of different places. Sometimes, it'll come right out when you try to create the image resource. Other times, it'll only come out when you attempt to navigate to a screen that contains that resource. Since icons and backgrounds are just stuck into image views at the end of the day, I _believe_ they're the same issue.
claunia commented 2026-01-31 00:17:48 +00:00
Author
Owner
Copy Link

@mkitzan commented on GitHub (Dec 19, 2019):

That makes a lot more sense. The image loading relation definitely is a key link between the two. Thanks for the explanation! Internet explorer libraries... I'm both horrified and intrigued.

@mkitzan commented on GitHub (Dec 19, 2019): That makes a lot more sense. The image loading relation definitely is a key link between the two. Thanks for the explanation! Internet explorer libraries... I'm both horrified and intrigued.
claunia commented 2026-01-31 00:17:48 +00:00
Author
Owner
Copy Link

@patriksvensson commented on GitHub (Dec 23, 2019):

@DHowett-MSFT Ah, I was looking for dupes before posting this but couldn't find any. Sorry! 😅

@patriksvensson commented on GitHub (Dec 23, 2019): @DHowett-MSFT Ah, I was looking for dupes before posting this but couldn't find any. Sorry! 😅
claunia commented 2026-01-31 00:17:49 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 23, 2019):

Ah, don’t worry about that: we reopened a closed bug as the duplicate of this one, and I don’t expect people to find those as readily. :)

@DHowett-MSFT commented on GitHub (Dec 23, 2019): Ah, don’t worry about that: we reopened a closed bug as the duplicate of this one, and I don’t expect people to find those as readily. :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5628
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?