starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Dragging conhost across a DPI boundary crashes it (Debug only 🤞) #5638

New Issue
Closed
opened 2026-01-31 00:18:01 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 00:18:01 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Dec 18, 2019).

Problem is in our WM_GETDPISCALEDSIZE handler:

    case WM_GETDPISCALEDSIZE:
    {
        // This message will send us the DPI we're about to be changed to.
        // Our goal is to use it to try to figure out the Window Rect that we'll need at that DPI to maintain
        // the same client rendering that we have now.

        // First retrieve the new DPI and the current DPI.
        DWORD const dpiProposed = (WORD)wParam;
        DWORD const dpiCurrent = g.dpi;

        // Now we need to get what the font size *would be* if we had this new DPI. We need to ask the renderer about that.
        const FontInfo& fiCurrent = ScreenInfo.GetCurrentFont();
        FontInfoDesired fiDesired(fiCurrent);
        FontInfo fiProposed(nullptr, 0, 0, { 0, 0 }, 0);
        ...

the line:

FontInfo fiProposed(nullptr, 0, 0, { 0, 0 }, 0);

crashes, because we're trying to make a string_view from a nullptr? The top of the stack is:

0:002> k
 # Child-SP          RetAddr           Call Site
00 00000032`ea2fd3c0 00007ff6`8c9f9647 OpenConsole!std::_WChar_traits<wchar_t>::length+0x4d 
01 00000032`ea2fd400 00007ff6`8c9fa396 OpenConsole!std::basic_string_view<wchar_t,std::char_traits<wchar_t> >::basic_string_view<wchar_t,std::char_traits<wchar_t> >+0x47 
02 00000032`ea2fd430 00007ff6`8c9f9d4b OpenConsole!Microsoft::Console::Interactivity::Win32::Window::ConsoleWindowProc+0x616 
03 00000032`ea2fdcb0 00007ffd`5e57e108 OpenConsole!Microsoft::Console::Interactivity::Win32::Window::s_ConsoleWindowProc+0xab  
...

I don't know when this regressed quite yet. Unsure if it repros in Release builds, or what. Doesn't repro in the 191206 VB_RELEASE build, nor the 191212 RS_ONECORE_DEP build. Maybe this is Debug only.

Originally created by @zadjii-msft on GitHub (Dec 18, 2019). Problem is in our `WM_GETDPISCALEDSIZE` handler: ```c++ case WM_GETDPISCALEDSIZE: { // This message will send us the DPI we're about to be changed to. // Our goal is to use it to try to figure out the Window Rect that we'll need at that DPI to maintain // the same client rendering that we have now. // First retrieve the new DPI and the current DPI. DWORD const dpiProposed = (WORD)wParam; DWORD const dpiCurrent = g.dpi; // Now we need to get what the font size *would be* if we had this new DPI. We need to ask the renderer about that. const FontInfo& fiCurrent = ScreenInfo.GetCurrentFont(); FontInfoDesired fiDesired(fiCurrent); FontInfo fiProposed(nullptr, 0, 0, { 0, 0 }, 0); ... ``` the line: ```c++ FontInfo fiProposed(nullptr, 0, 0, { 0, 0 }, 0); ``` crashes, because we're trying to make a string_view from a nullptr? The top of the stack is: ``` 0:002> k # Child-SP RetAddr Call Site 00 00000032`ea2fd3c0 00007ff6`8c9f9647 OpenConsole!std::_WChar_traits<wchar_t>::length+0x4d 01 00000032`ea2fd400 00007ff6`8c9fa396 OpenConsole!std::basic_string_view<wchar_t,std::char_traits<wchar_t> >::basic_string_view<wchar_t,std::char_traits<wchar_t> >+0x47 02 00000032`ea2fd430 00007ff6`8c9f9d4b OpenConsole!Microsoft::Console::Interactivity::Win32::Window::ConsoleWindowProc+0x616 03 00000032`ea2fdcb0 00007ffd`5e57e108 OpenConsole!Microsoft::Console::Interactivity::Win32::Window::s_ConsoleWindowProc+0xab ... ``` I don't know when this regressed quite yet. Unsure if it repros in Release builds, or what. Doesn't repro in the 191206 VB_RELEASE build, nor the 191212 RS_ONECORE_DEP build. Maybe this is Debug only.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Interaction Issue-Bug Priority-1 Product-Conhost Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5638
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?