Pressing Enter to input the IME string also sends Enter to shell, making shell to execute the string as a command #5667

Closed
opened 2026-01-31 00:18:47 +00:00 by claunia · 5 comments
Owner

Originally created by @driver1998 on GitHub (Dec 22, 2019).

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 10.0.19536.1000
Windows Terminal version (if applicable): 0.7.3451.0

Any other software?

Steps to reproduce

Type something in IME, Microsoft Pinyin IME in this case.
QQ截图20191222185039

Use the space bar to select the first candidate, "中文输入法" in this case.

Expected behavior

Exactly "中文输入法“ is inserted.

Actual behavior

An additional space is added at the end.
QQ截图20191222185158

When I select candidates with number keys, or by clicking them, it works as expected.

Additionally, if I press Enter to input the pinyin string, the additional Enter is also inserted to terminal, making shell to execute that string as a command.
QQ截图20191222185727
Press Enter
QQ截图20191222185735

Originally created by @driver1998 on GitHub (Dec 22, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] 10.0.19536.1000 Windows Terminal version (if applicable): 0.7.3451.0 Any other software? ``` # Steps to reproduce Type something in IME, Microsoft Pinyin IME in this case. ![QQ截图20191222185039](https://user-images.githubusercontent.com/22699485/71320834-00a64580-24ec-11ea-88ef-25824d9d52c7.png) Use the space bar to select the first candidate, "中文输入法" in this case. <!-- A description of how to trigger this bug. --> # Expected behavior Exactly "中文输入法“ is inserted. <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior An additional space is added at the end. ![QQ截图20191222185158](https://user-images.githubusercontent.com/22699485/71320846-351a0180-24ec-11ea-841e-5bc20316f6b6.png) When I select candidates with number keys, or by clicking them, it works as expected. Additionally, if I press Enter to input the pinyin string, the additional Enter is also inserted to terminal, making shell to execute that string as a command. ![QQ截图20191222185727](https://user-images.githubusercontent.com/22699485/71320890-f173c780-24ec-11ea-976f-93c04bf06d26.png) **Press Enter** ![QQ截图20191222185735](https://user-images.githubusercontent.com/22699485/71320893-f9336c00-24ec-11ea-966f-590a37497aa5.png) <!-- What's actually happening? -->
Author
Owner

@zadjii-msft commented on GitHub (Dec 30, 2019):

So largely, this is a dupe of #3982. However, I'm going to keep this open for the following part of the bug report:

Additionally, if I press Enter to input the pinyin string, the additional Enter is also inserted to terminal, making shell to execute that string as a command.

That shouldn't happen.

@zadjii-msft commented on GitHub (Dec 30, 2019): So largely, this is a dupe of #3982. However, I'm going to keep this open for the following part of the bug report: > Additionally, if I press Enter to input the pinyin string, the additional Enter is also inserted to terminal, making shell to execute that string as a command. That shouldn't happen.
Author
Owner

@skyline75489 commented on GitHub (Dec 31, 2019):

I'm using 10.0.18363.418 and I can't seem to reproduce this. Maybe it only happens on insider preview?

@skyline75489 commented on GitHub (Dec 31, 2019): I'm using 10.0.18363.418 and I can't seem to reproduce this. Maybe it only happens on insider preview?
Author
Owner

@driver1998 commented on GitHub (Jan 1, 2020):

Looks like both this and #3982 only happens when you use the "new version" of Pinyin IME (aka the TSF3 UWP UI, with fluent design), it does not happen when you use the "old version".

@driver1998 commented on GitHub (Jan 1, 2020): Looks like both this and #3982 only happens when you use the "new version" of Pinyin IME (aka the TSF3 UWP UI, with fluent design), it does not happen when you use the "old version".
Author
Owner

@driver1998 commented on GitHub (Jan 15, 2020):

Seems to be fixed on v0.8 and/or build 19541, validation needed.

@driver1998 commented on GitHub (Jan 15, 2020): Seems to be fixed on v0.8 and/or build 19541, validation needed.
Author
Owner

@driver1998 commented on GitHub (Feb 4, 2020):

This is indeed fixed on v0.8, close this issue.

@driver1998 commented on GitHub (Feb 4, 2020): This is indeed fixed on v0.8, close this issue.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5667