starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

OperatorColor and ParameterColor are same color as background on Solarized Dark #5679

New Issue
Closed
opened 2026-01-31 00:19:05 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 00:19:05 +00:00
Owner
Copy Link

Originally created by @duckness on GitHub (Dec 23, 2019).

Environment

Windows build number: Microsoft Windows NT 10.0.18363.0
Windows Terminal version (if applicable): 0.7.3451.0

Any other software?

Steps to reproduce

Leaving other settings as default, set on the profile: "colorScheme": "Solarized Dark"

Expected behavior

Text is not the same color as the background.

Actual behavior

OperatorColor and ParameterColor are same color as background
WindowsTerminal_7iJtSJmZkh

Originally created by @duckness on GitHub (Dec 23, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Microsoft Windows NT 10.0.18363.0 Windows Terminal version (if applicable): 0.7.3451.0 Any other software? ``` # Steps to reproduce Leaving other settings as default, set on the profile: `"colorScheme": "Solarized Dark"` <!-- A description of how to trigger this bug. --> # Expected behavior Text is not the same color as the background. <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior <!-- What's actually happening? --> `OperatorColor` and `ParameterColor` are same color as background ![WindowsTerminal_7iJtSJmZkh](https://user-images.githubusercontent.com/6380270/71335214-97224780-257c-11ea-8d1b-50fc22729fa0.png)
claunia commented 2026-01-31 00:19:06 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 25, 2019):

That's just the way the Solarized Dark color scheme is setup. The default background color is set to "bright black" rather than "black", so if the foreground is set to "bright black", it's going to invisible. Frankly it's just not a good color scheme for a terminal.

@j4james commented on GitHub (Dec 25, 2019): That's just the way the _Solarized Dark_ color scheme is setup. The default background color is set to "bright black" rather than "black", so if the foreground is set to "bright black", it's going to invisible. Frankly it's just not a good color scheme for a terminal.
claunia commented 2026-01-31 00:19:07 +00:00
Author
Owner
Copy Link

@duckness commented on GitHub (Dec 25, 2019):

That's just the way the Solarized Dark color scheme is setup.

I see. What is the intent/reason that it is set up in this manner? I do not recall having this issue using this theme in other terminals.

@duckness commented on GitHub (Dec 25, 2019): > That's just the way the Solarized Dark color scheme is setup. I see. What is the intent/reason that it is set up in this manner? I do not recall having this issue using this theme in other terminals.
claunia commented 2026-01-31 00:19:07 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 25, 2019):

My understanding is the Solarized scheme was originally designed for syntax highlighting, and it doesn't have the right range of colors for a terminal color scheme. Trying to use that exact same palette just doesn't map very well to terminal colors, and no mapping of that sort will ever be sensible (although the "official" one seems particularly bad IMHO).

As for why you may not have this problem in other terminals, it's likely they just aren't using the official Solarized colors. Conemu, for example, has four variations of the Solarized scheme, none of which match the official colors. So if there is some version of the scheme that you like in another terminal, I'd recommend you just convert those values into an equivalent Windows Terminal scheme.

@j4james commented on GitHub (Dec 25, 2019): My understanding is the _Solarized_ scheme was originally designed for syntax highlighting, and it doesn't have the right range of colors for a terminal color scheme. Trying to use that exact same palette just doesn't map very well to terminal colors, and no mapping of that sort will ever be sensible (although the "official" one seems particularly bad IMHO). As for why you may not have this problem in other terminals, it's likely they just aren't using the official _Solarized_ colors. Conemu, for example, has four variations of the _Solarized_ scheme, none of which match the official colors. So if there is some version of the scheme that you like in another terminal, I'd recommend you just convert those values into an equivalent Windows Terminal scheme.
claunia commented 2026-01-31 00:19:07 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 6, 2020):

Looks like this has been answered. Thanks everyone!

@DHowett-MSFT commented on GitHub (Jan 6, 2020): Looks like this has been answered. Thanks everyone!
claunia commented 2026-01-31 00:19:07 +00:00
Author
Owner
Copy Link

@gavinbeatty commented on GitHub (Mar 18, 2020):

The provided Solarized Dark color scheme is unusable. I just wrote a long ffmpeg command and I absolutely needed to use a different scheme in order to fix a minor issue (-metadata:s:a:0 language=eng must be quoted as "-metadata:s:a:0" language=eng in powershell).

If the advice is for users to substitute their own scheme, I strongly recommend removing the default Solarized Dark scheme. Anyone using it is going to have a bad time, and by extension, have a bad time using Windows Terminal.

@gavinbeatty commented on GitHub (Mar 18, 2020): The provided Solarized Dark color scheme is unusable. I just wrote a long ffmpeg command and I absolutely *needed* to use a different scheme in order to fix a minor issue (`-metadata:s:a:0 language=eng` must be quoted as `"-metadata:s:a:0" language=eng` in powershell). If the advice is for users to substitute their own scheme, I strongly recommend removing the default Solarized Dark scheme. Anyone using it is going to have a bad time, and by extension, have a bad time using Windows Terminal.
claunia commented 2026-01-31 00:19:07 +00:00
Author
Owner
Copy Link

@M-Pixel commented on GitHub (Jun 20, 2020):

This is still an issue, it should not be closed. It is closely related to #6390 which is still open.

The Solarized Dark theme that is included with the current version of Terminal defines brightBlack and background as the same color (source). brightBlack maps to [ConsoleColor]::DarkGray, which is the default color for Parameters in PowerShell 6.

In all other color schemes defined in defaults.json, black and background are set to the same values, or no other color has the same value as background; Solarized Dark is an anomaly in this regard. Unless somebody can justify this anomaly, it should be seen as a flaw that needs fixing.

The following steps reproduce the issue:

  • Install the latest version of Terminal from the Windows Store
  • Change the color scheme for PowerShell to Solarized Dark

Expected: I can enter a basic PowerShell command that uses flags, and see the text that I type.

Actual: Flag text is the same color as the background, and therefore cannot be seen unless it is highlighted.

@M-Pixel commented on GitHub (Jun 20, 2020): This is still an issue, it should not be closed. It is closely related to #6390 which is still open. The Solarized Dark theme that is included with the current version of Terminal defines `brightBlack` and `background` as the same color ([source](https://github.com/microsoft/terminal/blob/c1076a823d45f7c8b5e893fd8684f3947ea418ce/src/cascadia/TerminalApp/defaults.json#L198)). `brightBlack` maps to `[ConsoleColor]::DarkGray`, which is the default color for Parameters in PowerShell 6. In all _other_ color schemes defined in `defaults.json`, `black` and `background` are set to the same values, or no other color has the same value as `background`; Solarized Dark is an anomaly in this regard. Unless somebody can justify this anomaly, it should be seen as a flaw that needs fixing. The following steps reproduce the issue: - Install the latest version of Terminal from the Windows Store - Change the color scheme for PowerShell to Solarized Dark Expected: I can enter a basic PowerShell command that uses flags, and see the text that I type. Actual: Flag text is the same color as the background, and therefore cannot be seen unless it is highlighted.
claunia commented 2026-01-31 00:19:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 21, 2020):

:tada:This issue was addressed in #6985, which has now been successfully released as Windows Terminal v1.1.2021.0.🎉

Handy links:

@ghost commented on GitHub (Jul 21, 2020): :tada:This issue was addressed in #6985, which has now been successfully released as `Windows Terminal v1.1.2021.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.1.2021.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 00:19:08 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6985, which has now been successfully released as Windows Terminal v1.1.2021.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6985, which has now been successfully released as `Windows Terminal v1.1.2021.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.1.2021.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 00:19:08 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 22, 2020):

:tada:This issue was addressed in #6985, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.🎉

Handy links:

@ghost commented on GitHub (Jul 22, 2020): :tada:This issue was addressed in #6985, which has now been successfully released as `Windows Terminal Preview v1.2.2022.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.2.2022.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Question Needs-Tag-Fix Needs-Triage Product-Terminal Resolution-Answered Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5679
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?