starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Bug Report - Initial window size failed to account for display scaling for padding #5726

New Issue
Closed
opened 2026-01-31 00:20:08 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 00:20:08 +00:00
Owner
Copy Link

Originally created by @zypA13510 on GitHub (Dec 30, 2019).

Environment

Windows build number: [Version 10.0.18362.535]
Windows Terminal version (if applicable): 0.7.3451.0

Steps to reproduce

  1. In Windows settings, set display scaling to a value other than 100% (e.g. 150%)
  2. In profiles.json, set "initialRows" to 80, "initialCols" to 24, and "padding" of default profile to 0
  3. Run Windows Terminal, the console size should be 80x22 (2 rows smaller due to #2061)
  4. Now in profiles.json, set "padding" to 50
  5. Run Windows Terminal again, observe the console size
  6. Now in profiles.json, set "padding" to 100
  7. Run Windows Terminal, observe the console size

Expected behavior

In every case, the console size should be 80x24 (80x22 until #2061 is fixed)

Actual behavior

When padding is set to 50: 76x20
When padding is set to 100: 72x19
Additionally, if display scaling is set to 100%, the console size is 80x22 in every case.

Originally created by @zypA13510 on GitHub (Dec 30, 2019). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [Version 10.0.18362.535] Windows Terminal version (if applicable): 0.7.3451.0 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. In Windows settings, set display scaling to a value other than 100% (e.g. 150%) 2. In `profiles.json`, set "initialRows" to 80, "initialCols" to 24, and "padding" of default profile to 0 3. Run Windows Terminal, the console size should be 80x22 (2 rows smaller due to #2061) 4. Now in `profiles.json`, set "padding" to 50 5. Run Windows Terminal again, observe the console size 6. Now in `profiles.json`, set "padding" to 100 7. Run Windows Terminal, observe the console size # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> In every case, the console size should be 80x24 (80x22 until #2061 is fixed) # Actual behavior <!-- What's actually happening? --> When padding is set to 50: 76x20 When padding is set to 100: 72x19 Additionally, if display scaling is set to 100%, the console size is 80x22 in every case.
claunia added the Resolution-Duplicate label 2026-01-31 00:20:08 +00:00
claunia commented 2026-01-31 00:20:09 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Dec 30, 2019):

#2061 seems like the master tracking bug for this issue. How is it different?

@DHowett-MSFT commented on GitHub (Dec 30, 2019): #2061 seems like the master tracking bug for this issue. How is it different?
claunia commented 2026-01-31 00:20:10 +00:00
Author
Owner
Copy Link

@zypA13510 commented on GitHub (Dec 30, 2019):

#2061 seems like the master tracking bug for this issue. How is it different?

@DHowett-MSFT if you judge by the title then yes, this is a subset of what's described in #2061, so is anything about having a wrong initial size. However, if you look at the description and most of the comments, #2061 is more about a fixed reduction in initialRows (40->37, 27->24, or on my computer, 25->23, 24->22, 22->20, note that the reduction in rows is constant and does not scale with padding), while this issue is more about the relationship between padding and initial size. It seems that, with higher display scaling, padding takes increasingly more rows and columns space from the initial settings (as you can see from my actual behavior section, 4 rows and 1-2 columns per 50 padding). Also, as I said, this issue does not happen if display scaling is set to 100%, whereas #2061 will happen regardless of display scaling.

So yes, depending on how you look at things, it may be a duplicate. But if you ask me, it's not.

Actually, I believe the cause of this issue could be that #1152 failed to account for the display scaling.

@zypA13510 commented on GitHub (Dec 30, 2019): > #2061 seems like the master tracking bug for this issue. How is it different? @DHowett-MSFT if you judge by the title then yes, this is a subset of what's described in #2061, so is anything about having a wrong initial size. However, if you look at the description and most of the comments, #2061 is more about a fixed reduction in `initialRows` (40->37, 27->24, or on my computer, 25->23, 24->22, 22->20, note that the reduction in rows is constant and does not scale with padding), while this issue is more about the relationship between padding and initial size. It seems that, with higher display scaling, padding takes increasingly more rows and columns space from the initial settings (as you can see from my actual behavior section, 4 rows and 1-2 columns per 50 padding). Also, as I said, this issue does not happen if display scaling is set to 100%, whereas #2061 will happen regardless of display scaling. So yes, depending on how you look at things, it may be a duplicate. But if you ask me, it's not. Actually, I believe the cause of this issue could be that #1152 failed to account for the display scaling.
claunia commented 2026-01-31 00:20:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 30, 2019):

Yea I'm pretty sure this should just be closed as a /dupe of #2061. The correct solution to #2061 will be making sure that both the IslandWindow and NonClientIslandWindow, make sure to account for padding, tab size, and scrollbar size, when both scaled and unscaled.

Thanks for all the extra details!

@zadjii-msft commented on GitHub (Dec 30, 2019): Yea I'm pretty sure this should just be closed as a /dupe of #2061. The _correct_ solution to #2061 will be making sure that both the `IslandWindow` and `NonClientIslandWindow`, make sure to account for padding, tab size, and scrollbar size, when both scaled and unscaled. Thanks for all the extra details!
claunia commented 2026-01-31 00:20:10 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 30, 2019):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Dec 30, 2019): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5726
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?