starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-23 23:45:08 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

profile.colorTable is broken #5744

New Issue
Closed
opened 2026-01-31 00:20:29 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:20:29 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Dec 31, 2019).

Originally assigned to: @DHowett-MSFT on GitHub.

Setting a colorTable in a profile was broken in microsoft/terminal@8ba8f35dc5 when we set the default _schemeName to Campbell. During the construction of a TerminalSettings, we apply the table and then the scheme. If we do it in a different order, or delete _schemeName when we find colorTable, it works fine.

However: nobody noticed. This is the perfect opportunity to kill that feature or replace it with "colorTable overlays on top of the scheme"!

Related: #1069.

Originally created by @DHowett-MSFT on GitHub (Dec 31, 2019). Originally assigned to: @DHowett-MSFT on GitHub. Setting a `colorTable` in a profile was broken in microsoft/terminal@8ba8f35dc5 when we set the default `_schemeName` to `Campbell`. During the construction of a `TerminalSettings`, we apply the table and _then_ the scheme. If we do it in a different order, or delete `_schemeName` when we find `colorTable`, it works fine. _However:_ nobody noticed. This is the perfect opportunity to _kill that feature_ or _replace it with "`colorTable` overlays on top of the scheme"_! Related: #1069.
claunia commented 2026-01-31 00:20:30 +00:00
Author
Owner
Copy Link

@mhintzke commented on GitHub (Feb 4, 2020):

@DHowett-MSFT I just tried to customize my colorTable and noticed none of my changes took effect. Finally tracked down this issue. Do you know of a work around for now by any chance or are we out of luck and forced to just use a colorScheme for now?

@mhintzke commented on GitHub (Feb 4, 2020): @DHowett-MSFT I just tried to customize my `colorTable` and noticed none of my changes took effect. Finally tracked down this issue. Do you know of a work around for now by any chance or are we out of luck and forced to just use a `colorScheme` for now?
claunia commented 2026-01-31 00:20:30 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 4, 2020):

Consensus among the team is that color schemes are better suited to this purpose: we never implemented individual color index overriding for tables overlaid on schemes, which would have been the only way to make them broadly useful.

If you don’t mind my asking, why might you prefer setting the color table in the profile over having a color scheme?

@DHowett-MSFT commented on GitHub (Feb 4, 2020): Consensus among the team is that color schemes are better suited to this purpose: we never implemented individual color index overriding for tables overlaid on schemes, which would have been the only way to make them broadly useful. If you don’t mind my asking, why might you prefer setting the color table in the profile over having a color scheme?
claunia commented 2026-01-31 00:20:30 +00:00
Author
Owner
Copy Link

@mhintzke commented on GitHub (Feb 4, 2020):

It is very possible that a scheme is what I'm after. I tried out a couple of the out-of-box ones like "One Half Dark" and "Solarized Dark", but there were minor tweaks I wanted to make as my oh-my-posh theme was causing some low contrast points for me that were hard look at. It is possible I am just not aware of how to use the Color Schemes properly.

I tried playing around with the profile.json a little, but the tooltip hints weren't enough for me to figure it out. Is there specific documentation on how to customize your own color scheme within this repository?

@mhintzke commented on GitHub (Feb 4, 2020): It is very possible that a scheme is what I'm after. I tried out a couple of the out-of-box ones like "One Half Dark" and "Solarized Dark", but there were minor tweaks I wanted to make as my `oh-my-posh` theme was causing some low contrast points for me that were hard look at. It is possible I am just not aware of how to use the Color Schemes properly. I tried playing around with the `profile.json` a little, but the tooltip hints weren't enough for me to figure it out. Is there specific documentation on how to customize your own color scheme within this repository?
claunia commented 2026-01-31 00:20:31 +00:00
Author
Owner
Copy Link

@mhintzke commented on GitHub (Feb 7, 2020):

Ok I have found a pretty easy path towards installing a bunch more color schemes. I'm not sure if I am just missing this documentation somewhere, but for any future people that are having an issue installing their own custom scheme here is what you do:

  1. From the Windows Terminal, open up Settings which will open up your profiles.json
  2. Find a Windows Terminal scheme from the iTerm2 github and then find it in the Windows Terminal folder here
  3. Copy the JSON in the theme you want to try and paste it into the "schemes": [] property inside the profiles.json you opened up in step 1
  4. Go up in the profiles.json and find the shell profile of the one you want to change (I changed PowerShell Core) and set the "colorScheme" to the name of the scheme you just pasted on step 3.

Voila!

@DHowett please let me know if there is some other documentation I can point to that already states this information. It would be great if there were instructions on how to do this in the root level README.md of this repository, no?

@mhintzke commented on GitHub (Feb 7, 2020): Ok I have found a pretty easy path towards installing a bunch more color schemes. I'm not sure if I am just missing this documentation somewhere, but for any future people that are having an issue installing their own custom scheme here is what you do: 1. From the Windows Terminal, open up Settings which will open up your `profiles.json` 2. Find a Windows Terminal scheme from the [iTerm2 github](https://github.com/mbadolato/iTerm2-Color-Schemes) and then find it in the [Windows Terminal folder here](https://github.com/mbadolato/iTerm2-Color-Schemes/tree/master/windowsterminal) 3. Copy the JSON in the theme you want to try and paste it into the `"schemes": []` property inside the `profiles.json` you opened up in step 1 4. Go up in the `profiles.json` and find the shell profile of the one you want to change (I changed PowerShell Core) and set the `"colorScheme"` to the name of the scheme you just pasted on step 3. Voila! @DHowett please let me know if there is some other documentation I can point to that already states this information. It would be great if there were instructions on how to do this in the root level README.md of this repository, no?
claunia commented 2026-01-31 00:20:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5190, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5190, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5744
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?