starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal displays incorrect warning when we fail to parse a GUID #5755

New Issue
Closed
opened 2026-01-31 00:20:51 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 00:20:51 +00:00
Owner
Copy Link

Originally created by @jagansankara on GitHub (Jan 2, 2020).

Environment

Windows build number:  Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0
Windows Terminal version (if applicable): Version: 0.7.3451.0

Steps to reproduce

  1. Open profile.json file.
  2. Add new profile details.
  3. Save profile.json file

Sample file
profiles.json.txt

Expected behavior

Saved profile should be reflected in WT menu.

Actual behavior

Getting parsing error in Windows Terminal application even though setting is valid.
image

Originally created by @jagansankara on GitHub (Jan 2, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Win32NT 10.0.18363.0 Microsoft Windows NT 10.0.18363.0 Windows Terminal version (if applicable): Version: 0.7.3451.0 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. Open profile.json file. 2. Add new profile details. 3. Save profile.json file Sample file [profiles.json.txt](https://github.com/microsoft/terminal/files/4016144/profiles.json.txt) # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> Saved profile should be reflected in WT menu. # Actual behavior <!-- What's actually happening? --> Getting parsing error in Windows Terminal application even though setting is valid. ![image](https://user-images.githubusercontent.com/10755858/71671836-147a6300-2d9a-11ea-9910-8aeb0845e952.png)
claunia commented 2026-01-31 00:20:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 2, 2020):

"{b453ae62-4e3d-5e58-b989-0a998ec441b82}" Isn't a valid GUID - we should probably have a better warning there for invalid GUIDs.

You could probably get away with deleting the guid field entirely from that profile, though, you'd still need to manually set a commandline for it to do something.

@zadjii-msft commented on GitHub (Jan 2, 2020): `"{b453ae62-4e3d-5e58-b989-0a998ec441b82}"` Isn't a valid GUID - we should probably have a better warning there for invalid GUIDs. You could probably get away with deleting the `guid` field entirely from that profile, though, you'd still need to manually set a `commandline` for it to do something.
claunia commented 2026-01-31 00:20:53 +00:00
Author
Owner
Copy Link

@jagansankara commented on GitHub (Jan 3, 2020):

Without guid how can we set defaultProfile value ?

If guid is mandatory, how can we generate for custom profile ?

@jagansankara commented on GitHub (Jan 3, 2020): Without `guid` how can we set `defaultProfile` value ? If `guid` is mandatory, how can we generate for custom profile ?
claunia commented 2026-01-31 00:20:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2020):

@jagansankara You've got me there. If you want to set the profile as the default profile, you'll need to give it a valid GUID.

@zadjii-msft commented on GitHub (Jan 3, 2020): @jagansankara You've got me there. If you want to set the profile as the default profile, you'll need to give it a valid GUID.
claunia commented 2026-01-31 00:20:53 +00:00
Author
Owner
Copy Link

@jagansankara commented on GitHub (Jan 3, 2020):

@zadjii-msft That's what i'm asking. What is valid GUID. Sorry to ask this. I know nothing about Windows system id's.

@jagansankara commented on GitHub (Jan 3, 2020): @zadjii-msft That's what i'm asking. What is valid GUID. Sorry to ask this. I know nothing about Windows system id's.
claunia commented 2026-01-31 00:20:53 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2020):

GUID (or UUID) is an acronym for 'Globally Unique Identifier' (or 'Universally Unique Identifier'). It is a 128-bit integer number used to identify resources. The term GUID is generally used by developers working with Microsoft technologies, while UUID is used everywhere else.

You can use https://www.guidgenerator.com/ to generate them. The problem you were having was that the string you were using, "{b453ae62-4e3d-5e58-b989-0a998ec441b82}" is not a GUID - it has one too many digits. You can't just append digits to the GUID string like that

@zadjii-msft commented on GitHub (Jan 3, 2020): > GUID (or UUID) is an acronym for 'Globally Unique Identifier' (or 'Universally Unique Identifier'). It is a 128-bit integer number used to identify resources. The term GUID is generally used by developers working with Microsoft technologies, while UUID is used everywhere else. You can use https://www.guidgenerator.com/ to generate them. The problem you were having was that the string you were using, `"{b453ae62-4e3d-5e58-b989-0a998ec441b82}"` is _not_ a GUID - it has one too many digits. You can't just append digits to the GUID string like that
claunia commented 2026-01-31 00:20:53 +00:00
Author
Owner
Copy Link

@jagansankara commented on GitHub (Jan 3, 2020):

Thanks @zadjii-msft . As you said earlier in your comment If we have separate ticket for warning issue, we can close this issue.

@jagansankara commented on GitHub (Jan 3, 2020): Thanks @zadjii-msft . As you said earlier in your comment If we have separate ticket for warning issue, we can close this issue.
claunia commented 2026-01-31 00:20:54 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 23, 2020):

Hey so this is a subset of #4299 so I'm closing it as a dupe.

/dup #4299

Thanks!

@zadjii-msft commented on GitHub (Jan 23, 2020): Hey so this is a subset of #4299 so I'm closing it as a dupe. /dup #4299 Thanks!
claunia commented 2026-01-31 00:20:54 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 23, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jan 23, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 00:20:54 +00:00
Author
Owner
Copy Link

@Piot1998 commented on GitHub (Feb 28, 2021):

I have the same problem with this message only when trying to modify myself https://www.bleepingcomputer.com/news/microsoft/windows-terminal-now-has-a-hidden-graphical-settings-editor/ in windows terminal . What can I do in such a situation?

@Piot1998 commented on GitHub (Feb 28, 2021): I have the same problem with this message only when trying to modify myself https://www.bleepingcomputer.com/news/microsoft/windows-terminal-now-has-a-hidden-graphical-settings-editor/ in windows terminal . What can I do in such a situation?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Priority-3 Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5755
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?